From: Joseph Mingrone <jrm@ftfl.ca>
To: Andrea Corallo <akrl@sdf.org>
Cc: emacs-devel@gnu.org, "Mattias Engdegård" <mattiase@acm.org>,
emacs@FreeBSD.org
Subject: Re: master 52b67740d10: Generalise a LAP optimisation rule
Date: Tue, 04 Apr 2023 13:13:45 -0300 [thread overview]
Message-ID: <86cz4j1v7q.fsf@phe.ftfl.ca> (raw)
In-Reply-To: <xjfmt3ojcer.fsf@ma.sdf.org> (Andrea Corallo's message of "Tue, 04 Apr 2023 08:10:20 +0000")
On Tue, 2023-04-04 at 08:10, Andrea Corallo <akrl@sdf.org> wrote:
> Joseph Mingrone <jrm@ftfl.ca> writes:
>> On Sat, 2023-03-25 at 12:22, Mattias Engdegård <mattiase@acm.org> wrote:
>>> branch: master
>>> commit 52b67740d10df8ca539fdc2c7d50283997683141
>>> Author: Mattias Engdegård <mattiase@acm.org>
>>> Commit: Mattias Engdegård <mattiase@acm.org>
>>> Generalise a LAP optimisation rule
>>> * lisp/emacs-lisp/byte-opt.el (byte-optimize-lapcode):
>>> Accept (stack-set 1) as equivalent to (discardN-preserve-tos 1) in a
>>> rule previously overlooked. This is usually beneficial in code size
>>> and almost always shortens dynamic paths.
>>> ---
>>> lisp/emacs-lisp/byte-opt.el | 4 +++-
>>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>> diff --git a/lisp/emacs-lisp/byte-opt.el b/lisp/emacs-lisp/byte-opt.el
>>> index 3c7aeb89525..0891ec80beb 100644
>>> --- a/lisp/emacs-lisp/byte-opt.el
>>> +++ b/lisp/emacs-lisp/byte-opt.el
>>> @@ -2765,7 +2765,9 @@ If FOR-EFFECT is non-nil, the return value is assumed to be of no importance."
>>> (or (memq (caar tmp) '(byte-discard byte-discardN))
>>> ;; Make sure we don't hoist a discardN-preserve-tos
>>> ;; that really should be merged or deleted instead.
>>> - (and (eq (caar tmp) 'byte-discardN-preserve-tos)
>>> + (and (or (eq (caar tmp) 'byte-discardN-preserve-tos)
>>> + (and (eq (caar tmp) 'byte-stack-set)
>>> + (eql (cdar tmp) 1)))
>>> (let ((next (cadr tmp)))
>>> (not (or (memq (car next)
>>> '(byte-discardN-preserve-tos
>> Hello,
>> This commit causes native compilation builds on FreeBSD to fail with the error
>> native-ice ("org/org-plot.el" "block does not end with a branch"...
>> The full error is below and a link to a complete build log (FreeBSD
>> package build) is also included.
>> When the commit is reverted, the build finishes successfully again.
>> Joe
> Hi Joe,
> thanks for reporting, yes we are tracking this as bug#62537.
> Best Regards
> Andrea
Hi Andrea,
Sure and thanks to you and Eli for clarification. Also, apologies for
not locating bug#62537 before reporting there.
Kind regards,
Joe
prev parent reply other threads:[~2023-04-04 16:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <167976134206.19776.1825822435181145052@vcs2.savannah.gnu.org>
[not found] ` <20230325162222.64223C1391B@vcs2.savannah.gnu.org>
2023-04-03 17:41 ` master 52b67740d10: Generalise a LAP optimisation rule Joseph Mingrone
2023-04-03 17:45 ` Eli Zaretskii
2023-04-04 8:10 ` Andrea Corallo
2023-04-04 16:13 ` Joseph Mingrone [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86cz4j1v7q.fsf@phe.ftfl.ca \
--to=jrm@ftfl.ca \
--cc=akrl@sdf.org \
--cc=emacs-devel@gnu.org \
--cc=emacs@FreeBSD.org \
--cc=mattiase@acm.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.