From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Joseph Mingrone Newsgroups: gmane.emacs.devel Subject: Re: master 52b67740d10: Generalise a LAP optimisation rule Date: Tue, 04 Apr 2023 13:13:45 -0300 Message-ID: <86cz4j1v7q.fsf@phe.ftfl.ca> References: <167976134206.19776.1825822435181145052@vcs2.savannah.gnu.org> <20230325162222.64223C1391B@vcs2.savannah.gnu.org> <86ttxw3ltj.fsf@phe.ftfl.ca> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18826"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-devel@gnu.org, Mattias =?utf-8?Q?Engdeg=C3=A5rd?= , emacs@FreeBSD.org To: Andrea Corallo Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Apr 04 18:14:14 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pjjIU-0004ek-Ej for ged-emacs-devel@m.gmane-mx.org; Tue, 04 Apr 2023 18:14:14 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pjjI9-0006Ob-Of; Tue, 04 Apr 2023 12:13:53 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pjjI7-0006Nv-4G for emacs-devel@gnu.org; Tue, 04 Apr 2023 12:13:51 -0400 Original-Received: from mail-qv1-xf32.google.com ([2607:f8b0:4864:20::f32]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pjjI4-0001M6-Qk for emacs-devel@gnu.org; Tue, 04 Apr 2023 12:13:50 -0400 Original-Received: by mail-qv1-xf32.google.com with SMTP id m6so23935116qvq.0 for ; Tue, 04 Apr 2023 09:13:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ftfl.ca; s=google; t=1680624827; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=q5NHVy+yZZPsGC/jZ3+pnGqVq9klgAMNkljcjMFFyn0=; b=BaBUerYOr1y0WngCTPAGhFfTssQ0PNWqfkMjSjuf7vX4w2npKxMbGOQEntAttX5nwt 9r+DZ56bNbkLKoS3kmvDHzcB1i7jU7mqjiwMgMwBtarJaPb7ma3CplWl0Ak3m1iFHdfZ ac94F+FNQQ9cbQx/Iy5VqiXshMuHqHe9Nj4rw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680624827; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=q5NHVy+yZZPsGC/jZ3+pnGqVq9klgAMNkljcjMFFyn0=; b=2Rgh5InFzHUXQa8WYcatqJMVmlI5Mr59hu2nOksNwHRKeWvVdwq4OxitsXKr3xqBXQ w/oIY0gJAmKQlga6/b6nJm/nBSDV47PVuk+Apz2rLF0ObHthB9QUmPkKWXHIVKjFT4Xl fnSIJbVm/ReP5rjrCbsOXjuC/HFQRluTEyUIdZt4n75xNnoNrUkNpr94GmQ0+S371NDg 35j+msQ4qS1PPZfIiEVC52tI4zQhVYZs3WW4nxFN15zNIw10Etn2/4Iw9w8rjxBLrJET kTK607gAl5kS/O8JVqxdd9BYpAGzHfOvr77E8CAbVu16KypMLhAVoQ7ZHfwWr+A50r9a TVeg== X-Gm-Message-State: AAQBX9cc/180lPvDcRdjEh3kAOXBckVfu4NBw4pmqYTkXFSmfqfeyicT oUi2kLkEAN3cyLeUeAWESM4V2A== X-Google-Smtp-Source: AKy350Y0VCk9PoD+wp7gxhRXZBpgwkbsx81hgDDNiY92RPz84Vxtpzxr0Mb+FeL6JpFeeVO84B4Iug== X-Received: by 2002:a05:6214:20a6:b0:5c9:278d:f0a5 with SMTP id 6-20020a05621420a600b005c9278df0a5mr4050968qvd.52.1680624827290; Tue, 04 Apr 2023 09:13:47 -0700 (PDT) Original-Received: from phe.ftfl.ca.ftfl.ca (drmons0544w-156-34-187-123.dhcp-dynamic.fibreop.ns.bellaliant.net. [156.34.187.123]) by smtp.gmail.com with ESMTPSA id k15-20020a0cc78f000000b005e147356c5dsm3507953qvj.125.2023.04.04.09.13.46 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 04 Apr 2023 09:13:46 -0700 (PDT) In-Reply-To: (Andrea Corallo's message of "Tue, 04 Apr 2023 08:10:20 +0000") Received-SPF: pass client-ip=2607:f8b0:4864:20::f32; envelope-from=jrm@ftfl.ca; helo=mail-qv1-xf32.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:305111 Archived-At: On Tue, 2023-04-04 at 08:10, Andrea Corallo wrote: > Joseph Mingrone writes: >> On Sat, 2023-03-25 at 12:22, Mattias Engdeg=C3=83=C2=A5rd wrote: >>> branch: master >>> commit 52b67740d10df8ca539fdc2c7d50283997683141 >>> Author: Mattias Engdeg=C3=A5rd >>> Commit: Mattias Engdeg=C3=A5rd >>> Generalise a LAP optimisation rule >>> * lisp/emacs-lisp/byte-opt.el (byte-optimize-lapcode): >>> Accept (stack-set 1) as equivalent to (discardN-preserve-tos 1) in a >>> rule previously overlooked. This is usually beneficial in code size >>> and almost always shortens dynamic paths. >>> --- >>> lisp/emacs-lisp/byte-opt.el | 4 +++- >>> 1 file changed, 3 insertions(+), 1 deletion(-) >>> diff --git a/lisp/emacs-lisp/byte-opt.el b/lisp/emacs-lisp/byte-opt.el >>> index 3c7aeb89525..0891ec80beb 100644 >>> --- a/lisp/emacs-lisp/byte-opt.el >>> +++ b/lisp/emacs-lisp/byte-opt.el >>> @@ -2765,7 +2765,9 @@ If FOR-EFFECT is non-nil, the return value is ass= umed to be of no importance." >>> (or (memq (caar tmp) '(byte-discard byte-discard= N)) >>> ;; Make sure we don't hoist a discardN-prese= rve-tos >>> ;; that really should be merged or deleted i= nstead. >>> - (and (eq (caar tmp) 'byte-discardN-preserve-= tos) >>> + (and (or (eq (caar tmp) 'byte-discardN-prese= rve-tos) >>> + (and (eq (caar tmp) 'byte-stack-set) >>> + (eql (cdar tmp) 1))) >>> (let ((next (cadr tmp))) >>> (not (or (memq (car next) >>> '(byte-discardN-preser= ve-tos >> Hello, >> This commit causes native compilation builds on FreeBSD to fail with the= error >> native-ice ("org/org-plot.el" "block does not end with a branch"... >> The full error is below and a link to a complete build log (FreeBSD >> package build) is also included. >> When the commit is reverted, the build finishes successfully again. >> Joe > Hi Joe, > thanks for reporting, yes we are tracking this as bug#62537. > Best Regards > Andrea Hi Andrea, Sure and thanks to you and Eli for clarification. Also, apologies for not locating bug#62537 before reporting there. Kind regards, Joe