From: Juri Linkov <juri@linkov.net>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: 62086@debbugs.gnu.org
Subject: bug#62086: 29.0.60; ruby-ts-mode regressions
Date: Fri, 10 Mar 2023 09:35:46 +0200 [thread overview]
Message-ID: <86bkl1gj15.fsf@mail.linkov.net> (raw)
In-Reply-To: <5abcf765-f8ce-9563-63aa-20c558409898@yandex.ru> (Dmitry Gutov's message of "Fri, 10 Mar 2023 00:02:14 +0200")
>> 'C-M-f' ('forward-sexp') commands currently are unusable in master
>> because they skip too much.
>
> I'm happy to discuss this sometime later, in a different report, preferably
> after Emacs 29's pre-release drops. We'd probably just need to tweak the
> relevant regexp.
>
> But from what I see, most of the possible confusion stems from it jumping
> over implicit parens, just like over explicit ones. The addition of binary
> operators and assignments might also have something to do with it.
That's the problem: some implicit parens are unexpected.
But let's adjust this later in another report.
>> So I relied on word motion commands like
>> 'M-f' ('forward-word') to move in ruby-ts-mode. But unfortunately
>> some recent change broke even word motion in emacs-29, so no motion commands
>> can be used in ruby-ts-mode, only motion by characters can be used with
>> 'C-f' ('forward-char'). Here is a recipe for recent regression in emacs-29:
>> 0. emacs -Q
>> 1. C-x C-f test/lisp/progmodes/ruby-mode-resources/ruby-parenless-call-arguments-indent.rb RET
>> 2. M-x ruby-ts-mode RET
>> 3. move point to after the first letter 'c'
>> 4. type 'M-f' ('forward-word')
>> It skips two words in symbols.
>
> I might have been too eager in propertizing symbol contents with the
> "symbol" syntax. Now fixed in emacs-29, commit ecdfd584a52.
Thanks, I confirm this is fixed.
>> I don't know if the second bug is related to this, but while
>> in the same file, also type 'C-M-l' ('reposition-window').
>> It raises the error:
>> Debugger entered--Lisp error: (wrong-type-argument number-or-marker-p
>> nil)
>> treesit-end-of-defun()
>> end-of-defun(-1)
>> reposition-window(nil nil)
>> reposition-window(nil 89)
>> funcall-interactively(reposition-window nil 89)
>> command-execute(reposition-window)
>> This regression is also recent.
>
> I've managed to reproduce this, but only once. Do you see this every time?
I see it only in some files in test/lisp/progmodes/ruby-mode-resources/
e.g. ruby-parenless-call-arguments-indent.rb, ruby-method-call-indent.rb,
ruby-block-indent.rb. But not in e.g. ruby-after-operator-indent.rb.
Also everywhere in test/lisp/progmodes/js-resources/js-indent-init-dynamic.js,
js-indent-init-t.js. But not in e.g. js-chain.js.
next prev parent reply other threads:[~2023-03-10 7:35 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-09 17:24 bug#62086: 29.0.60; ruby-ts-mode regressions Juri Linkov
2023-03-09 18:08 ` Eli Zaretskii
2023-03-10 7:29 ` Juri Linkov
2023-03-09 22:02 ` Dmitry Gutov
2023-03-10 7:35 ` Juri Linkov [this message]
2023-03-10 16:37 ` Dmitry Gutov
2023-04-03 16:29 ` Juri Linkov
2023-04-03 20:42 ` Dmitry Gutov
2023-04-04 7:16 ` Juri Linkov
2023-04-05 0:06 ` Dmitry Gutov
2023-04-05 6:24 ` Juri Linkov
2023-04-05 14:58 ` Dmitry Gutov
2023-04-05 16:25 ` Juri Linkov
2023-04-05 16:36 ` Dmitry Gutov
2023-04-11 16:53 ` Juri Linkov
2023-04-11 23:30 ` Dmitry Gutov
2023-04-12 7:05 ` Yuan Fu
2023-04-12 15:31 ` Dmitry Gutov
2023-04-12 20:13 ` Dmitry Gutov
2023-04-12 21:50 ` Yuan Fu
2023-04-12 21:56 ` Dmitry Gutov
2023-04-12 22:11 ` Yuan Fu
2023-04-15 0:08 ` Yuan Fu
2023-04-13 17:42 ` Juri Linkov
2023-04-14 17:03 ` Juri Linkov
2023-04-12 7:30 ` Eli Zaretskii
2023-04-12 15:31 ` Dmitry Gutov
2023-04-12 15:40 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86bkl1gj15.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=62086@debbugs.gnu.org \
--cc=dgutov@yandex.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.