From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#62086: 29.0.60; ruby-ts-mode regressions Date: Fri, 10 Mar 2023 09:35:46 +0200 Organization: LINKOV.NET Message-ID: <86bkl1gj15.fsf@mail.linkov.net> References: <86y1o5op2v.fsf@mail.linkov.net> <5abcf765-f8ce-9563-63aa-20c558409898@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1386"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) Cc: 62086@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Mar 10 08:43:38 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1paXPe-0000ED-6G for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 10 Mar 2023 08:43:38 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1paXPM-0004xG-8n; Fri, 10 Mar 2023 02:43:20 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1paXP5-0004v9-Pu for bug-gnu-emacs@gnu.org; Fri, 10 Mar 2023 02:43:07 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1paXP4-0000YU-FT for bug-gnu-emacs@gnu.org; Fri, 10 Mar 2023 02:43:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1paXP4-0006Gv-B4 for bug-gnu-emacs@gnu.org; Fri, 10 Mar 2023 02:43:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 10 Mar 2023 07:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62086 X-GNU-PR-Package: emacs Original-Received: via spool by 62086-submit@debbugs.gnu.org id=B62086.167843416924082 (code B ref 62086); Fri, 10 Mar 2023 07:43:02 +0000 Original-Received: (at 62086) by debbugs.gnu.org; 10 Mar 2023 07:42:49 +0000 Original-Received: from localhost ([127.0.0.1]:53586 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1paXOq-0006GM-II for submit@debbugs.gnu.org; Fri, 10 Mar 2023 02:42:48 -0500 Original-Received: from relay9-d.mail.gandi.net ([217.70.183.199]:34201) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1paXOo-0006Fw-Dk for 62086@debbugs.gnu.org; Fri, 10 Mar 2023 02:42:46 -0500 Original-Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 9A297FF80B; Fri, 10 Mar 2023 07:42:38 +0000 (UTC) In-Reply-To: <5abcf765-f8ce-9563-63aa-20c558409898@yandex.ru> (Dmitry Gutov's message of "Fri, 10 Mar 2023 00:02:14 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:257657 Archived-At: >> 'C-M-f' ('forward-sexp') commands currently are unusable in master >> because they skip too much. > > I'm happy to discuss this sometime later, in a different report, preferably > after Emacs 29's pre-release drops. We'd probably just need to tweak the > relevant regexp. > > But from what I see, most of the possible confusion stems from it jumping > over implicit parens, just like over explicit ones. The addition of binary > operators and assignments might also have something to do with it. That's the problem: some implicit parens are unexpected. But let's adjust this later in another report. >> So I relied on word motion commands like >> 'M-f' ('forward-word') to move in ruby-ts-mode. But unfortunately >> some recent change broke even word motion in emacs-29, so no motion commands >> can be used in ruby-ts-mode, only motion by characters can be used with >> 'C-f' ('forward-char'). Here is a recipe for recent regression in emacs-29: >> 0. emacs -Q >> 1. C-x C-f test/lisp/progmodes/ruby-mode-resources/ruby-parenless-call-arguments-indent.rb RET >> 2. M-x ruby-ts-mode RET >> 3. move point to after the first letter 'c' >> 4. type 'M-f' ('forward-word') >> It skips two words in symbols. > > I might have been too eager in propertizing symbol contents with the > "symbol" syntax. Now fixed in emacs-29, commit ecdfd584a52. Thanks, I confirm this is fixed. >> I don't know if the second bug is related to this, but while >> in the same file, also type 'C-M-l' ('reposition-window'). >> It raises the error: >> Debugger entered--Lisp error: (wrong-type-argument number-or-marker-p >> nil) >> treesit-end-of-defun() >> end-of-defun(-1) >> reposition-window(nil nil) >> reposition-window(nil 89) >> funcall-interactively(reposition-window nil 89) >> command-execute(reposition-window) >> This regression is also recent. > > I've managed to reproduce this, but only once. Do you see this every time? I see it only in some files in test/lisp/progmodes/ruby-mode-resources/ e.g. ruby-parenless-call-arguments-indent.rb, ruby-method-call-indent.rb, ruby-block-indent.rb. But not in e.g. ruby-after-operator-indent.rb. Also everywhere in test/lisp/progmodes/js-resources/js-indent-init-dynamic.js, js-indent-init-t.js. But not in e.g. js-chain.js.