From: Juri Linkov <juri@linkov.net>
To: Augusto Stoffel <arstoffel@gmail.com>
Cc: 62250@debbugs.gnu.org
Subject: bug#62250: 29.0.60; Allow context menu from text properties to not override everything
Date: Mon, 20 Mar 2023 20:34:59 +0200 [thread overview]
Message-ID: <86bkkns23w.fsf@mail.linkov.net> (raw)
In-Reply-To: <874jqgzjoe.fsf@gmail.com> (Augusto Stoffel's message of "Sun, 19 Mar 2023 19:21:21 +0100")
>> The patch below will allow using the text property like
>>
>> 'context-menu-functions '(image-context-menu)
>
> I didn't test the patch (I don't understand click events very well), but
> does it find the context-menu-functions property of overlays as well?
It should be able to find the property in overlays as well.
> And would those override the context-menu-functions text property or get
> merged?
This needs confirming, but I guess overlays take priority over text properties.
>> (run-hook-wrapped 'context-menu-functions
>> (lambda (fun)
>> (setq menu (funcall fun menu click))
>> - nil)))
>> + nil))
>> + (dolist (fun funs)
>> + (setq menu (funcall fun menu click))))
>>
>> ;; Remove duplicate separators as well as ones at the beginning or
>> ;; end of the menu.
>
> I believe this makes the menu entries coming from a text property appear
> after the regular hook ones, while I would expect the opposite (stuff
> specific to the point is more "urgent").
When text properties are processed later, they have a chance to decide
where they add their menu items: at the top of the context menu, at the
bottom, or anywhere in the middle.
next prev parent reply other threads:[~2023-03-20 18:34 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-18 7:51 bug#62250: 29.0.60; Allow context menu from text properties to not override everything Augusto Stoffel
2023-03-18 8:31 ` Eli Zaretskii
2023-03-18 11:19 ` Augusto Stoffel
2023-03-18 11:24 ` Eli Zaretskii
2023-03-18 11:29 ` Augusto Stoffel
2023-03-18 11:33 ` Eli Zaretskii
2023-03-18 18:10 ` Juri Linkov
2023-03-18 18:44 ` Augusto Stoffel
2023-03-19 17:40 ` Juri Linkov
2023-03-19 18:10 ` Augusto Stoffel
2023-03-20 18:29 ` Juri Linkov
2023-03-18 18:08 ` Juri Linkov
2023-03-18 18:39 ` Augusto Stoffel
2023-03-19 17:43 ` Juri Linkov
2023-03-19 18:21 ` Augusto Stoffel
2023-03-20 18:34 ` Juri Linkov [this message]
2023-04-02 16:35 ` Juri Linkov
2024-03-05 16:51 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86bkkns23w.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=62250@debbugs.gnu.org \
--cc=arstoffel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.