From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#62250: 29.0.60; Allow context menu from text properties to not override everything Date: Mon, 20 Mar 2023 20:34:59 +0200 Organization: LINKOV.NET Message-ID: <86bkkns23w.fsf@mail.linkov.net> References: <87ttyixzt2.fsf@gmail.com> <865yaxq5xh.fsf@mail.linkov.net> <87cz55rjir.fsf@gmail.com> <86fsa0r60v.fsf@mail.linkov.net> <874jqgzjoe.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27211"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) Cc: 62250@debbugs.gnu.org To: Augusto Stoffel Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Mar 20 19:37:16 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1peKNg-0006rb-UP for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 20 Mar 2023 19:37:16 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1peKNY-0000xA-VW; Mon, 20 Mar 2023 14:37:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1peKNT-0000u0-AH for bug-gnu-emacs@gnu.org; Mon, 20 Mar 2023 14:37:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1peKNT-0002ZX-2B for bug-gnu-emacs@gnu.org; Mon, 20 Mar 2023 14:37:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1peKNS-0001rp-UM for bug-gnu-emacs@gnu.org; Mon, 20 Mar 2023 14:37:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 20 Mar 2023 18:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62250 X-GNU-PR-Package: emacs Original-Received: via spool by 62250-submit@debbugs.gnu.org id=B62250.16793374067147 (code B ref 62250); Mon, 20 Mar 2023 18:37:02 +0000 Original-Received: (at 62250) by debbugs.gnu.org; 20 Mar 2023 18:36:46 +0000 Original-Received: from localhost ([127.0.0.1]:56797 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1peKNC-0001rC-G5 for submit@debbugs.gnu.org; Mon, 20 Mar 2023 14:36:46 -0400 Original-Received: from relay6-d.mail.gandi.net ([217.70.183.198]:47993) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1peKN7-0001qk-J7 for 62250@debbugs.gnu.org; Mon, 20 Mar 2023 14:36:41 -0400 Original-Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id CD351C0002; Mon, 20 Mar 2023 18:36:34 +0000 (UTC) In-Reply-To: <874jqgzjoe.fsf@gmail.com> (Augusto Stoffel's message of "Sun, 19 Mar 2023 19:21:21 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:258310 Archived-At: >> The patch below will allow using the text property like >> >> 'context-menu-functions '(image-context-menu) > > I didn't test the patch (I don't understand click events very well), but > does it find the context-menu-functions property of overlays as well? It should be able to find the property in overlays as well. > And would those override the context-menu-functions text property or get > merged? This needs confirming, but I guess overlays take priority over text properties. >> (run-hook-wrapped 'context-menu-functions >> (lambda (fun) >> (setq menu (funcall fun menu click)) >> - nil))) >> + nil)) >> + (dolist (fun funs) >> + (setq menu (funcall fun menu click)))) >> >> ;; Remove duplicate separators as well as ones at the beginning or >> ;; end of the menu. > > I believe this makes the menu entries coming from a text property appear > after the regular hook ones, while I would expect the opposite (stuff > specific to the point is more "urgent"). When text properties are processed later, they have a chance to decide where they add their menu items: at the top of the context menu, at the bottom, or anywhere in the middle.