all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Kangas <stefankangas@gmail.com>
Cc: luangruo@yahoo.com, emacs-devel@gnu.org, dev@rjt.dev
Subject: Re: emacs-29 1ef8b90ae06: Simplify imenu setup for {cmake, dockerfile}-ts-modes
Date: Sun, 28 Jan 2024 07:57:51 +0200	[thread overview]
Message-ID: <86a5oq6luo.fsf@gnu.org> (raw)
In-Reply-To: <CADwFkmm7oFrX-6uyrq-L5AS9OX0dEGyQRS6Uc5+yADkbk55h3Q@mail.gmail.com> (message from Stefan Kangas on Sat, 27 Jan 2024 14:40:02 -0800)

> From: Stefan Kangas <stefankangas@gmail.com>
> Date: Sat, 27 Jan 2024 14:40:02 -0800
> Cc: emacs-devel@gnu.org, dev@rjt.dev
> 
> Po Lu <luangruo@yahoo.com> writes:
> 
> > Yes, please.  Furthermore, if such bugfix cannot be described as
> > anything but a simplification (with a correspondingly large diff), there
> > should be another approach safer for the release branch.
> 
> We must not get overly rigid about that.  It takes extra work, and it
> will not always be clear that it's worth the effort.  Often it is, but
> sometimes it isn't.  We tend to decide on a case-by-case basis.
> 
> Furthermore, please keep in mind that Yuan is both the principal author
> and maintainer of our treesitter support.  He's closer to the code than
> anyone else, and is thus in the best position to make such judgement
> calls.  I see no reason to second-guess him here, myself.
> 
> If there are any specific technical arguments for why this particular
> change must not be installed on emacs-29, then let's hear them.  Neither
> generalizations nor administrative arguments will cut it, I think.

My arguments for not objecting to this change on the release branch:

 . the change only affects these two modes
 . the modes are new in Emacs 29, so their fixes should preferably be
   in Emacs 29 as well



  parent reply	other threads:[~2024-01-28  5:57 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <170633049046.30614.86278647904102476@vcs2.savannah.gnu.org>
     [not found] ` <20240127044130.C6F37C4068B@vcs2.savannah.gnu.org>
2024-01-27  4:59   ` emacs-29 1ef8b90ae06: Simplify imenu setup for {cmake, dockerfile}-ts-modes Po Lu
2024-01-27  7:35     ` Eli Zaretskii
2024-01-27  8:05       ` Po Lu
2024-01-27 22:40         ` Stefan Kangas
2024-01-28  1:34           ` Po Lu
2024-01-28  3:00             ` Stefan Kangas
2024-01-28  5:21               ` Po Lu
2024-01-28  3:29           ` Dmitry Gutov
2024-01-28  5:57           ` Eli Zaretskii [this message]
2024-01-31  6:44             ` Yuan Fu
2024-01-27  8:37   ` Po Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86a5oq6luo.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=dev@rjt.dev \
    --cc=emacs-devel@gnu.org \
    --cc=luangruo@yahoo.com \
    --cc=stefankangas@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.