From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: emacs-29 1ef8b90ae06: Simplify imenu setup for {cmake, dockerfile}-ts-modes Date: Sun, 28 Jan 2024 07:57:51 +0200 Message-ID: <86a5oq6luo.fsf@gnu.org> References: <170633049046.30614.86278647904102476@vcs2.savannah.gnu.org> <20240127044130.C6F37C4068B@vcs2.savannah.gnu.org> <868r4b9qjs.fsf@gnu.org> <875xzfkxq7.fsf@yahoo.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27358"; mail-complaints-to="usenet@ciao.gmane.io" Cc: luangruo@yahoo.com, emacs-devel@gnu.org, dev@rjt.dev To: Stefan Kangas Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Jan 28 06:58:49 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rTyBt-0006vz-5w for ged-emacs-devel@m.gmane-mx.org; Sun, 28 Jan 2024 06:58:49 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rTyB1-0006CA-1X; Sun, 28 Jan 2024 00:57:55 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rTyAz-0006Bw-JQ for emacs-devel@gnu.org; Sun, 28 Jan 2024 00:57:53 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rTyAz-00081l-7S; Sun, 28 Jan 2024 00:57:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=1AzvpvQV4vFQ+oVyqXdd/0BCbciXrf4tao9pFdZGsLA=; b=LOOCcZi3CFac YqoUxV6qpsH3EqEX2kiP+EZTrtD5SNTD5Z9CNgg/pEEzWH+x0/9rZFyeWlsubuahexPZjl10d5WoY Z3ae0sCtDD5rJHArT1JXHv8tLVD5KF3Qf2Lcn3hB9UpvOarlJWD1f/2E1DCpI1EGv53PgUxiT1p5i eheEgR+oqlGYpAR4ArKxbo1TJUz32YrOnHDdvFAgkmJZqTH/OOaSDR6U0qYug19ZWjVqfeN+rtN7Y 6zUPcL8jpRVGQcgC5qqMnfSmVUVZGS/yJh58kGAsHt69so+fI0L71Wl+BgDd2DtGEACRkFk6qm61U 7I8xkzYMQvhJYFqGZxemjg==; In-Reply-To: (message from Stefan Kangas on Sat, 27 Jan 2024 14:40:02 -0800) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:315526 Archived-At: > From: Stefan Kangas > Date: Sat, 27 Jan 2024 14:40:02 -0800 > Cc: emacs-devel@gnu.org, dev@rjt.dev > > Po Lu writes: > > > Yes, please. Furthermore, if such bugfix cannot be described as > > anything but a simplification (with a correspondingly large diff), there > > should be another approach safer for the release branch. > > We must not get overly rigid about that. It takes extra work, and it > will not always be clear that it's worth the effort. Often it is, but > sometimes it isn't. We tend to decide on a case-by-case basis. > > Furthermore, please keep in mind that Yuan is both the principal author > and maintainer of our treesitter support. He's closer to the code than > anyone else, and is thus in the best position to make such judgement > calls. I see no reason to second-guess him here, myself. > > If there are any specific technical arguments for why this particular > change must not be installed on emacs-29, then let's hear them. Neither > generalizations nor administrative arguments will cut it, I think. My arguments for not objecting to this change on the release branch: . the change only affects these two modes . the modes are new in Emacs 29, so their fixes should preferably be in Emacs 29 as well