all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Collin Funk <collinfunk38@gmail.com>, Paul Eggert <eggert@cs.ucla.edu>
Cc: 68996@debbugs.gnu.org
Subject: bug#68996: [PATCH] Respect warnings added in GNU Make 4.4.90
Date: Fri, 09 Feb 2024 08:25:26 +0200	[thread overview]
Message-ID: <868r3uw3vt.fsf@gnu.org> (raw)
In-Reply-To: <87cyt6nxzh.fsf@gmail.com> (message from Collin Funk on Thu, 08 Feb 2024 19:00:02 -0800)

> From: Collin Funk <collinfunk38@gmail.com>
> Date: Thu, 08 Feb 2024 19:00:02 -0800
> 
> When building Emacs with recent versions of GNU Make every object file
> built will result in a warning like so:
> 
> ../src/verbose.mk:58: warning: invalid variable reference ' '
>   CC       emacs-module.o

Why did Make have to break Makefiles that depend on this "feature"?

> This doesn't prevent Emacs from building but makes it slightly harder
> to see any build output. I attached a patch that should work for all
> versions of GNU Make, both before and after the change. However it
> also causes the indentation to disappear in-front of CC and ELC which
> looks a bit strange. It doesn't seem like there is a valid way to do
> this at the moment. More discussion about this change can be seen
> here: https://savannah.gnu.org/bugs/?65273
> 
> Feel free to change my patch if you see a better way to solve these
> warnings.

My vote is for GNU Make to support this feature, since there's no good
way of having it otherwise (given what Paul Smith says in that
discussion).  Adding Paul Eggert in case he has ideas.  Paul, how do
other project produce the same indented "CC foo.o"? do they also use
this trick? or something else?

> Also, I have never committed to Emacs. This change feels trivial but
> results in 34 lines changed. Therefore I was unsure if this patch
> could be Copyright-paperwork-exempt tagged. Feel free to email me off
> list if I must fill them out. Thanks

Let's see if we want to install this.  I'm not sure.





  reply	other threads:[~2024-02-09  6:25 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-09  3:00 bug#68996: [PATCH] Respect warnings added in GNU Make 4.4.90 Collin Funk
2024-02-09  6:25 ` Eli Zaretskii [this message]
2024-02-09  7:27   ` Paul Eggert
2024-02-09 11:43     ` Eli Zaretskii
2024-02-09 12:18       ` Collin Funk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=868r3uw3vt.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=68996@debbugs.gnu.org \
    --cc=collinfunk38@gmail.com \
    --cc=eggert@cs.ucla.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.