From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#68996: [PATCH] Respect warnings added in GNU Make 4.4.90 Date: Fri, 09 Feb 2024 08:25:26 +0200 Message-ID: <868r3uw3vt.fsf@gnu.org> References: <87cyt6nxzh.fsf@gmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40194"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 68996@debbugs.gnu.org To: Collin Funk , Paul Eggert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Feb 09 07:26:13 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rYKKx-000ACb-7f for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 09 Feb 2024 07:26:11 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rYKKb-0000wo-Q7; Fri, 09 Feb 2024 01:25:49 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rYKKa-0000uq-5Q for bug-gnu-emacs@gnu.org; Fri, 09 Feb 2024 01:25:48 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rYKKZ-0007RY-Tp for bug-gnu-emacs@gnu.org; Fri, 09 Feb 2024 01:25:47 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rYKKo-0004qZ-8P for bug-gnu-emacs@gnu.org; Fri, 09 Feb 2024 01:26:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 09 Feb 2024 06:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68996 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 68996-submit@debbugs.gnu.org id=B68996.170745995318608 (code B ref 68996); Fri, 09 Feb 2024 06:26:02 +0000 Original-Received: (at 68996) by debbugs.gnu.org; 9 Feb 2024 06:25:53 +0000 Original-Received: from localhost ([127.0.0.1]:38100 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rYKKf-0004q3-8Y for submit@debbugs.gnu.org; Fri, 09 Feb 2024 01:25:53 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48100) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rYKKd-0004pi-6n for 68996@debbugs.gnu.org; Fri, 09 Feb 2024 01:25:51 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rYKKI-0007Pz-5T; Fri, 09 Feb 2024 01:25:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=KVQcBa4+fHmi2xAWxTrt+Zf/kVtOSmKWXRBuOqUfouc=; b=B0alwBuRxXr/ I9/mXyAbESv9vjRrzRaf0wBPa8+nQIO5GUWZSWaOmnVLrhCPsp8hkAVCMScla4Q77lcivEr1bkpMA fktEXOeGVUR7ejd/Pp7adf2yYmxoXmga9BtgahN+1OqKB6mQmwsy6KeqKmOBBe0ElMUwAGXvrnMy5 PEHmuIg9kLZuTjPzRecvHU0o6isbuH5aPqKJvw4aKVakPz5y70t89y2zrkpzo+Ii7Gzcl2vu86EF1 yQbzk01doKnSkspF8yRozVV+pXZHlp+uvNz3aZaK89fgvM1WmSTVF8FuMcJ+IODi5opDyz+DQBRKp g0BBIzDFVndIHQsXfN9SWw==; In-Reply-To: <87cyt6nxzh.fsf@gmail.com> (message from Collin Funk on Thu, 08 Feb 2024 19:00:02 -0800) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:279677 Archived-At: > From: Collin Funk > Date: Thu, 08 Feb 2024 19:00:02 -0800 > > When building Emacs with recent versions of GNU Make every object file > built will result in a warning like so: > > ../src/verbose.mk:58: warning: invalid variable reference ' ' > CC emacs-module.o Why did Make have to break Makefiles that depend on this "feature"? > This doesn't prevent Emacs from building but makes it slightly harder > to see any build output. I attached a patch that should work for all > versions of GNU Make, both before and after the change. However it > also causes the indentation to disappear in-front of CC and ELC which > looks a bit strange. It doesn't seem like there is a valid way to do > this at the moment. More discussion about this change can be seen > here: https://savannah.gnu.org/bugs/?65273 > > Feel free to change my patch if you see a better way to solve these > warnings. My vote is for GNU Make to support this feature, since there's no good way of having it otherwise (given what Paul Smith says in that discussion). Adding Paul Eggert in case he has ideas. Paul, how do other project produce the same indented "CC foo.o"? do they also use this trick? or something else? > Also, I have never committed to Emacs. This change feels trivial but > results in 34 lines changed. Therefore I was unsure if this patch > could be Copyright-paperwork-exempt tagged. Feel free to email me off > list if I must fill them out. Thanks Let's see if we want to install this. I'm not sure.