all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@linkov.net>
To: Gabriel <gabriel376@hotmail.com>
Cc: 59438@debbugs.gnu.org
Subject: bug#59438: 29.0.50; [PATCH] Make defvar's into defcustom's in tab-line
Date: Sun, 05 May 2024 21:38:44 +0300	[thread overview]
Message-ID: <868r0ohznv.fsf@mail.linkov.net> (raw)
In-Reply-To: <SJ0PR06MB860970919EE7F0B0A8E645708B0A9@SJ0PR06MB8609.namprd06.prod.outlook.com> (Gabriel's message of "Mon, 21 Nov 2022 06:25:17 -0300")

close 59438 30.0.50
thanks

> Description:
>
> Please find attached a patch that proposes the following minor changes
> to tab-line.  I can refactor the patch if we decide that some change are
> not worth or if it's better to split it into smaller patches.
>
> 1) Turn the following defvar's into defcustom's:
>
> - `tab-line-tabs-buffer-group-function'
> - `tab-line-tabs-buffer-group-sort-function'
> - `tab-line-tabs-buffer-groups-sort-function'
>
> 2) Add conditional around function call of
> `tab-line-tabs-buffer-groups-sort-function', in
> `tab-line-tabs-buffer-groups'.  This guards against nil values, similar
> to how `tab-line-tabs-buffer-group-sort-function is handled, making the
> behavior more consistent across these two (similar) variables.

I'm very sorry this took so long since I wanted first to do some related changes.
But your patch will get into the next release anyway.  Thanks for the patch.

So now everything is pushed together with the suggestion by Mauro
to add choice type with nil.





      parent reply	other threads:[~2024-05-05 18:38 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-21  9:25 bug#59438: 29.0.50; [PATCH] Make defvar's into defcustom's in tab-line Gabriel
2022-11-25  1:15 ` Stefan Kangas
2023-09-07 21:07   ` Stefan Kangas
2023-09-08 10:43     ` Mauro Aranda
2024-05-05 18:38 ` Juri Linkov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=868r0ohznv.fsf@mail.linkov.net \
    --to=juri@linkov.net \
    --cc=59438@debbugs.gnu.org \
    --cc=gabriel376@hotmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.