From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#59438: 29.0.50; [PATCH] Make defvar's into defcustom's in tab-line Date: Sun, 05 May 2024 21:38:44 +0300 Organization: LINKOV.NET Message-ID: <868r0ohznv.fsf@mail.linkov.net> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22189"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) Cc: 59438@debbugs.gnu.org To: Gabriel Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun May 05 20:42:11 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1s3goM-0005eR-MH for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 05 May 2024 20:42:10 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s3gns-0006aP-M1; Sun, 05 May 2024 14:41:40 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s3gnr-0006Zs-9j for bug-gnu-emacs@gnu.org; Sun, 05 May 2024 14:41:39 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s3gnr-0000AD-10 for bug-gnu-emacs@gnu.org; Sun, 05 May 2024 14:41:39 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1s3goE-0002sz-Fh for bug-gnu-emacs@gnu.org; Sun, 05 May 2024 14:42:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 05 May 2024 18:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59438 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 59438-submit@debbugs.gnu.org id=B59438.171493449511071 (code B ref 59438); Sun, 05 May 2024 18:42:02 +0000 Original-Received: (at 59438) by debbugs.gnu.org; 5 May 2024 18:41:35 +0000 Original-Received: from localhost ([127.0.0.1]:32979 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s3gnm-0002sU-Ug for submit@debbugs.gnu.org; Sun, 05 May 2024 14:41:35 -0400 Original-Received: from relay9-d.mail.gandi.net ([217.70.183.199]:60815) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s3gni-0002sJ-9A; Sun, 05 May 2024 14:41:33 -0400 Original-Received: by mail.gandi.net (Postfix) with ESMTPSA id EE4D9FF802; Sun, 5 May 2024 18:40:58 +0000 (UTC) In-Reply-To: (Gabriel's message of "Mon, 21 Nov 2022 06:25:17 -0300") X-GND-Sasl: juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:284538 Archived-At: close 59438 30.0.50 thanks > Description: > > Please find attached a patch that proposes the following minor changes > to tab-line. I can refactor the patch if we decide that some change are > not worth or if it's better to split it into smaller patches. > > 1) Turn the following defvar's into defcustom's: > > - `tab-line-tabs-buffer-group-function' > - `tab-line-tabs-buffer-group-sort-function' > - `tab-line-tabs-buffer-groups-sort-function' > > 2) Add conditional around function call of > `tab-line-tabs-buffer-groups-sort-function', in > `tab-line-tabs-buffer-groups'. This guards against nil values, similar > to how `tab-line-tabs-buffer-group-sort-function is handled, making the > behavior more consistent across these two (similar) variables. I'm very sorry this took so long since I wanted first to do some related changes. But your patch will get into the next release anyway. Thanks for the patch. So now everything is pushed together with the suggestion by Mauro to add choice type with nil.