Need message-fn arg back in ert-run-tests-interactively

Need message-fn arg back in ert-run-tests-interactively

[Robert Weiner]

[-- Attachment #1: Type: text/plain, Size: 1039 bytes --]

In ert.el of Emacs 27.1, we have a simple ability to override the 'message'
function when running ert tests interactively by setting the message-fn
argument here:

;; Should OUTPUT-BUFFER-NAME and MESSAGE-FN really be arguments here?
;; They are needed only for our automated self-tests at the moment.
;; Or should there be some other mechanism?
;;;###autoload
(defun ert-run-tests-interactively (selector
                                    &optional output-buffer-name message-fn)

But in recent Emacs versions this function takes only the selector
argument, with no clear way of how to override messaging behavior so that a
message from a test case (rather than ert itself) can remain in the
minibuffer after a test case finishes:

(defun ert-run-tests-interactively (selector)
  "Run the tests specified by SELECTOR and display the results in a buffer.

SELECTOR works as described in `ert-select-tests'."

This would be very useful behavior to have back.  Is there any simple way
to do it now or can you add it back in?

Thanks,

Bob

[-- Attachment #2: Type: text/html, Size: 2177 bytes --]

Re: Need message-fn arg back in ert-run-tests-interactively

[Robert Weiner]

[-- Attachment #1: Type: text/plain, Size: 1358 bytes --]

Hi Guys:

Anyone have any thoughts on this?  Eli or Stefan?  Would be useful in some
updates we'd like to make to the Hyperbole package.

Regards,

Bob


On Sun, Jul 9, 2023 at 11:49 AM Robert Weiner <rsw@gnu.org> wrote:

> In ert.el of Emacs 27.1, we have a simple ability to override the
> 'message' function when running ert tests interactively by setting the
> message-fn argument here:
>
> ;; Should OUTPUT-BUFFER-NAME and MESSAGE-FN really be arguments here?
> ;; They are needed only for our automated self-tests at the moment.
> ;; Or should there be some other mechanism?
> ;;;###autoload
> (defun ert-run-tests-interactively (selector
>                                     &optional output-buffer-name
> message-fn)
>
> But in recent Emacs versions this function takes only the selector
> argument, with no clear way of how to override messaging behavior so that a
> message from a test case (rather than ert itself) can remain in the
> minibuffer after a test case finishes:
>
> (defun ert-run-tests-interactively (selector)
>   "Run the tests specified by SELECTOR and display the results in a buffer.
>
> SELECTOR works as described in `ert-select-tests'."
>
> This would be very useful behavior to have back.  Is there any simple way
> to do it now or can you add it back in?
>
> Thanks,
>
> Bob
>
>

[-- Attachment #2: Type: text/html, Size: 2984 bytes --]

Re: Need message-fn arg back in ert-run-tests-interactively

[Stefan Kangas]

Robert Weiner <rsw@gnu.org> writes:

> In ert.el of Emacs 27.1, we have a simple ability to override the 'message'
> function when running ert tests interactively by setting the message-fn
> argument here:
>
> ;; Should OUTPUT-BUFFER-NAME and MESSAGE-FN really be arguments here?
> ;; They are needed only for our automated self-tests at the moment.
> ;; Or should there be some other mechanism?
> ;;;###autoload
> (defun ert-run-tests-interactively (selector
>                                     &optional output-buffer-name message-fn)
>
> But in recent Emacs versions this function takes only the selector
> argument, with no clear way of how to override messaging behavior so that a
> message from a test case (rather than ert itself) can remain in the
> minibuffer after a test case finishes:
>
> (defun ert-run-tests-interactively (selector)
>   "Run the tests specified by SELECTOR and display the results in a buffer.
>
> SELECTOR works as described in `ert-select-tests'."
>
> This would be very useful behavior to have back.  Is there any simple way
> to do it now or can you add it back in?

You can use something like this:

    (cl-letf (((symbol-function 'message)
               (lambda (format-string &rest args)
                 ...)))
      (ert-run-tests-interactively t))

This should work on both new and old versions of Emacs.

Re: Need message-fn arg back in ert-run-tests-interactively

[Richard Stallman]

[[[ To any NSA and FBI agents reading my email: please consider    ]]]
[[[ whether defending the US Constitution against all enemies,     ]]]
[[[ foreign or domestic, requires you to follow Snowden's example. ]]]

  > You can use something like this:

  >     (cl-letf (((symbol-function 'message)
  >                (lambda (format-string &rest args)
  >                  ...)))
  >       (ert-run-tests-interactively t))

It might work, but dynamically binding the function cell of a standard
Emacs Lisp function is very unclean.  Can wecome up with a cleaner way
to do this job?
 
-- 
Dr Richard Stallman (https://stallman.org)
Chief GNUisance of the GNU Project (https://gnu.org)
Founder, Free Software Foundation (https://fsf.org)
Internet Hall-of-Famer (https://internethalloffame.org)

Re: Need message-fn arg back in ert-run-tests-interactively

[Juri Linkov]

>>     (cl-letf (((symbol-function 'message)
>>                (lambda (format-string &rest args)
>>                  ...)))
>>       (ert-run-tests-interactively t))
>
> It might work, but dynamically binding the function cell of a standard
> Emacs Lisp function is very unclean.  Can wecome up with a cleaner way
> to do this job?

There is set-message-function added in Emacs 27.