bug#70384: [PATCH] 30.0.50; save-mark-and-excursion breaks with tmm disabled

bug#70384: [PATCH] 30.0.50; save-mark-and-excursion breaks with tmm disabled

[Paul Nelson]

[-- Attachment #1: Type: text/plain, Size: 278 bytes --]

Hello,

Steps to reproduce:

- Disable transient-mark-mode.
- Set the mark somewhere (C-SPC), move the point somewhere else.
- M-: (save-mark-and-excursion (activate-mark))

This activates the region, but should not.

Attaching a patch with the simple fix.

Thanks, best,

Paul

[-- Attachment #2: 0001-Fix-save-mark-and-excursion-with-tmm-disabled.patch --]
[-- Type: application/octet-stream, Size: 830 bytes --]

From 06b6f0a70eb7f59fe9a2a0d82697f509290993f0 Mon Sep 17 00:00:00 2001
From: Paul Nelson <ultrono@gmail.com>
Date: Sun, 14 Apr 2024 17:49:45 +0200
Subject: [PATCH] Fix save-mark-and-excursion with tmm disabled

* lisp/simple.el (save-mark-and-excursion--save):
Use (region-active-p) instead of mark-active.
---
 lisp/simple.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/simple.el b/lisp/simple.el
index 0645f18cc78..249fadae6a9 100644
--- a/lisp/simple.el
+++ b/lisp/simple.el
@@ -6981,7 +6981,7 @@ save-mark-and-excursion--save
   (cons
    (let ((mark (mark-marker)))
      (and (marker-position mark) (copy-marker mark)))
-   mark-active))
+   (region-active-p)))
 
 (defun save-mark-and-excursion--restore (saved-mark-info)
   (let ((saved-mark (car saved-mark-info))
-- 
2.39.3 (Apple Git-145)

bug#70384: [PATCH] 30.0.50; save-mark-and-excursion breaks with tmm disabled

[Eli Zaretskii]

> From: Paul Nelson <ultrono@gmail.com>
> Date: Sun, 14 Apr 2024 17:52:42 +0200
> 
> Steps to reproduce:
> 
> - Disable transient-mark-mode.
> - Set the mark somewhere (C-SPC), move the point somewhere else.
> - M-: (save-mark-and-excursion (activate-mark))
> 
> This activates the region, but should not.

I'm not sure I agree with your expectations.  activate-mark activates
the mark unconditionally when transient-mark-mode is disabled, unless
you invoke it with a non-nil argument.  And indeed

   (save-mark-and-excursion (activate-mark t))

behaves like you expect.

Stefan, am I missing something?

bug#70384: [PATCH] 30.0.50; save-mark-and-excursion breaks with tmm disabled

[Paul Nelson]

My mistake, I think.  Thanks for looking into this.

bug#70384: [PATCH] 30.0.50; save-mark-and-excursion breaks with tmm disabled

[Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors]

> I'm not sure I agree with your expectations.  activate-mark activates
> the mark unconditionally when transient-mark-mode is disabled, unless
> you invoke it with a non-nil argument.  And indeed
>
>    (save-mark-and-excursion (activate-mark t))
>
> behaves like you expect.
>
> Stefan, am I missing something?

It's all very messy with dark corners where the right answer is unclear,
yes.  That's one of the reasons why I extracted that mark-handling
functionality out of `save-excursion` in the first place. 🙂

IOW my opinion is: if you use `save-mark-and-excursion`, you get what
you deserve.


        Stefan

bug#70384: [PATCH] 30.0.50; save-mark-and-excursion breaks with tmm disabled

[Eli Zaretskii]

tags 70384 notabug wontfix
close 70384
thanks

> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Cc: Paul Nelson <ultrono@gmail.com>,  70384@debbugs.gnu.org
> Date: Thu, 18 Apr 2024 09:55:56 -0400
> 
> > I'm not sure I agree with your expectations.  activate-mark activates
> > the mark unconditionally when transient-mark-mode is disabled, unless
> > you invoke it with a non-nil argument.  And indeed
> >
> >    (save-mark-and-excursion (activate-mark t))
> >
> > behaves like you expect.
> >
> > Stefan, am I missing something?
> 
> It's all very messy with dark corners where the right answer is unclear,
> yes.  That's one of the reasons why I extracted that mark-handling
> functionality out of `save-excursion` in the first place. 🙂
> 
> IOW my opinion is: if you use `save-mark-and-excursion`, you get what
> you deserve.

OK, thanks.  So I'm closing this non-bug as wontfix.