From: Juri Linkov <juri@linkov.net>
To: Gregory Heytings <gregory@heytings.org>
Cc: 60359@debbugs.gnu.org, Philip Kaludercic <philipk@posteo.net>
Subject: bug#60359: 29.0.60; completion-auto-select set to t skips first argument when completing files
Date: Thu, 29 Dec 2022 20:48:35 +0200 [thread overview]
Message-ID: <864jtedp18.fsf@mail.linkov.net> (raw)
In-Reply-To: <86ce0848031a81ca4ddb@heytings.org> (Gregory Heytings's message of "Thu, 29 Dec 2022 18:37:54 +0000")
>> Please omit the message only in case when the completions buffer is
>> shown, then the user will see there are more completions. But after
>> typing e.g. `M-x man TAB` that otherwise does nothing the user should see
>> the message. IOW, in case of `completion-auto-help` please use the same
>> condition `(and (eq this-command last-command) completion-auto-help)` as
>> used to pop up the completions.
>
> You mean this, right?
>
> diff --git a/lisp/minibuffer.el b/lisp/minibuffer.el
> index 6e42296e7ba..7a720cf2c0a 100644
> --- a/lisp/minibuffer.el
> +++ b/lisp/minibuffer.el
> @@ -1474,7 +1474,10 @@ completion--do-completion
> (if (and (eq this-command last-command)
> completion-auto-help)
> (minibuffer-completion-help beg end))
> (completion--done completion 'exact
> - (unless expect-exact
> + (unless (or expect-exact
> + (and completion-auto-select
> + (eq this-command last-command)
> + completion-auto-help))
> "Complete, but not unique"))))
>
> (minibuffer--bitset completed t exact))))))))
Yep, this looks like the right thing to do.
next prev parent reply other threads:[~2022-12-29 18:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-27 17:10 bug#60359: 29.0.60; completion-auto-select set to t skips first argument when completing files Philip Kaludercic
2022-12-27 23:48 ` Gregory Heytings
2022-12-29 16:25 ` Philip Kaludercic
2022-12-29 17:36 ` Gregory Heytings
2022-12-29 17:46 ` Eli Zaretskii
2022-12-29 18:18 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-12-29 18:06 ` Juri Linkov
2022-12-29 18:37 ` Gregory Heytings
2022-12-29 18:48 ` Juri Linkov [this message]
2022-12-29 21:54 ` Gregory Heytings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=864jtedp18.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=60359@debbugs.gnu.org \
--cc=gregory@heytings.org \
--cc=philipk@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.