From: Gregory Heytings <gregory@heytings.org>
To: Philip Kaludercic <philipk@posteo.net>
Cc: 60359@debbugs.gnu.org
Subject: bug#60359: 29.0.60; completion-auto-select set to t skips first argument when completing files
Date: Tue, 27 Dec 2022 23:48:49 +0000 [thread overview]
Message-ID: <314db4a90e78b4a7714d@heytings.org> (raw)
In-Reply-To: <87sfh0ydpf.fsf@posteo.net>
[-- Attachment #1: Type: text/plain, Size: 1127 bytes --]
>
> If the user option 'completion-auto-select' is set to t, then pressing
> tab should pop up the completions buffer and select the first option.
> This works well, unless a file name is being completed. In that case,
> tab doesn't jump to completion buffer. In fact it appears not to even
> open it by default. A second press opens the buffer, but only jumps if
> you don't do anything else for about half a second. A third press of
> the tab key jumps to the second option. So if you press tab three
> times, without waiting, you always skip the first completion suggestion.
>
> The issue can be reproduced with emacs -Q, by evaluating (setq
> completion-auto-select t) and then opening a file using C-x C-f, in
> presumably any directory.
>
Thanks for your bug report. If I set completion-auto-select in emacs -Q,
C-x C-f C TAB (or TAB TAB, depending on the value of
completion-auto-select) in the Emacs repository behaves as expected.
However, C-x C-f src/ TAB does not. Is the latter case what you have in
mind, or do I misunderstand what you mean? If not, the attached patch
should fix that bug.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Fix-completion-when-completion-auto-select-is-set.patch --]
[-- Type: text/x-diff; name=Fix-completion-when-completion-auto-select-is-set.patch, Size: 1182 bytes --]
From c5430c403b05008cd67f8786571a2fd63402231f Mon Sep 17 00:00:00 2001
From: Gregory Heytings <gregory@heytings.org>
Date: Tue, 27 Dec 2022 23:40:25 +0000
Subject: [PATCH] Fix completion when completion-auto-select is set
* lisp/minibuffer.el (completion--do-completion): Do not display
"Complete, but not unique" messages when completion-auto-select is
set. Fixes bug#60359.
---
lisp/minibuffer.el | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/lisp/minibuffer.el b/lisp/minibuffer.el
index 6e42296e7ba..5077e6c7e96 100644
--- a/lisp/minibuffer.el
+++ b/lisp/minibuffer.el
@@ -1474,7 +1474,8 @@ completion--do-completion
(if (and (eq this-command last-command) completion-auto-help)
(minibuffer-completion-help beg end))
(completion--done completion 'exact
- (unless expect-exact
+ (unless (or expect-exact
+ completion-auto-select)
"Complete, but not unique"))))
(minibuffer--bitset completed t exact))))))))
--
2.35.1
next prev parent reply other threads:[~2022-12-27 23:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-27 17:10 bug#60359: 29.0.60; completion-auto-select set to t skips first argument when completing files Philip Kaludercic
2022-12-27 23:48 ` Gregory Heytings [this message]
2022-12-29 16:25 ` Philip Kaludercic
2022-12-29 17:36 ` Gregory Heytings
2022-12-29 17:46 ` Eli Zaretskii
2022-12-29 18:18 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-12-29 18:06 ` Juri Linkov
2022-12-29 18:37 ` Gregory Heytings
2022-12-29 18:48 ` Juri Linkov
2022-12-29 21:54 ` Gregory Heytings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=314db4a90e78b4a7714d@heytings.org \
--to=gregory@heytings.org \
--cc=60359@debbugs.gnu.org \
--cc=philipk@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.