all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Gustaf Waldemarson <gustaf.waldemarson@gmail.com>
Cc: 59730-done@debbugs.gnu.org
Subject: bug#59730: gdb-mi.el: Local variables reordering
Date: Sat, 10 Dec 2022 15:29:14 +0200	[thread overview]
Message-ID: <83zgbvwfo5.fsf@gnu.org> (raw)
In-Reply-To: <CABehr5e=XKOGMwWfZJD2ZkGWufK7iP-iKr0G428RHjZpOaUudQ@mail.gmail.com> (message from Gustaf Waldemarson on Thu, 8 Dec 2022 19:43:46 +0100)

> From: Gustaf Waldemarson <gustaf.waldemarson@gmail.com>
> Date: Thu, 8 Dec 2022 19:43:46 +0100
> Cc: 59730@debbugs.gnu.org
> 
> > I don't like making backwards-incompatible changes such as removing a
> > user option.  How about if the default value of
> > gdb-locals-table-row-config used the value of gdb-locals-value-limit
> > instead of a literal 100?
> 
> Done
> 
> >  "frame or window", right?
> 
> I had to do a double take on this to make sure I was using the right terminology,
> at least according to the Emacs GDB documentation
> (https://www.gnu.org/software/emacs/manual/html_node/emacs/GDB-User-Interface-Layout.html)
> it seems like it should be the "local variables buffer", so I changed the news entry
> to match that, hope that's alright.
> 
> >  Our conventions are to use two spaces between sentences.
> 
> Should be fixed now as well
> 
> > That value is incorrect, because the value was truncated at 100, due
> > to gdb-locals-value-limit, right?
> 
> Indeed, that was my bad and should be fixed now
> 
> >  I hope we won't need this paragraph.
> 
> Indeed, it is removed as requested
> 
> That should be everything I think, if there's anything else, please just say so,
> and thanks again for the feedback!

Thanks, I installed the changes on the master branch.

In the future please accompany the changes with a ChangeLog-style
description of actual changes in the changeset; see CONTRIBUTE for the
details and "git log" for examples.





      reply	other threads:[~2022-12-10 13:29 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-30 22:09 bug#59730: gdb-mi.el: Local variables reordering Gustaf Waldemarson
2022-12-01 15:44 ` Eli Zaretskii
2022-12-01 20:40   ` Gustaf Waldemarson
2022-12-01 21:53     ` Gustaf Waldemarson
2022-12-02 13:48       ` Eli Zaretskii
2022-12-03 13:02         ` Gustaf Waldemarson
2022-12-03 19:58       ` Eli Zaretskii
2022-12-04 14:26         ` Gustaf Waldemarson
2022-12-07 17:50           ` Eli Zaretskii
2022-12-08 18:43             ` Gustaf Waldemarson
2022-12-10 13:29               ` Eli Zaretskii [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83zgbvwfo5.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=59730-done@debbugs.gnu.org \
    --cc=gustaf.waldemarson@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.