From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#59730: gdb-mi.el: Local variables reordering Date: Sat, 10 Dec 2022 15:29:14 +0200 Message-ID: <83zgbvwfo5.fsf@gnu.org> References: <83y1rrgmc3.fsf@gnu.org> <83fsdwcl8u.fsf@gnu.org> <83bkof3xxn.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3924"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 59730-done@debbugs.gnu.org To: Gustaf Waldemarson Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Dec 10 14:30:55 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p3zwM-0000tV-V6 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 10 Dec 2022 14:30:55 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p3zvu-0003hd-R7; Sat, 10 Dec 2022 08:30:27 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p3zva-0003gG-O9 for bug-gnu-emacs@gnu.org; Sat, 10 Dec 2022 08:30:09 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p3zvX-00021i-Ly for bug-gnu-emacs@gnu.org; Sat, 10 Dec 2022 08:30:06 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p3zvX-0004lT-4L for bug-gnu-emacs@gnu.org; Sat, 10 Dec 2022 08:30:03 -0500 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sat, 10 Dec 2022 13:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 59730 X-GNU-PR-Package: emacs Mail-Followup-To: 59730@debbugs.gnu.org, eliz@gnu.org, gustaf.waldemarson@gmail.com Original-Received: via spool by 59730-done@debbugs.gnu.org id=D59730.167067897018267 (code D ref 59730); Sat, 10 Dec 2022 13:30:02 +0000 Original-Received: (at 59730-done) by debbugs.gnu.org; 10 Dec 2022 13:29:30 +0000 Original-Received: from localhost ([127.0.0.1]:42766 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p3zv0-0004kZ-5J for submit@debbugs.gnu.org; Sat, 10 Dec 2022 08:29:30 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:49314) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p3zuv-0004kS-Dx for 59730-done@debbugs.gnu.org; Sat, 10 Dec 2022 08:29:28 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p3zup-0001py-Ot; Sat, 10 Dec 2022 08:29:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=4Vo9DF9KQMqb0YYgaNz2QMMcnZPS9X9voRzEDtnwGhU=; b=qUD26SjzCCfK Icvd70D5blmK91PFkyHYjugct5b2Wj2pCmu9+Jz9xWxgvf/PGi+J9Blmck9waUsqE2NtJ11tCWHcN 1j1fyX2Cu7Xwkdxp076NDJ0v3s0O390cgZkB/qUn4jV7lG3hIsrqEJU9TJRs8s0HBPf0YIeiZ9RVr wKkkh/jE74e+WmMwzk21vgssZIHxW7qlJaRJnaZlqoIC0w/TWt0BV3LCkf00Fjw5w7FfXwP/WG2Up kVqbrc5VMG9ATDW2nHH8Q/YP1Evefu4fgrMVT6g90lIcSJcYQjqC7KiLaTS/OEO5jK/Z0/67Y2TDD VlXH9Jdd04fGwgxHyhIcPA==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p3zup-0005Jr-3m; Sat, 10 Dec 2022 08:29:19 -0500 In-Reply-To: (message from Gustaf Waldemarson on Thu, 8 Dec 2022 19:43:46 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:250515 Archived-At: > From: Gustaf Waldemarson > Date: Thu, 8 Dec 2022 19:43:46 +0100 > Cc: 59730@debbugs.gnu.org > > > I don't like making backwards-incompatible changes such as removing a > > user option. How about if the default value of > > gdb-locals-table-row-config used the value of gdb-locals-value-limit > > instead of a literal 100? > > Done > > > "frame or window", right? > > I had to do a double take on this to make sure I was using the right terminology, > at least according to the Emacs GDB documentation > (https://www.gnu.org/software/emacs/manual/html_node/emacs/GDB-User-Interface-Layout.html) > it seems like it should be the "local variables buffer", so I changed the news entry > to match that, hope that's alright. > > > Our conventions are to use two spaces between sentences. > > Should be fixed now as well > > > That value is incorrect, because the value was truncated at 100, due > > to gdb-locals-value-limit, right? > > Indeed, that was my bad and should be fixed now > > > I hope we won't need this paragraph. > > Indeed, it is removed as requested > > That should be everything I think, if there's anything else, please just say so, > and thanks again for the feedback! Thanks, I installed the changes on the master branch. In the future please accompany the changes with a ChangeLog-style description of actual changes in the changeset; see CONTRIBUTE for the details and "git log" for examples.