From: Eli Zaretskii <eliz@gnu.org>
To: Arash Esbati <arash@gnu.org>, Tassilo Horn <tsdh@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: Patch for reftex.el: master or release branch?
Date: Wed, 14 Dec 2022 15:28:05 +0200 [thread overview]
Message-ID: <83wn6um7x6.fsf@gnu.org> (raw)
In-Reply-To: <867cyuktnw.fsf@gnu.org> (message from Arash Esbati on Wed, 14 Dec 2022 14:21:23 +0100)
> From: Arash Esbati <arash@gnu.org>
> Date: Wed, 14 Dec 2022 14:21:23 +0100
>
> Dear maintainers,
>
> I have the following patch for reftex.el fixing AUCTeX bug#59638. This
> issue was introduced with commit 1e8bb313ea:
>
> --8<---------------cut here---------------start------------->8---
> diff --git a/lisp/textmodes/reftex.el b/lisp/textmodes/reftex.el
> index f815419ea4..126b3777f5 100644
> --- a/lisp/textmodes/reftex.el
> +++ b/lisp/textmodes/reftex.el
> @@ -1004,10 +1004,13 @@ reftex-compile-variables
> reftex-section-levels))
>
> ;; Calculate the regular expressions
> - (let* (
> -; (wbol "\\(\\`\\|[\n\r]\\)[ \t]*")
> - (wbol "\\(^\\)%?[ \t]*") ; Need to keep the empty group because
> - ; match numbers are hard coded
> + (let* (;; (wbol "\\(\\`\\|[\n\r]\\)[ \t]*")
> + ;; Need to keep the empty group because match numbers are
> + ;; hard coded
> + (wbol (concat "\\(^\\)"
> + (when (string-suffix-p ".dtx" (buffer-file-name) t)
> + "%")
> + "[ \t]*"))
> (label-re (concat "\\(?:"
> (mapconcat #'identity reftex-label-regexps "\\|")
> "\\)"))
> --8<---------------cut here---------------end--------------->8---
>
> Can you please tell me if this should go to master or emacs-29 branch?
How safe is the change? If it is safe enough, emacs-29 is fine.
Tassilo, WDYT about the safety of the patch and/or about the urgency
to have the fix?
next prev parent reply other threads:[~2022-12-14 13:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-14 13:21 Patch for reftex.el: master or release branch? Arash Esbati
2022-12-14 13:28 ` Eli Zaretskii [this message]
2022-12-14 14:25 ` Tassilo Horn
2022-12-14 16:05 ` Eli Zaretskii
2022-12-14 20:37 ` Arash Esbati
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83wn6um7x6.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=arash@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=tsdh@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.