From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Patch for reftex.el: master or release branch? Date: Wed, 14 Dec 2022 15:28:05 +0200 Message-ID: <83wn6um7x6.fsf@gnu.org> References: <867cyuktnw.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38450"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Arash Esbati , Tassilo Horn Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Dec 14 14:28:39 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p5RoM-0009oF-Os for ged-emacs-devel@m.gmane-mx.org; Wed, 14 Dec 2022 14:28:38 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p5Ro4-0003uF-MF; Wed, 14 Dec 2022 08:28:20 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p5Ro3-0003tZ-5s for emacs-devel@gnu.org; Wed, 14 Dec 2022 08:28:19 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p5Ro2-0000U0-Kj for emacs-devel@gnu.org; Wed, 14 Dec 2022 08:28:18 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=QeYm1HW5YQAXbuqUQ2GK5eAO48WznnbUKK9o/qfGYnk=; b=MxVplE4Lav8n YzcVEaXIxqaBruRwYo+09xvHnI9yUjEdFGx+yiehc2w5zXMwswSpPUGtDKBa4Emm3cE/WQkbGP7Dm tIgjgxGlv4UlYh2O+YSMs30xC4tEcMgqGecrXa1jIJqOk3OxbJlTkG280kXTbFOhgIKGnumOochnH Uhm4g/IcjDcXfqfBwbCZd3Amm1mUHEjwvmn2OL9xj+fUnyi7DtHtrDnAoc4lg0CUKrblhqAdbLovs Td90hq9oEu5jMysQDT3CIv8ZiMxqkKg1zZQIt+eol0823g+l9MbwJLBB06QDSJlvJgRzPnEIhftnQ 9QveaMaskht0vUH/CN++eA==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p5Ro1-0007jq-Sh; Wed, 14 Dec 2022 08:28:18 -0500 In-Reply-To: <867cyuktnw.fsf@gnu.org> (message from Arash Esbati on Wed, 14 Dec 2022 14:21:23 +0100) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:301389 Archived-At: > From: Arash Esbati > Date: Wed, 14 Dec 2022 14:21:23 +0100 > > Dear maintainers, > > I have the following patch for reftex.el fixing AUCTeX bug#59638. This > issue was introduced with commit 1e8bb313ea: > > --8<---------------cut here---------------start------------->8--- > diff --git a/lisp/textmodes/reftex.el b/lisp/textmodes/reftex.el > index f815419ea4..126b3777f5 100644 > --- a/lisp/textmodes/reftex.el > +++ b/lisp/textmodes/reftex.el > @@ -1004,10 +1004,13 @@ reftex-compile-variables > reftex-section-levels)) > > ;; Calculate the regular expressions > - (let* ( > -; (wbol "\\(\\`\\|[\n\r]\\)[ \t]*") > - (wbol "\\(^\\)%?[ \t]*") ; Need to keep the empty group because > - ; match numbers are hard coded > + (let* (;; (wbol "\\(\\`\\|[\n\r]\\)[ \t]*") > + ;; Need to keep the empty group because match numbers are > + ;; hard coded > + (wbol (concat "\\(^\\)" > + (when (string-suffix-p ".dtx" (buffer-file-name) t) > + "%") > + "[ \t]*")) > (label-re (concat "\\(?:" > (mapconcat #'identity reftex-label-regexps "\\|") > "\\)")) > --8<---------------cut here---------------end--------------->8--- > > Can you please tell me if this should go to master or emacs-29 branch? How safe is the change? If it is safe enough, emacs-29 is fine. Tassilo, WDYT about the safety of the patch and/or about the urgency to have the fix?