all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* bug#62887: [PATCH] A small supplement and a typo fix for doc/lispref
@ 2023-04-16 18:37 Shynur Xie
  2023-04-18 12:06 ` Eli Zaretskii
  0 siblings, 1 reply; 2+ messages in thread
From: Shynur Xie @ 2023-04-16 18:37 UTC (permalink / raw)
  To: 62887

[-- Attachment #1: Type: text/plain, Size: 1217 bytes --]

1. Supplement for doc/lispref/customize.texi (Defining Customization
   Groups): Faces are also stored in the `custom-group' property.

Original:

The variables and subgroups of a group are stored in the custom-group
property of the group's symbol. ...... The value of that property is a
list of pairs whose car is the variable or subgroup symbol and the cdr
is either custom-variable or custom-group.

Updated:

The variables, faces, and subgroups of a group are stored in the
custom-group property of the group's symbol. ...... The value of that
property is a list of pairs whose car is the variable, face, or
subgroup symbol and the cdr is either custom-variable, custom-face, or
custom-group.

Reason:

```
(defgroup shynur/groupA ()
  "")

(defface shynur/groupA-face
  ()
  ""
  :group 'shynur/groupA)

(get 'shynur/groupA 'custom-group)
;; => ((shynur/groupA-face custom-face))
```

_____________________________________________________________________

2. Fix typo for doc/lispref/loading.texi (Emacs Dynamic Modules): Fix
   typo.

Original:

......, if the use typed C-g during the initialization.

Fixed:

......, if the user typed C-g during the initialization.

[-- Attachment #2: 0001-A-small-supplement-and-a-typo-fix-for-doc-lispref.patch --]
[-- Type: application/octet-stream, Size: 2191 bytes --]

From 89da70f90e216f7a16a8c516b230374f853e0c0f Mon Sep 17 00:00:00 2001
From: Shynur <one.last.kiss@outlook.com>
Date: Mon, 17 Apr 2023 02:13:32 +0800
Subject: [PATCH] A small supplement and a typo fix for doc/lispref

* doc/lispref/customize.texi (Defining Customization Groups): Faces are also stored in the `custom-group' property.
* doc/lispref/loading.texi (Emacs Dynamic Modules): Fix typo.
---
 doc/lispref/customize.texi | 7 ++++---
 doc/lispref/loading.texi   | 2 +-
 2 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/doc/lispref/customize.texi b/doc/lispref/customize.texi
index 6015c134d21..849fae04a8b 100644
--- a/doc/lispref/customize.texi
+++ b/doc/lispref/customize.texi
@@ -264,11 +264,12 @@ have any number of prefixes.
 @end table
 
 @cindex @code{custom-group} property
-The variables and subgroups of a group are stored in the
+The variables, faces, and subgroups of a group are stored in the
 @code{custom-group} property of the group's symbol.  @xref{Symbol
 Plists}.  The value of that property is a list of pairs whose
-@code{car} is the variable or subgroup symbol and the @code{cdr} is
-either @code{custom-variable} or @code{custom-group}.
+@code{car} is the variable, face, or subgroup symbol and the
+@code{cdr} is either @code{custom-variable}, @code{custom-face}, or
+@code{custom-group}.
 @end defmac
 
 @defopt custom-unlispify-remove-prefixes
diff --git a/doc/lispref/loading.texi b/doc/lispref/loading.texi
index 5c84ba4b1eb..d6fc4e8d636 100644
--- a/doc/lispref/loading.texi
+++ b/doc/lispref/loading.texi
@@ -1338,7 +1338,7 @@ specified @var{file} and perform the necessary initialization of the
 module.  This is the primitive which makes sure the module exports the
 @code{plugin_is_GPL_compatible} symbol, calls the module's
 @code{emacs_module_init} function, and signals an error if that
-function returns an error indication, or if the use typed @kbd{C-g}
+function returns an error indication, or if the user typed @kbd{C-g}
 during the initialization.  If the initialization succeeds,
 @code{module-load} returns @code{t}.  Note that @var{file} must
 already have the proper file-name extension, as this function doesn't
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* bug#62887: [PATCH] A small supplement and a typo fix for doc/lispref
  2023-04-16 18:37 bug#62887: [PATCH] A small supplement and a typo fix for doc/lispref Shynur Xie
@ 2023-04-18 12:06 ` Eli Zaretskii
  0 siblings, 0 replies; 2+ messages in thread
From: Eli Zaretskii @ 2023-04-18 12:06 UTC (permalink / raw)
  To: Shynur Xie; +Cc: 62887-done

> From: Shynur Xie <one.last.kiss@outlook.com>
> Date: Sun, 16 Apr 2023 18:37:09 +0000
> msip_labels: 
> 
> 1. Supplement for doc/lispref/customize.texi (Defining Customization
>    Groups): Faces are also stored in the `custom-group' property.
> 
> Original:
> 
> The variables and subgroups of a group are stored in the custom-group
> property of the group's symbol. ...... The value of that property is a
> list of pairs whose car is the variable or subgroup symbol and the cdr
> is either custom-variable or custom-group.
> 
> Updated:
> 
> The variables, faces, and subgroups of a group are stored in the
> custom-group property of the group's symbol. ...... The value of that
> property is a list of pairs whose car is the variable, face, or
> subgroup symbol and the cdr is either custom-variable, custom-face, or
> custom-group.
> 
> Reason:
> 
> ```
> (defgroup shynur/groupA ()
>   "")
> 
> (defface shynur/groupA-face
>   ()
>   ""
>   :group 'shynur/groupA)
> 
> (get 'shynur/groupA 'custom-group)
> ;; => ((shynur/groupA-face custom-face))
> ```
> 
> _____________________________________________________________________
> 
> 2. Fix typo for doc/lispref/loading.texi (Emacs Dynamic Modules): Fix
>    typo.
> 
> Original:
> 
> ......, if the use typed C-g during the initialization.
> 
> Fixed:
> 
> ......, if the user typed C-g during the initialization.

Thanks, fixed on the emacs-29 release branch.

Btw, you have now exhausted the amount of changes we can accept from
you without copyright assignment.  Would you like to start your
assignment process at this time, so that we could keep accepting your
contributions in the future?





^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-04-18 12:06 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-04-16 18:37 bug#62887: [PATCH] A small supplement and a typo fix for doc/lispref Shynur Xie
2023-04-18 12:06 ` Eli Zaretskii

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.