tree sitter failures

tree sitter failures

[Po Lu]

Since some recent change the incremental build has stopped working, with
the byte-compiler complaining that it cannot find `treesit-buffer-root-node'.
I have installed this change to fix it.

But why is pcase-let or the byte compiler evaluating a binding during
macro expansion? That sounds like a bug somewhere.

diff --git a/lisp/treesit.el b/lisp/treesit.el
index c9f2e339dc2..202a383ed7d 100644
--- a/lisp/treesit.el
+++ b/lisp/treesit.el
@@ -86,6 +86,7 @@
 
 (declare-function treesit-search-subtree "treesit.c")
 (declare-function treesit-search-forward "treesit.c")
+(declare-function treesit-subtree-stat "treesit.c")
 (declare-function treesit-induce-sparse-tree "treesit.c")
 
 (declare-function treesit-available-p "treesit.c")
@@ -265,12 +266,14 @@ treesit-buffer-root-node
 Use the first parser in the parser list if LANGUAGE is omitted.
 If LANGUAGE is non-nil, use the first parser for LANGUAGE in the
 parser list, or create one if none exists."
-  (if-let ((parser
-            (if language
-                (treesit-parser-create language)
-              (or (car (treesit-parser-list))
-                  (signal 'treesit-no-parser (list (current-buffer)))))))
-      (treesit-parser-root-node parser)))
+  ;; Otherwise the incremental build is broken without tree-sitter.
+  (when (treesit-available-p)
+    (if-let ((parser
+              (if language
+                  (treesit-parser-create language)
+                (or (car (treesit-parser-list))
+                    (signal 'treesit-no-parser (list (current-buffer)))))))
+        (treesit-parser-root-node parser))))
 
 (defun treesit-filter-child (node pred &optional named)
   "Return children of NODE that satisfies predicate PRED.

Re: tree sitter failures

[Po Lu]

Po Lu <luangruo@yahoo.com> writes:

> Since some recent change the incremental build has stopped working, with
> the byte-compiler complaining that it cannot find `treesit-buffer-root-node'.
> I have installed this change to fix it.
>
> But why is pcase-let or the byte compiler evaluating a binding during
> macro expansion? That sounds like a bug somewhere.

BTW, I hope this stuff doesn't affect the release branch, because if bugs
like these affect Emacs 29, then I guess it would be safer to postpone
the pretest until bugs introduced by tree-sitter are ironed out...

Re: tree sitter failures

[Eli Zaretskii]

> From: Po Lu <luangruo@yahoo.com>
> Date: Mon, 30 Jan 2023 21:32:30 +0800
> 
> Since some recent change the incremental build has stopped working, with
> the byte-compiler complaining that it cannot find `treesit-buffer-root-node'.
> I have installed this change to fix it.

On which branch?

Are you sure this wasn't due to the same bug I fixed a few minutes ago
in treesit.el?

> But why is pcase-let or the byte compiler evaluating a binding during
> macro expansion? That sounds like a bug somewhere.

I don't think this happens.  Please undo the change and show the error
message.

Re: tree sitter failures

[Po Lu]

Eli Zaretskii <eliz@gnu.org> writes:

> On which branch?
>
> Are you sure this wasn't due to the same bug I fixed a few minutes ago
> in treesit.el?

I think it was, and we tried to fix the same bug at the same time.  What
an unusual coincidence.  Please feel free to undo my change.

Thanks.

Re: tree sitter failures

[Eli Zaretskii]

> From: Po Lu <luangruo@yahoo.com>
> Cc: emacs-devel@gnu.org
> Date: Mon, 30 Jan 2023 22:35:56 +0800
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> > On which branch?
> >
> > Are you sure this wasn't due to the same bug I fixed a few minutes ago
> > in treesit.el?
> 
> I think it was, and we tried to fix the same bug at the same time.  What
> an unusual coincidence.  Please feel free to undo my change.

Done.