all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Po Lu <luangruo@yahoo.com>, Paul Eggert <eggert@cs.ucla.edu>
Cc: tumashu@163.com, stephen.berman@gmx.net, visuweshm@gmail.com,
	kupfer@rawbw.com, 58771@debbugs.gnu.org
Subject: bug#58771: 29.0.50; context submenu can not click when run emacs lucid build.
Date: Fri, 13 Jan 2023 09:32:11 +0200	[thread overview]
Message-ID: <83sfgeao04.fsf@gnu.org> (raw)
In-Reply-To: <87lem6dhq4.fsf@yahoo.com> (message from Po Lu on Fri, 13 Jan 2023 15:19:31 +0800)

> From: Po Lu <luangruo@yahoo.com>
> Cc: Eli Zaretskii <eliz@gnu.org>,  tumashu@163.com,  stephen.berman@gmx.net,
>   58771@debbugs.gnu.org,  visuweshm@gmail.com
> Date: Fri, 13 Jan 2023 15:19:31 +0800
> 
> Mike Kupfer <kupfer@rawbw.com> writes:
> > Could it be that the root cause for this is that ALLOBJS is not
> > defined in lwlib/Makefile.in?
> 
> I think you've identified the problem.  I tried hacking lwlib/Makefile
> as follows:
> 
> --- Makefile~	2022-12-29 17:42:05.288751298 -0800
> +++ Makefile	2023-01-12 21:08:24.717146041 -0800
> @@ -57,6 +57,8 @@
>  
>  OBJS = lwlib.o $(TOOLKIT_OBJS) lwlib-utils.o
>  
> +ALLOBJS = $(OBJS)
> +
>  -include ${top_builddir}/src/verbose.mk
>  
>  AUTO_DEPEND = yes
> 
> Now, when I touch src/globals.h and run "make", xlwmenu.o does get
> rebuilt.

> > Po Lu wrote:
> >
> >> Mike, what are the contents of lwlib/deps/xlwmenu.d on your system?
> >
> > I've attached the version from my most recent backup.  Its mtime
> > predates when I built the broken binary.  The contents are the same as
> > what's currently in my build tree.
> >
> > mike
> >
> > xlwmenu.o: xlwmenu.c ../src/config.h ../src/conf_post.h ../src/lisp.h \
> >  ../lib/alloca.h ../lib/string.h ../lib/inttypes.h ../lib/attribute.h \
> >  ../lib/intprops.h ../lib/intprops-internal.h ../lib/verify.h \
> >  ../src/globals.h ../src/comp.h ../src/dynlib.h ../src/thread.h \
> >  ../src/regex-emacs.h ../src/lisp.h ../src/sysselect.h \
> >  ../lib/sys/select.h ../src/systhread.h ../lib/stdio.h xlwmenuP.h \
> >  xlwmenu.h lwlib.h lwlib-widget.h ../src/lisp.h lwlib-utils.h \
> >  ../src/xterm.h ../src/dispextern.h ../src/character.h ../lib/c-strcase.h \
> >  ../src/fontset.h ../src/termhooks.h ../src/systime.h ../lib/timespec.h \
> >  ../lib/arg-nonnull.h ../src/bitmaps/gray.xbm
> > ../src/config.h:
> > ../src/conf_post.h:
> > ../src/lisp.h:
> > ../lib/alloca.h:
> > ../lib/string.h:
> > ../lib/inttypes.h:
> > ../lib/attribute.h:
> > ../lib/intprops.h:
> > ../lib/intprops-internal.h:
> > ../lib/verify.h:
> > ../src/globals.h:
> > ../src/comp.h:
> > ../src/dynlib.h:
> > ../src/thread.h:
> > ../src/regex-emacs.h:
> > ../src/lisp.h:
> > ../src/sysselect.h:
> > ../lib/sys/select.h:
> > ../src/systhread.h:
> > ../lib/stdio.h:
> > xlwmenuP.h:
> > xlwmenu.h:
> > lwlib.h:
> > lwlib-widget.h:
> > ../src/lisp.h:
> > lwlib-utils.h:
> > ../src/xterm.h:
> > ../src/dispextern.h:
> > ../src/character.h:
> > ../lib/c-strcase.h:
> > ../src/fontset.h:
> > ../src/termhooks.h:
> > ../src/systime.h:
> > ../lib/timespec.h:
> > ../lib/arg-nonnull.h:
> > ../src/bitmaps/gray.xbm:
> 
> Here xlwmenu.o does depend on globals.h.  But I think lwlib is being
> built before make-docfile is run, so we will need to make it depend on
> make-docfile being run.
> 
> Does anyone have a better idea?

I think the dependency is the correct idea, yes.

Paul, is it true that lwlib/Makefile.in needs to define ALLOBJS for
the deps stuff to work correctly?





  reply	other threads:[~2023-01-13  7:32 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-25  5:28 bug#58771: 29.0.50; context submenu can not click when run emacs lucid build Feng Shu
2022-10-25  7:43 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-10-25  8:35   ` Feng Shu
2022-10-25 10:30     ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-10-25 13:58       ` Stephen Berman
2022-10-26  0:42         ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-10-26  8:00           ` Stephen Berman
2022-10-26  8:18             ` Visuwesh
2022-10-26  9:40               ` Stephen Berman
2023-01-11  6:57               ` Mike Kupfer
2023-01-11  9:47                 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-01-11 20:44                   ` Mike Kupfer
2023-01-12  1:22                     ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-01-12  2:16                       ` Mike Kupfer
2023-01-12  3:44                         ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-01-12  8:05                           ` Eli Zaretskii
2023-01-12 10:34                             ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-01-13  2:43                               ` Mike Kupfer
2023-01-13  7:19                                 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-01-13  7:32                                   ` Eli Zaretskii [this message]
2023-01-14  2:28                                     ` Paul Eggert
2023-01-14  7:25                                       ` Eli Zaretskii
2023-01-14  7:48                                         ` Paul Eggert
2023-01-13  7:35                                   ` Jean Louis
2023-01-12  8:56                     ` Eli Zaretskii
2023-01-13  5:23                       ` Mike Kupfer
2022-10-26  8:20             ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-10-26  9:40               ` Stephen Berman
2022-10-26  9:55                 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-10-26  2:14   ` Feng Shu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83sfgeao04.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=58771@debbugs.gnu.org \
    --cc=eggert@cs.ucla.edu \
    --cc=kupfer@rawbw.com \
    --cc=luangruo@yahoo.com \
    --cc=stephen.berman@gmx.net \
    --cc=tumashu@163.com \
    --cc=visuweshm@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.