all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Paul Eggert <eggert@cs.ucla.edu>
To: Eli Zaretskii <eliz@gnu.org>
Cc: tumashu@163.com, Po Lu <luangruo@yahoo.com>,
	58771@debbugs.gnu.org, visuweshm@gmail.com,
	stephen.berman@gmx.net, kupfer@rawbw.com
Subject: bug#58771: 29.0.50; context submenu can not click when run emacs lucid build.
Date: Fri, 13 Jan 2023 18:28:23 -0800	[thread overview]
Message-ID: <0ab4a0c1-899c-f9cc-dc61-c6a3eda0bc68@cs.ucla.edu> (raw)
In-Reply-To: <83sfgeao04.fsf@gnu.org>

[-- Attachment #1: Type: text/plain, Size: 475 bytes --]

On 2023-01-12 23:32, Eli Zaretskii wrote:
> Paul, is it true that lwlib/Makefile.in needs to define ALLOBJS for
> the deps stuff to work correctly?

Although that should work, the attached proposed emacs-29 fix is a bit 
cleaner.

I've been bitten by the bug myself but never found the time to report or 
fix it until now. Although the bug is not a regression its symptoms are 
mysterious and the patch is simple and obvious. Your call as to which 
branch it should go into.

[-- Attachment #2: 0001-Fix-dependency-bug-when-building-lwlib.patch --]
[-- Type: text/x-patch, Size: 945 bytes --]

From cff3f7e057d09b1dd0ec2aeadaa34fd06599ff6b Mon Sep 17 00:00:00 2001
From: Paul Eggert <eggert@cs.ucla.edu>
Date: Fri, 13 Jan 2023 18:22:47 -0800
Subject: [PATCH] Fix dependency bug when building lwlib

* lwlib/Makefile.in (DEPFLAGS): Use OBJS to calculate dependency
file names, not ALLOBJS.  This fixes a typo introduced
in 2015-05-15 "Replace AC_SUBST_FILE in configure with include in
Makefiles" that caused lwlib/*.o to not be rebuilt sometimes
when that was needed.
---
 lwlib/Makefile.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lwlib/Makefile.in b/lwlib/Makefile.in
index 903461a2f4a..70f6cd17d78 100644
--- a/lwlib/Makefile.in
+++ b/lwlib/Makefile.in
@@ -63,7 +63,7 @@ AUTO_DEPEND =
 DEPDIR = deps
 ifeq ($(AUTO_DEPEND),yes)
   DEPFLAGS = -MMD -MF $(DEPDIR)/$*.d -MP
-  -include $(ALLOBJS:%.o=$(DEPDIR)/%.d)
+  -include $(OBJS:%.o=$(DEPDIR)/%.d)
 else
   DEPFLAGS =
   include $(srcdir)/deps.mk
-- 
2.37.2


  reply	other threads:[~2023-01-14  2:28 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-25  5:28 bug#58771: 29.0.50; context submenu can not click when run emacs lucid build Feng Shu
2022-10-25  7:43 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-10-25  8:35   ` Feng Shu
2022-10-25 10:30     ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-10-25 13:58       ` Stephen Berman
2022-10-26  0:42         ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-10-26  8:00           ` Stephen Berman
2022-10-26  8:18             ` Visuwesh
2022-10-26  9:40               ` Stephen Berman
2023-01-11  6:57               ` Mike Kupfer
2023-01-11  9:47                 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-01-11 20:44                   ` Mike Kupfer
2023-01-12  1:22                     ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-01-12  2:16                       ` Mike Kupfer
2023-01-12  3:44                         ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-01-12  8:05                           ` Eli Zaretskii
2023-01-12 10:34                             ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-01-13  2:43                               ` Mike Kupfer
2023-01-13  7:19                                 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-01-13  7:32                                   ` Eli Zaretskii
2023-01-14  2:28                                     ` Paul Eggert [this message]
2023-01-14  7:25                                       ` Eli Zaretskii
2023-01-14  7:48                                         ` Paul Eggert
2023-01-13  7:35                                   ` Jean Louis
2023-01-12  8:56                     ` Eli Zaretskii
2023-01-13  5:23                       ` Mike Kupfer
2022-10-26  8:20             ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-10-26  9:40               ` Stephen Berman
2022-10-26  9:55                 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-10-26  2:14   ` Feng Shu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0ab4a0c1-899c-f9cc-dc61-c6a3eda0bc68@cs.ucla.edu \
    --to=eggert@cs.ucla.edu \
    --cc=58771@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=kupfer@rawbw.com \
    --cc=luangruo@yahoo.com \
    --cc=stephen.berman@gmx.net \
    --cc=tumashu@163.com \
    --cc=visuweshm@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.