* bug#57649: 27.1; Spell check on remote file fails on windows.
@ 2022-09-07 14:32 Nick Longo
2022-09-08 6:37 ` Michael Albinus
0 siblings, 1 reply; 12+ messages in thread
From: Nick Longo @ 2022-09-07 14:32 UTC (permalink / raw)
To: 57649
[-- Attachment #1: Type: text/plain, Size: 4898 bytes --]
When working on a remote file from windows, if I try to invoke spell check I get the
following error message:
"apply: Opening process input file: No such file or directory, /plinkx:..."
In GNU Emacs 27.1 (build 1, x86_64-w64-mingw32)
of 2020-08-21 built on CIRROCUMULUS
Repository revision: 86d8d76aa36037184db0b2897c434cdaab1a9ae8
Repository branch: HEAD
Windowing system distributor 'Microsoft Corp.', version 10.0.19044
System Description: Microsoft Windows 10 Enterprise (v10.0.2009.19044.1889)
Recent messages:
Mark activated
Auto-saving...done
Mark set
[a-z..]:Set [SPC]:clear
Auto-saving...done
apply: Opening process input file: No such file or directory, /plinkx:homeoffice:/home/nmichalo/NUL
user-error: Minibuffer window is not active
Mark set
Auto-saving...done
Making completion list...
Configured using:
'configure --without-dbus --host=x86_64-w64-mingw32
--without-compress-install 'CFLAGS=-O2 -static''
Configured features:
XPM JPEG TIFF GIF PNG RSVG SOUND NOTIFY W32NOTIFY ACL GNUTLS LIBXML2
HARFBUZZ ZLIB TOOLKIT_SCROLL_BARS MODULES THREADS JSON PDUMPER LCMS2 GMP
Important settings:
value of $LANG: ENU
locale-coding-system: cp1252
Major mode: Messages
Minor modes in effect:
shell-dirtrack-mode: t
tooltip-mode: t
global-eldoc-mode: t
electric-indent-mode: t
mouse-wheel-mode: t
tool-bar-mode: t
menu-bar-mode: t
file-name-shadow-mode: t
global-font-lock-mode: t
font-lock-mode: t
blink-cursor-mode: t
auto-composition-mode: t
auto-encryption-mode: t
auto-compression-mode: t
buffer-read-only: t
line-number-mode: t
transient-mark-mode: t
Load-path shadows:
None found.
Features:
(shadow sort mail-extr emacsbug sendmail ispell etags fileloop xref
project cus-edit cus-start cus-load thingatpt help-fns radix-tree
magit-utils crm dash misearch multi-isearch mule-util help-mode
org-duration diary-lib diary-loaddefs cal-iso org-element avl-tree
generator ol-eww ol-rmail ol-mhe ol-irc ol-info ol-gnus nnir gnus-sum
url url-proxy url-privacy url-expand url-methods url-history mailcap shr
url-cookie url-domsuf url-util svg xml dom gnus-group gnus-undo
gnus-start gnus-cloud nnimap nnmail mail-source utf7 netrc nnoo
gnus-spec gnus-int gnus-range message rmc puny rfc822 mml mml-sec epa
epg epg-config mm-decode mm-bodies mm-encode mail-parse rfc2231
mailabbrev gmm-utils mailheader gnus-win gnus nnheader gnus-util rmail
rmail-loaddefs rfc2047 rfc2045 ietf-drums text-property-search
mail-utils mm-util mail-prsvr wid-edit ol-docview doc-view jka-compr
image-mode exif ol-bibtex bibtex ol-bbdb ol-w3m matlab derived
matlab-compat pulse tramp-cache tramp-sh tramp tramp-loaddefs trampver
tramp-integration files-x tramp-compat shell parse-time iso8601
org-agenda org ob ob-tangle ob-ref ob-lob ob-table ob-exp org-macro
org-footnote org-src ob-comint org-pcomplete pcomplete comint ansi-color
ring org-list org-faces org-entities noutline outline easy-mmode
org-version ob-emacs-lisp ob-core ob-eval org-table org-keys
org-loaddefs find-func cal-menu calendar cal-loaddefs ol org-compat
advice org-macs format-spec dired-aux time-date dired dired-loaddefs
edmacro kmacro finder-inf info package easymenu browse-url url-handlers
url-parse auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs
password-cache json subr-x map url-vars seq byte-opt gv bytecomp
byte-compile cconv cl-loaddefs cl-lib tooltip eldoc electric uniquify
ediff-hook vc-hooks lisp-float-type mwheel dos-w32 ls-lisp disp-table
term/w32-win w32-win w32-vars term/common-win tool-bar dnd fontset image
regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode
lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch
timer select scroll-bar mouse jit-lock font-lock syntax facemenu
font-core term/tty-colors frame minibuffer cl-generic cham georgian
utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean
japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european
ethiopic indian cyrillic chinese composite charscript charprop
case-table epa-hook jka-cmpr-hook help simple abbrev obarray
cl-preloaded nadvice loaddefs button faces cus-face macroexp files
text-properties overlay sha1 md5 base64 format env code-pages mule
custom widget hashtable-print-readable backquote threads w32notify w32
lcms2 multi-tty make-network-process emacs)
Memory information:
((conses 16 615935 74180)
(symbols 48 29425 3)
(strings 32 158997 11131)
(string-bytes 1 4565061)
(vectors 16 51783)
(vector-slots 8 1301838 209838)
(floats 8 251 304)
(intervals 56 21301 859)
(buffers 1000 32))
[-- Attachment #2: Type: text/html, Size: 8257 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
* bug#57649: 27.1; Spell check on remote file fails on windows.
2022-09-07 14:32 bug#57649: 27.1; Spell check on remote file fails on windows Nick Longo
@ 2022-09-08 6:37 ` Michael Albinus
2022-09-08 14:49 ` Nick Longo
0 siblings, 1 reply; 12+ messages in thread
From: Michael Albinus @ 2022-09-08 6:37 UTC (permalink / raw)
To: Nick Longo; +Cc: 57649
Nick Longo <nlongo@mathworks.com> writes:
Hi Nick,
> When working on a remote file from windows, if I try to invoke spell
> check I get the
>
> following error message:
>
> "apply: Opening process input file: No such file or directory,
> /plinkx:..."
Could you pls tell which spell package in Emacs is involved? I don't use
spell in Emacs, so I need a starting point.
Best would be if you could give a recipe, starting with "emacs -Q". A
Lisp backtrace would also help.
Best regards, Michael.
^ permalink raw reply [flat|nested] 12+ messages in thread
* bug#57649: 27.1; Spell check on remote file fails on windows.
2022-09-08 6:37 ` Michael Albinus
@ 2022-09-08 14:49 ` Nick Longo
2022-09-08 15:09 ` Michael Albinus
0 siblings, 1 reply; 12+ messages in thread
From: Nick Longo @ 2022-09-08 14:49 UTC (permalink / raw)
To: Michael Albinus; +Cc: 57649@debbugs.gnu.org
Sure, I will be glad to try at any rate. Let me know if this is what you were looking for.
--N
Here is my recipe...
Ingredients:
A windows 10 install.
An emacs installation
A putty installation (on system path)
Hunspell installed along with English dictionary (on system path)
Reproduction steps:
1. Customzie emacs to use the hunspell program, mine looks something like:
(custom-set-variables
'(ispell-program-name "hunspell")
)
(setq ispell-alternate-dictionary "C:/path/to/hunspell/en_US.txt")
2. Open a remote file
C-x C-f /plinkx:homeoffice:/home/nmichalo/test.org
3. Find word in that file and call
M-x ispell-word
The emacs debugger gives:
Debugger entered--Lisp error: (file-missing "Opening process input file" "No such file or directory" "/plinkx:homeoffice:/home/nmichalo/NUL")
call-process("c:/NProgramFiles/bin/hunspell.exe" "NUL" t nil "-D" "-a" "NUL")
apply(call-process ("c:/NProgramFiles/bin/hunspell.exe" "NUL" t nil "-D" "-a" "NUL"))
ispell-call-process("c:/NProgramFiles/bin/hunspell.exe" "NUL" t nil "-D" "-a" "NUL")
ispell-find-hunspell-dictionaries()
ispell-set-spellchecker-params()
ispell-word(nil nil nil t)
funcall-interactively(ispell-word nil nil nil t)
call-interactively(ispell-word record nil)
command-execute(ispell-word record)
execute-extended-command(nil "ispell-word" "ispell-w")
funcall-interactively(execute-extended-command nil "ispell-word" "ispell-w")
call-interactively(execute-extended-command nil nil)
command-execute(execute-extended-command)
Comments:
This only happens when editing remote files. Otherwise ispell is working as expected.
The problem seems to resolve if I first open a local file, and call ispell-word on the local file first. After that ispell-word seems to work in both the local and remote files.
While running "emacs -Q" if I first encounter the error in ispell-word on a remote file, then I always encounter an error with ispell-word even on local files. This only seems to happen with the -Q option. The stack trace is different, included here for reference:
Debugger entered--Lisp error: (wrong-type-argument stringp nil)
string-match("," nil 0)
split-string(nil "," t)
ispell-parse-hunspell-affix-file(nil)
ispell-hunspell-fill-dictionary-entry(nil)
ispell-start-process()
ispell-init-process()
ispell-buffer-local-words()
ispell-accept-buffer-local-defs()
ispell-word(nil nil nil t)
funcall-interactively(ispell-word nil nil nil t)
call-interactively(ispell-word nil nil)
command-execute(ispell-word)
-----Original Message-----
From: Michael Albinus <michael.albinus@gmx.de>
Sent: Thursday, September 8, 2022 2:37 AM
To: Nick Longo <nlongo@mathworks.com>
Cc: 57649@debbugs.gnu.org
Subject: Re: bug#57649: 27.1; Spell check on remote file fails on windows.
Nick Longo <nlongo@mathworks.com> writes:
Hi Nick,
> When working on a remote file from windows, if I try to invoke spell
> check I get the
>
> following error message:
>
> "apply: Opening process input file: No such file or directory,
> /plinkx:..."
Could you pls tell which spell package in Emacs is involved? I don't use spell in Emacs, so I need a starting point.
Best would be if you could give a recipe, starting with "emacs -Q". A Lisp backtrace would also help.
Best regards, Michael.
^ permalink raw reply [flat|nested] 12+ messages in thread
* bug#57649: 27.1; Spell check on remote file fails on windows.
2022-09-08 14:49 ` Nick Longo
@ 2022-09-08 15:09 ` Michael Albinus
2022-09-08 17:14 ` Eli Zaretskii
0 siblings, 1 reply; 12+ messages in thread
From: Michael Albinus @ 2022-09-08 15:09 UTC (permalink / raw)
To: Nick Longo; +Cc: 57649@debbugs.gnu.org
Nick Longo <nlongo@mathworks.com> writes:
Hi Nick,
> Sure, I will be glad to try at any rate. Let me know if this is what you were looking for.
Thanks.
> The emacs debugger gives:
> Debugger entered--Lisp error: (file-missing "Opening process input file" "No such file or directory" "/plinkx:homeoffice:/home/nmichalo/NUL")
> call-process("c:/NProgramFiles/bin/hunspell.exe" "NUL" t nil "-D" "-a" "NUL")
> apply(call-process ("c:/NProgramFiles/bin/hunspell.exe" "NUL" t nil "-D" "-a" "NUL"))
> ispell-call-process("c:/NProgramFiles/bin/hunspell.exe" "NUL" t nil "-D" "-a" "NUL")
> ispell-find-hunspell-dictionaries()
That's it. `call-process' does not support remote files.
I've just checked in Emacs 29, ispell.el is still using
`call-process'. Somebody who knows this package shall adapt, using
either `process-file', or working on a temporary local copy of the file
to be spelled. Or perhaps the latter is already implemented, don't know.
Best regards, Michael.
^ permalink raw reply [flat|nested] 12+ messages in thread
* bug#57649: 27.1; Spell check on remote file fails on windows.
2022-09-08 15:09 ` Michael Albinus
@ 2022-09-08 17:14 ` Eli Zaretskii
2022-09-11 17:24 ` Eli Zaretskii
0 siblings, 1 reply; 12+ messages in thread
From: Eli Zaretskii @ 2022-09-08 17:14 UTC (permalink / raw)
To: Michael Albinus; +Cc: 57649, nlongo
> Cc: "57649@debbugs.gnu.org" <57649@debbugs.gnu.org>
> From: Michael Albinus <michael.albinus@gmx.de>
> Date: Thu, 08 Sep 2022 17:09:27 +0200
>
> > The emacs debugger gives:
> > Debugger entered--Lisp error: (file-missing "Opening process input file" "No such file or directory" "/plinkx:homeoffice:/home/nmichalo/NUL")
> > call-process("c:/NProgramFiles/bin/hunspell.exe" "NUL" t nil "-D" "-a" "NUL")
> > apply(call-process ("c:/NProgramFiles/bin/hunspell.exe" "NUL" t nil "-D" "-a" "NUL"))
> > ispell-call-process("c:/NProgramFiles/bin/hunspell.exe" "NUL" t nil "-D" "-a" "NUL")
> > ispell-find-hunspell-dictionaries()
>
> That's it. `call-process' does not support remote files.
>
> I've just checked in Emacs 29, ispell.el is still using
> `call-process'. Somebody who knows this package shall adapt, using
> either `process-file', or working on a temporary local copy of the file
> to be spelled.
In this case the problem is not with the file being spell-checked,
it's with default-directory.
The file should not be an issue, since Emacs spell-checking works by
sending buffer text to the local spell-checking process. It should
not matter where the buffer text came from.
So, going back to the default-directory problem, we have this:
(defmacro ispell-with-safe-default-directory (&rest body)
"Execute the forms in BODY with a reasonable `default-directory'."
(declare (indent 0) (debug t))
`(let ((default-directory default-directory))
(unless (file-accessible-directory-p default-directory)
(setq default-directory (expand-file-name "~/")))
,@body))
And I guess the problem is with file-accessible-directory-p, which in
this case returns non-nil, because it probes the accessibility of the
remote directory? So something like the below should fix the problem?
(defmacro ispell-with-safe-default-directory (&rest body)
"Execute the forms in BODY with a reasonable `default-directory'."
(declare (indent 0) (debug t))
`(let ((default-directory default-directory))
(unless (and (not (file-remote-p default-directory))
(file-accessible-directory-p default-directory))
(setq default-directory (expand-file-name "~/")))
,@body))
^ permalink raw reply [flat|nested] 12+ messages in thread
* bug#57649: 27.1; Spell check on remote file fails on windows.
2022-09-08 17:14 ` Eli Zaretskii
@ 2022-09-11 17:24 ` Eli Zaretskii
2022-09-16 17:31 ` Eli Zaretskii
0 siblings, 1 reply; 12+ messages in thread
From: Eli Zaretskii @ 2022-09-11 17:24 UTC (permalink / raw)
To: michael.albinus; +Cc: 57649, nlongo
Ping!
> Cc: 57649@debbugs.gnu.org, nlongo@mathworks.com
> Date: Thu, 08 Sep 2022 20:14:00 +0300
> From: Eli Zaretskii <eliz@gnu.org>
>
> > Cc: "57649@debbugs.gnu.org" <57649@debbugs.gnu.org>
> > From: Michael Albinus <michael.albinus@gmx.de>
> > Date: Thu, 08 Sep 2022 17:09:27 +0200
> >
> > > The emacs debugger gives:
> > > Debugger entered--Lisp error: (file-missing "Opening process input file" "No such file or directory" "/plinkx:homeoffice:/home/nmichalo/NUL")
> > > call-process("c:/NProgramFiles/bin/hunspell.exe" "NUL" t nil "-D" "-a" "NUL")
> > > apply(call-process ("c:/NProgramFiles/bin/hunspell.exe" "NUL" t nil "-D" "-a" "NUL"))
> > > ispell-call-process("c:/NProgramFiles/bin/hunspell.exe" "NUL" t nil "-D" "-a" "NUL")
> > > ispell-find-hunspell-dictionaries()
> >
> > That's it. `call-process' does not support remote files.
> >
> > I've just checked in Emacs 29, ispell.el is still using
> > `call-process'. Somebody who knows this package shall adapt, using
> > either `process-file', or working on a temporary local copy of the file
> > to be spelled.
>
> In this case the problem is not with the file being spell-checked,
> it's with default-directory.
>
> The file should not be an issue, since Emacs spell-checking works by
> sending buffer text to the local spell-checking process. It should
> not matter where the buffer text came from.
>
> So, going back to the default-directory problem, we have this:
>
> (defmacro ispell-with-safe-default-directory (&rest body)
> "Execute the forms in BODY with a reasonable `default-directory'."
> (declare (indent 0) (debug t))
> `(let ((default-directory default-directory))
> (unless (file-accessible-directory-p default-directory)
> (setq default-directory (expand-file-name "~/")))
> ,@body))
>
> And I guess the problem is with file-accessible-directory-p, which in
> this case returns non-nil, because it probes the accessibility of the
> remote directory? So something like the below should fix the problem?
>
> (defmacro ispell-with-safe-default-directory (&rest body)
> "Execute the forms in BODY with a reasonable `default-directory'."
> (declare (indent 0) (debug t))
> `(let ((default-directory default-directory))
> (unless (and (not (file-remote-p default-directory))
> (file-accessible-directory-p default-directory))
> (setq default-directory (expand-file-name "~/")))
> ,@body))
>
>
>
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* bug#57649: 27.1; Spell check on remote file fails on windows.
2022-09-11 17:24 ` Eli Zaretskii
@ 2022-09-16 17:31 ` Eli Zaretskii
2022-09-17 6:39 ` Michael Albinus
0 siblings, 1 reply; 12+ messages in thread
From: Eli Zaretskii @ 2022-09-16 17:31 UTC (permalink / raw)
To: michael.albinus; +Cc: 57649, nlongo
Ping! Ping!
Michael, could you please respond?
> Cc: 57649@debbugs.gnu.org, nlongo@mathworks.com
> Date: Sun, 11 Sep 2022 20:24:33 +0300
> From: Eli Zaretskii <eliz@gnu.org>
>
> Ping!
>
> > Cc: 57649@debbugs.gnu.org, nlongo@mathworks.com
> > Date: Thu, 08 Sep 2022 20:14:00 +0300
> > From: Eli Zaretskii <eliz@gnu.org>
> >
> > > Cc: "57649@debbugs.gnu.org" <57649@debbugs.gnu.org>
> > > From: Michael Albinus <michael.albinus@gmx.de>
> > > Date: Thu, 08 Sep 2022 17:09:27 +0200
> > >
> > > > The emacs debugger gives:
> > > > Debugger entered--Lisp error: (file-missing "Opening process input file" "No such file or directory" "/plinkx:homeoffice:/home/nmichalo/NUL")
> > > > call-process("c:/NProgramFiles/bin/hunspell.exe" "NUL" t nil "-D" "-a" "NUL")
> > > > apply(call-process ("c:/NProgramFiles/bin/hunspell.exe" "NUL" t nil "-D" "-a" "NUL"))
> > > > ispell-call-process("c:/NProgramFiles/bin/hunspell.exe" "NUL" t nil "-D" "-a" "NUL")
> > > > ispell-find-hunspell-dictionaries()
> > >
> > > That's it. `call-process' does not support remote files.
> > >
> > > I've just checked in Emacs 29, ispell.el is still using
> > > `call-process'. Somebody who knows this package shall adapt, using
> > > either `process-file', or working on a temporary local copy of the file
> > > to be spelled.
> >
> > In this case the problem is not with the file being spell-checked,
> > it's with default-directory.
> >
> > The file should not be an issue, since Emacs spell-checking works by
> > sending buffer text to the local spell-checking process. It should
> > not matter where the buffer text came from.
> >
> > So, going back to the default-directory problem, we have this:
> >
> > (defmacro ispell-with-safe-default-directory (&rest body)
> > "Execute the forms in BODY with a reasonable `default-directory'."
> > (declare (indent 0) (debug t))
> > `(let ((default-directory default-directory))
> > (unless (file-accessible-directory-p default-directory)
> > (setq default-directory (expand-file-name "~/")))
> > ,@body))
> >
> > And I guess the problem is with file-accessible-directory-p, which in
> > this case returns non-nil, because it probes the accessibility of the
> > remote directory? So something like the below should fix the problem?
> >
> > (defmacro ispell-with-safe-default-directory (&rest body)
> > "Execute the forms in BODY with a reasonable `default-directory'."
> > (declare (indent 0) (debug t))
> > `(let ((default-directory default-directory))
> > (unless (and (not (file-remote-p default-directory))
> > (file-accessible-directory-p default-directory))
> > (setq default-directory (expand-file-name "~/")))
> > ,@body))
> >
> >
> >
> >
>
>
>
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* bug#57649: 27.1; Spell check on remote file fails on windows.
2022-09-16 17:31 ` Eli Zaretskii
@ 2022-09-17 6:39 ` Michael Albinus
2022-09-17 7:12 ` Eli Zaretskii
0 siblings, 1 reply; 12+ messages in thread
From: Michael Albinus @ 2022-09-17 6:39 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: 57649, nlongo
Eli Zaretskii <eliz@gnu.org> writes:
Hi Eli,
> Ping! Ping!
>
> Michael, could you please respond?
I believe your patch should fix it. But since I'm not on MS Windows
(usually), I cannot check.
Best regards, Michael.
^ permalink raw reply [flat|nested] 12+ messages in thread
* bug#57649: 27.1; Spell check on remote file fails on windows.
2022-09-17 6:39 ` Michael Albinus
@ 2022-09-17 7:12 ` Eli Zaretskii
2022-09-22 21:00 ` Nick Longo
2022-10-03 13:25 ` Nick Longo
0 siblings, 2 replies; 12+ messages in thread
From: Eli Zaretskii @ 2022-09-17 7:12 UTC (permalink / raw)
To: Michael Albinus; +Cc: 57649, nlongo
> From: Michael Albinus <michael.albinus@gmx.de>
> Cc: 57649@debbugs.gnu.org, nlongo@mathworks.com
> Date: Sat, 17 Sep 2022 08:39:53 +0200
>
> Eli Zaretskii <eliz@gnu.org> writes:
>
> Hi Eli,
>
> > Ping! Ping!
> >
> > Michael, could you please respond?
>
> I believe your patch should fix it. But since I'm not on MS Windows
> (usually), I cannot check.
Thanks, installed on the master branch.
Nick, can you verify that this solves your problem? The patch is
below, if you need to apply it by hand.
diff --git a/lisp/textmodes/ispell.el b/lisp/textmodes/ispell.el
index 4b5ed98..b3fb326 100644
--- a/lisp/textmodes/ispell.el
+++ b/lisp/textmodes/ispell.el
@@ -740,7 +740,8 @@ ispell-with-safe-default-directory
"Execute the forms in BODY with a reasonable `default-directory'."
(declare (indent 0) (debug t))
`(let ((default-directory default-directory))
- (unless (file-accessible-directory-p default-directory)
+ (unless (and (not (file-remote-p default-directory))
+ (file-accessible-directory-p default-directory))
(setq default-directory (expand-file-name "~/")))
,@body))
^ permalink raw reply related [flat|nested] 12+ messages in thread
* bug#57649: 27.1; Spell check on remote file fails on windows.
2022-09-17 7:12 ` Eli Zaretskii
@ 2022-09-22 21:00 ` Nick Longo
2022-10-03 13:25 ` Nick Longo
1 sibling, 0 replies; 12+ messages in thread
From: Nick Longo @ 2022-09-22 21:00 UTC (permalink / raw)
To: Eli Zaretskii, Michael Albinus; +Cc: 57649@debbugs.gnu.org
Sorry for the slow reply, I've been swamped at work. I'll apply it this weekend and let you know.
--Nick
-----Original Message-----
From: Eli Zaretskii <eliz@gnu.org>
Sent: Saturday, September 17, 2022 3:13 AM
To: Michael Albinus <michael.albinus@gmx.de>
Cc: 57649@debbugs.gnu.org; Nick Longo <nlongo@mathworks.com>
Subject: Re: bug#57649: 27.1; Spell check on remote file fails on windows.
> From: Michael Albinus <michael.albinus@gmx.de>
> Cc: 57649@debbugs.gnu.org, nlongo@mathworks.com
> Date: Sat, 17 Sep 2022 08:39:53 +0200
>
> Eli Zaretskii <eliz@gnu.org> writes:
>
> Hi Eli,
>
> > Ping! Ping!
> >
> > Michael, could you please respond?
>
> I believe your patch should fix it. But since I'm not on MS Windows
> (usually), I cannot check.
Thanks, installed on the master branch.
Nick, can you verify that this solves your problem? The patch is below, if you need to apply it by hand.
diff --git a/lisp/textmodes/ispell.el b/lisp/textmodes/ispell.el index 4b5ed98..b3fb326 100644
--- a/lisp/textmodes/ispell.el
+++ b/lisp/textmodes/ispell.el
@@ -740,7 +740,8 @@ ispell-with-safe-default-directory
"Execute the forms in BODY with a reasonable `default-directory'."
(declare (indent 0) (debug t))
`(let ((default-directory default-directory))
- (unless (file-accessible-directory-p default-directory)
+ (unless (and (not (file-remote-p default-directory))
+ (file-accessible-directory-p default-directory))
(setq default-directory (expand-file-name "~/")))
,@body))
^ permalink raw reply [flat|nested] 12+ messages in thread
* bug#57649: 27.1; Spell check on remote file fails on windows.
2022-09-17 7:12 ` Eli Zaretskii
2022-09-22 21:00 ` Nick Longo
@ 2022-10-03 13:25 ` Nick Longo
2022-10-03 17:13 ` Eli Zaretskii
1 sibling, 1 reply; 12+ messages in thread
From: Nick Longo @ 2022-10-03 13:25 UTC (permalink / raw)
To: Eli Zaretskii, Michael Albinus; +Cc: 57649@debbugs.gnu.org
Sorry for the late reply (again). The patch works like a charm. Thank you very much.
--Nick
-----Original Message-----
From: Eli Zaretskii <eliz@gnu.org>
Sent: Saturday, September 17, 2022 3:13 AM
To: Michael Albinus <michael.albinus@gmx.de>
Cc: 57649@debbugs.gnu.org; Nick Longo <nlongo@mathworks.com>
Subject: Re: bug#57649: 27.1; Spell check on remote file fails on windows.
> From: Michael Albinus <michael.albinus@gmx.de>
> Cc: 57649@debbugs.gnu.org, nlongo@mathworks.com
> Date: Sat, 17 Sep 2022 08:39:53 +0200
>
> Eli Zaretskii <eliz@gnu.org> writes:
>
> Hi Eli,
>
> > Ping! Ping!
> >
> > Michael, could you please respond?
>
> I believe your patch should fix it. But since I'm not on MS Windows
> (usually), I cannot check.
Thanks, installed on the master branch.
Nick, can you verify that this solves your problem? The patch is below, if you need to apply it by hand.
diff --git a/lisp/textmodes/ispell.el b/lisp/textmodes/ispell.el index 4b5ed98..b3fb326 100644
--- a/lisp/textmodes/ispell.el
+++ b/lisp/textmodes/ispell.el
@@ -740,7 +740,8 @@ ispell-with-safe-default-directory
"Execute the forms in BODY with a reasonable `default-directory'."
(declare (indent 0) (debug t))
`(let ((default-directory default-directory))
- (unless (file-accessible-directory-p default-directory)
+ (unless (and (not (file-remote-p default-directory))
+ (file-accessible-directory-p default-directory))
(setq default-directory (expand-file-name "~/")))
,@body))
^ permalink raw reply [flat|nested] 12+ messages in thread
* bug#57649: 27.1; Spell check on remote file fails on windows.
2022-10-03 13:25 ` Nick Longo
@ 2022-10-03 17:13 ` Eli Zaretskii
0 siblings, 0 replies; 12+ messages in thread
From: Eli Zaretskii @ 2022-10-03 17:13 UTC (permalink / raw)
To: Nick Longo; +Cc: 57649-done, michael.albinus
> From: Nick Longo <nlongo@mathworks.com>
> CC: "57649@debbugs.gnu.org" <57649@debbugs.gnu.org>
> Date: Mon, 3 Oct 2022 13:25:26 +0000
>
> Sorry for the late reply (again). The patch works like a charm. Thank you very much.
Great, thanks for testing. I'm therefore closing this bug.
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2022-10-03 17:13 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-07 14:32 bug#57649: 27.1; Spell check on remote file fails on windows Nick Longo
2022-09-08 6:37 ` Michael Albinus
2022-09-08 14:49 ` Nick Longo
2022-09-08 15:09 ` Michael Albinus
2022-09-08 17:14 ` Eli Zaretskii
2022-09-11 17:24 ` Eli Zaretskii
2022-09-16 17:31 ` Eli Zaretskii
2022-09-17 6:39 ` Michael Albinus
2022-09-17 7:12 ` Eli Zaretskii
2022-09-22 21:00 ` Nick Longo
2022-10-03 13:25 ` Nick Longo
2022-10-03 17:13 ` Eli Zaretskii
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.