all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Sean Whitton <spwhitton@spwhitton.name>
Cc: emacs-devel@gnu.org
Subject: Re: master a30781399b3: * subr-x (eval-command-interactive-spec): New function.
Date: Wed, 14 Jun 2023 14:35:52 +0300	[thread overview]
Message-ID: <83r0qeuvhj.fsf@gnu.org> (raw)
In-Reply-To: <87bkhi5our.fsf@melete.silentflame.com> (message from Sean Whitton on Wed, 14 Jun 2023 11:18:20 +0100)

> From: Sean Whitton <spwhitton@spwhitton.name>
> Cc: emacs-devel@gnu.org
> Date: Wed, 14 Jun 2023 11:18:20 +0100
> 
> >>   There is no need to mention files such as NEWS and MAINTAINERS, or to
> >>   indicate regeneration of files such as 'lib/gnulib.mk', in the
> >>   ChangeLog entry.  "There is no need" means you don't have to, but you
> >>   can if you want to.
> >>
> >> Should that text perhaps be updated?
> >
> > Why? the last sentence already covers my request, doesn't it?
> 
> It seemed to me that the text should say that it's considered preferable
> to mention them.  The current text leaves it wholly up to an
> individual's inclination.

Which is basically the truth.  I personally prefer to mention every
file, but I don't feel like making my preferences codified and carved
in stone.

> >> > As for the name of the new function: what do people think about
> >> > renaming it to eval-interactive-spec?  I don't think we need the
> >> > "command" part.
> >>
> >> In that case, what would we rename advice-eval-interactive-spec to, when
> >> we drop the 'advice-' prefix?
> >
> > That function exists for quite some time, so renaming it is a much
> > harder decision.
> 
> If we decide not to rename it, wouldn't it then be confusing to have
> advice-eval-interactive-spec and eval-interactive-spec taking different
> kinds of argument, with no indication in their name about the difference?

We use aliases to prevent such confusion.



  reply	other threads:[~2023-06-14 11:35 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-05 11:40 master a30781399b3: * subr-x (eval-command-interactive-spec): New function Eli Zaretskii
2023-06-06 11:10 ` Sean Whitton
2023-06-06 11:59   ` Eli Zaretskii
2023-06-14 10:18     ` Sean Whitton
2023-06-14 11:35       ` Eli Zaretskii [this message]
     [not found] <168595059426.2523.2109338263713299231@vcs2.savannah.gnu.org>
     [not found] ` <20230605073635.19060C00613@vcs2.savannah.gnu.org>
2023-06-05 10:24   ` Philip Kaludercic
2023-06-06 11:10     ` Sean Whitton
2023-06-06 11:25     ` Mattias Engdegård
2023-06-05 16:14   ` Stefan Monnier
2023-06-06 11:18     ` Sean Whitton
2023-06-09 14:39       ` Stefan Monnier
2023-06-14 10:14         ` Sean Whitton
2023-06-14 20:52           ` Stefan Monnier
2023-06-16  7:12             ` Sean Whitton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83r0qeuvhj.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=spwhitton@spwhitton.name \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.