From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master a30781399b3: * subr-x (eval-command-interactive-spec): New function. Date: Wed, 14 Jun 2023 14:35:52 +0300 Message-ID: <83r0qeuvhj.fsf@gnu.org> References: <83r0qq3zo3.fsf@gnu.org> <87edmog836.fsf@melete.silentflame.com> <83r0qo3ioj.fsf@gnu.org> <87bkhi5our.fsf@melete.silentflame.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37777"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Sean Whitton Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Jun 14 13:36:28 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q9OnY-0009ST-SH for ged-emacs-devel@m.gmane-mx.org; Wed, 14 Jun 2023 13:36:24 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q9Omk-0004DV-6f; Wed, 14 Jun 2023 07:35:34 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q9Omi-0004DF-AT for emacs-devel@gnu.org; Wed, 14 Jun 2023 07:35:32 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q9Omi-0004He-1e; Wed, 14 Jun 2023 07:35:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=gJeBP3X9M9+i1XztG8R5hisJ7fqYJl1scx4xhWvecoM=; b=paQoQZDiKtZp gO3EObzNaCP6M8UVb+nWFUpwqTVO3QW4u4T60mom6xAFme3Pe08Y+2m67D0YktnCUGYlUpd5o6MUE l19SorJqzmkN0mH9qBAY1Ok6revger+eI0xedS5vHqXmRlaYqNlkF+cfcx1HXW/ZU6J1seZj9LYGw oQ3cWh5i04hHyE8Fye4QvoMsnAxvFaKEaHNlE4JzODLvd4hKAppPBK8Vl8wUNoLkkK3gggImFfbYm emvEZnFO0MniMzRbPDr9sYu46nxZDjNM7tGDUZZPfukQxUPhi1YMd+Glkh0fr04huj4JnkRjPZtQN taAN7fiSSEcvRaKHkJPfqw==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q9Omh-00035J-I4; Wed, 14 Jun 2023 07:35:31 -0400 In-Reply-To: <87bkhi5our.fsf@melete.silentflame.com> (message from Sean Whitton on Wed, 14 Jun 2023 11:18:20 +0100) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:306794 Archived-At: > From: Sean Whitton > Cc: emacs-devel@gnu.org > Date: Wed, 14 Jun 2023 11:18:20 +0100 > > >> There is no need to mention files such as NEWS and MAINTAINERS, or to > >> indicate regeneration of files such as 'lib/gnulib.mk', in the > >> ChangeLog entry. "There is no need" means you don't have to, but you > >> can if you want to. > >> > >> Should that text perhaps be updated? > > > > Why? the last sentence already covers my request, doesn't it? > > It seemed to me that the text should say that it's considered preferable > to mention them. The current text leaves it wholly up to an > individual's inclination. Which is basically the truth. I personally prefer to mention every file, but I don't feel like making my preferences codified and carved in stone. > >> > As for the name of the new function: what do people think about > >> > renaming it to eval-interactive-spec? I don't think we need the > >> > "command" part. > >> > >> In that case, what would we rename advice-eval-interactive-spec to, when > >> we drop the 'advice-' prefix? > > > > That function exists for quite some time, so renaming it is a much > > harder decision. > > If we decide not to rename it, wouldn't it then be confusing to have > advice-eval-interactive-spec and eval-interactive-spec taking different > kinds of argument, with no indication in their name about the difference? We use aliases to prevent such confusion.