From: Eli Zaretskii <eliz@gnu.org>
To: Konstantin Kharlamov <Hi-Angel@yandex.ru>
Cc: casouri@gmail.com, 68579@debbugs.gnu.org
Subject: bug#68579: [PATCH] Support a local repo as URL in treesit-language-source-alist
Date: Fri, 19 Jan 2024 18:26:00 +0200 [thread overview]
Message-ID: <83jzo5uw6f.fsf@gnu.org> (raw)
In-Reply-To: <4b9f254dcba00812e8f6002d82cd7ebb0a29c45e.camel@yandex.ru> (message from Konstantin Kharlamov on Fri, 19 Jan 2024 19:06:59 +0300)
> From: Konstantin Kharlamov <Hi-Angel@yandex.ru>
> Cc: casouri@gmail.com, 68579@debbugs.gnu.org
> Date: Fri, 19 Jan 2024 19:06:59 +0300
>
> On Fri, 2024-01-19 at 17:06 +0200, Eli Zaretskii wrote:
> > > From: Konstantin Kharlamov <Hi-Angel@yandex.ru>
> > > Cc: casouri@gmail.com, 68579@debbugs.gnu.org
> > > Date: Fri, 19 Jan 2024 17:33:03 +0300
> > >
> > > > > > > - (when (file-exists-p workdir)
> > > > > > > + (when (and (not url-is-path) (file-exists-p
> > > > > > > workdir))
> > > > > > > (delete-directory workdir t)))))
> > > > > >
> > > > > > Why? Does workdir have different semantics in these two use
> > > > > > cases?
> > > > > > Isn't it the directory where we cloned the repository?
> > > > >
> > > > > When an absolute path is passed as URL, that means the user
> > > > > have
> > > > > cloned
> > > > > the repo, not us.
> > > >
> > > > But you still clone from it into workdir, no? treesit--git-
> > > > clone-
> > > > repo
> > > > invokes "git clone" in both cases, according to my reading of the
> > > > patch.
> > >
> > > No, the `treesit--git-clone-repo` is located on the "else" branch
> > > of
> > > the `(if url-is-path`. That is, we do not call it when it's a local
> > > path
> >
> > Then this assumes some kind of workflow, doesn't it? The user must
> > first clone the repository, either via treesit.el or manually, and
> > then they can use this new feature, right? So I guess we should
> > document this workflow somewhere?
>
> Well, I can add some docs if you want, but the workflow per se seems
> obvious to me: you have a function that accepts a local path to repo
> and builds from it.
What I had in mind is some short description in the doc string of the
interactive command that invokes all this stuff.
next prev parent reply other threads:[~2024-01-19 16:26 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-19 8:08 bug#68579: [PATCH] Support a local repo as URL in treesit-language-source-alist Konstantin Kharlamov
2024-01-19 8:33 ` Eli Zaretskii
2024-01-19 8:57 ` Konstantin Kharlamov
2024-01-19 11:46 ` Eli Zaretskii
2024-01-19 14:33 ` Konstantin Kharlamov
2024-01-19 15:06 ` Eli Zaretskii
2024-01-19 16:06 ` Konstantin Kharlamov
2024-01-19 16:26 ` Eli Zaretskii [this message]
2024-01-20 12:00 ` bug#68579: [PATCH v2] " Konstantin Kharlamov
2024-01-20 12:04 ` Konstantin Kharlamov
2024-01-20 11:56 ` Konstantin Kharlamov
2024-01-27 9:37 ` Eli Zaretskii
2024-01-27 18:53 ` Konstantin Kharlamov
2024-01-27 19:21 ` Eli Zaretskii
2024-02-01 10:06 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83jzo5uw6f.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=68579@debbugs.gnu.org \
--cc=Hi-Angel@yandex.ru \
--cc=casouri@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.