From: Konstantin Kharlamov <Hi-Angel@yandex.ru>
To: Eli Zaretskii <eliz@gnu.org>
Cc: casouri@gmail.com, 68579@debbugs.gnu.org
Subject: bug#68579: [PATCH] Support a local repo as URL in treesit-language-source-alist
Date: Fri, 19 Jan 2024 17:33:03 +0300 [thread overview]
Message-ID: <79692782ee323c59388fac26d39dc70aeb525284.camel@yandex.ru> (raw)
In-Reply-To: <83ededwno1.fsf@gnu.org>
On Fri, 2024-01-19 at 13:46 +0200, Eli Zaretskii wrote:
> > From: Konstantin Kharlamov <Hi-Angel@yandex.ru>
> > Cc: 68579@debbugs.gnu.org
> > Date: Fri, 19 Jan 2024 11:57:48 +0300
> >
> > On Fri, 2024-01-19 at 10:33 +0200, Eli Zaretskii wrote:
> > […]
> >
> > Thank you!
> >
> > >
> > > > + (url-is-path (string-prefix-p "/" url))
> > >
> > > "Path" used wrongly again. Also, the string-prefix-p test is too
> > > naïve and unportable. I think file-name-absolute-p is a better
> > > test
> > > (assuming we expect an absolute file name there), perhaps also
> > > augmented by file-accessible-directory-p.
> >
> > I would presume if the directory inaccessible some later commands
> > such
> > as `git checkout` will fail anyway, so no point in adding the
> > `file-
> > accessible-directory-p` check on Emacs side…?
>
> I'm talking about distinguishing between a URL and a local file name.
> Are we guaranteed to get an absolute file name there? If not, how do
> you know that something like "http://foo.bar" cannot be a local file
> name?
Ah, gotcha!
> > > > - (workdir (expand-file-name "repo"))
> > > > + (workdir (if url-is-path url (expand-file-name
> > > > "repo")))
> > >
> > > Not sure about this hunk: why do we not need to expand-file-name
> > > if
> > > URL is not a local directory but a real URL?
> >
> > Idk, that was there 😅
>
> The expand-file-name was there, yes. But why do you think we should
> avoid calling expand-file-name if URL is a local file name?
Ah, sorry, I got that reversed. Yeah, it makes sense calling that for a
local filename. I was wondering why was it there for a URL, which is
partially why I read you wrong.
> > > > - (when (file-exists-p workdir)
> > > > + (when (and (not url-is-path) (file-exists-p workdir))
> > > > (delete-directory workdir t)))))
> > >
> > > Why? Does workdir have different semantics in these two use
> > > cases?
> > > Isn't it the directory where we cloned the repository?
> >
> > When an absolute path is passed as URL, that means the user have
> > cloned
> > the repo, not us.
>
> But you still clone from it into workdir, no? treesit--git-clone-
> repo
> invokes "git clone" in both cases, according to my reading of the
> patch.
No, the `treesit--git-clone-repo` is located on the "else" branch of
the `(if url-is-path`. That is, we do not call it when it's a local
path
next prev parent reply other threads:[~2024-01-19 14:33 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-19 8:08 bug#68579: [PATCH] Support a local repo as URL in treesit-language-source-alist Konstantin Kharlamov
2024-01-19 8:33 ` Eli Zaretskii
2024-01-19 8:57 ` Konstantin Kharlamov
2024-01-19 11:46 ` Eli Zaretskii
2024-01-19 14:33 ` Konstantin Kharlamov [this message]
2024-01-19 15:06 ` Eli Zaretskii
2024-01-19 16:06 ` Konstantin Kharlamov
2024-01-19 16:26 ` Eli Zaretskii
2024-01-20 12:00 ` bug#68579: [PATCH v2] " Konstantin Kharlamov
2024-01-20 12:04 ` Konstantin Kharlamov
2024-01-20 11:56 ` Konstantin Kharlamov
2024-01-27 9:37 ` Eli Zaretskii
2024-01-27 18:53 ` Konstantin Kharlamov
2024-01-27 19:21 ` Eli Zaretskii
2024-02-01 10:06 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=79692782ee323c59388fac26d39dc70aeb525284.camel@yandex.ru \
--to=hi-angel@yandex.ru \
--cc=68579@debbugs.gnu.org \
--cc=casouri@gmail.com \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.