From: Eli Zaretskii <eliz@gnu.org>
To: dick.r.chiang@gmail.com
Cc: 58788@debbugs.gnu.org
Subject: bug#58788: 29.0.50; [PATCH] Respect inhibit-message
Date: Thu, 27 Oct 2022 19:50:50 +0300 [thread overview]
Message-ID: <83ilk5ky6t.fsf@gnu.org> (raw)
In-Reply-To: <87y1t3aa4m.fsf@dick> (dick.r.chiang@gmail.com)
> From: dick.r.chiang@gmail.com
> Date: Tue, 25 Oct 2022 17:03:53 -0400
>
> It's borderline criminal that the echo area gets cleared
> when inhibit-message is true.
No documentation promised that the previous message will not be
cleared when inhibit-message is set. We just avoid displaying new
messages.
We could extend the mechanism to allow it to prevent the clearing as
well, but that would probably mean inhibit-message will have to be a
tristate, because by now it's too late to change what its non-nil
value produces. So we'd need to introduce a special value (not nil
and not t) which will have this effect.
> * doc/lispref/display.texi (Displaying Messages): Revert 164a7eb.
> * lisp/minibuffer.el (clear-minibuffer-message): Revert 164a7eb.
> * src/xdisp.c (message3): Remove errant clear_message() from 2004.
I don't understand what that has to do with the dont-clear-message
thingy. That is about something else: it prevents clearing the
message when there's an input event, like if the user types some key.
I see no reason why we should remove that feature.
> +(ert-deftest xdisp-tests--respect-inhibit-message ()
> + "It's borderline criminal that inhibit-message still clears echo area."
Please keep your contempt for other people out of the patches, if you
want them applied.
next prev parent reply other threads:[~2022-10-27 16:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-25 21:03 bug#58788: 29.0.50; [PATCH] Respect inhibit-message dick.r.chiang
2022-10-26 5:36 ` Stefan Kangas
2022-10-27 16:50 ` Eli Zaretskii [this message]
2022-11-13 17:39 ` Juri Linkov
2022-11-13 18:24 ` dick
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83ilk5ky6t.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=58788@debbugs.gnu.org \
--cc=dick.r.chiang@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.