From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#58788: 29.0.50; [PATCH] Respect inhibit-message Date: Thu, 27 Oct 2022 19:50:50 +0300 Message-ID: <83ilk5ky6t.fsf@gnu.org> References: <87y1t3aa4m.fsf@dick> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14417"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 58788@debbugs.gnu.org To: dick.r.chiang@gmail.com Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Oct 27 18:53:06 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oo67u-0003YG-1n for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 27 Oct 2022 18:53:06 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oo66z-0000lV-1a; Thu, 27 Oct 2022 12:52:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oo66s-0008KI-OI for bug-gnu-emacs@gnu.org; Thu, 27 Oct 2022 12:52:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oo66s-00034j-Dl for bug-gnu-emacs@gnu.org; Thu, 27 Oct 2022 12:52:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oo66s-0002WS-1A for bug-gnu-emacs@gnu.org; Thu, 27 Oct 2022 12:52:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 27 Oct 2022 16:52:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58788 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 58788-submit@debbugs.gnu.org id=B58788.16668894729631 (code B ref 58788); Thu, 27 Oct 2022 16:52:01 +0000 Original-Received: (at 58788) by debbugs.gnu.org; 27 Oct 2022 16:51:12 +0000 Original-Received: from localhost ([127.0.0.1]:59147 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oo664-0002VH-Ck for submit@debbugs.gnu.org; Thu, 27 Oct 2022 12:51:12 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:45670) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oo662-0002V2-Ia for 58788@debbugs.gnu.org; Thu, 27 Oct 2022 12:51:10 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oo65x-0002ye-Aa; Thu, 27 Oct 2022 12:51:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=WqvTjgHeGNGWbcU+gRKtsJAj/FgaRU1FZXzagF42sNk=; b=ZUThMMrcJskD 6KpAYhuhahrYJVV5alipLyX1WZYG/9hjfjKabiUiW+1oE5GtYDz/yRymB3C5n2y9RvRmzrYfEN/vs gClEY2utySKRoT126cI0T0/kQuu0zYUUotWF1y7gEI951Ur0wNwA1LjUOfaomNk6OU2XKSRws3Dbp Qx53993enfXp8ozH5XTRcdFR/6fQ4/dwi6MInjAJn0hiB/XtIMA2n0+QLNOu+o1JIwdbMk+7cI+2l BHfakxWb3JaOHQU/IM6cSU0r1cSb34Z4VrXbjQ37n1NaDIbHOBaxI62wPwhNHW9NfHn2mXZVQnSWD PaxNbZp9pNg2ePYmJ/+SOA==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oo65p-0007Df-Dy; Thu, 27 Oct 2022 12:51:04 -0400 In-Reply-To: <87y1t3aa4m.fsf@dick> (dick.r.chiang@gmail.com) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: "bug-gnu-emacs" Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:246333 Archived-At: > From: dick.r.chiang@gmail.com > Date: Tue, 25 Oct 2022 17:03:53 -0400 > > It's borderline criminal that the echo area gets cleared > when inhibit-message is true. No documentation promised that the previous message will not be cleared when inhibit-message is set. We just avoid displaying new messages. We could extend the mechanism to allow it to prevent the clearing as well, but that would probably mean inhibit-message will have to be a tristate, because by now it's too late to change what its non-nil value produces. So we'd need to introduce a special value (not nil and not t) which will have this effect. > * doc/lispref/display.texi (Displaying Messages): Revert 164a7eb. > * lisp/minibuffer.el (clear-minibuffer-message): Revert 164a7eb. > * src/xdisp.c (message3): Remove errant clear_message() from 2004. I don't understand what that has to do with the dont-clear-message thingy. That is about something else: it prevents clearing the message when there's an input event, like if the user types some key. I see no reason why we should remove that feature. > +(ert-deftest xdisp-tests--respect-inhibit-message () > + "It's borderline criminal that inhibit-message still clears echo area." Please keep your contempt for other people out of the patches, if you want them applied.