all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Yuan Fu <casouri@gmail.com>
Cc: 39179@debbugs.gnu.org
Subject: bug#39179: 27.0.50; [PATCH] Add filter to gdb-mi register buffer
Date: Sun, 02 Feb 2020 17:52:31 +0200	[thread overview]
Message-ID: <83h809htq8.fsf@gnu.org> (raw)
In-Reply-To: <60CA7D7C-F6ED-4BEC-817A-35BCE7E120CB@gmail.com> (message from Yuan Fu on Sun, 2 Feb 2020 09:32:45 -0500)

> From: Yuan Fu <casouri@gmail.com>
> Date: Sun, 2 Feb 2020 09:32:45 -0500
> Cc: 39179@debbugs.gnu.org
> 
> >> I mainly use it to display only the registers I care about, say, all
> >> the *dx registers (rdx, edx, dx) or all the r** registers (rdx, rsi,
> >> etc).
> > 
> > I understand, but why wouldn't a simple defcustom do this job?  A list
> > of registers to display is a simple thing, no?
> 
> My main concern is that defcustom wouldn’t be as convenient as the current one. Right now I only need `f + .*dx` and I’m good to go, whereas defcustom I need to go to customize and configure there, and come back.

Sure, but this convenience is only a significant consideration for a
feature that is supposed to be used very frequently.  I don't think
this is so in this case.

> > Really?  In what way?  I could only understand why you'd like to see
> > FP registers in some programs, but not in others.  But other than
> > that, why would you want to see this or that register?  Are you
> > frequently debugging on the machine language level?
> 
> Honestly I only used this for the bomb lab in my CS course last semester where we need to debug assembly code. So if you think in real life scenarios we don’t really need this _quick_ filtering and customize will cut it. I’m fine with that too.

Good, then let's do it via a defcustom.

> Is your main reason of objection the (unnecessary) complexity of the code?

No, my main reason is to avoid unnecessarily cluttering the UI.

> > Then perhaps we should allow reordering the registers instead of
> > filtering their list, so that registers you want to see are at the
> > beginning?
> 
> That would be more complex that just filtering IMO. 

OK.

Thanks.





  reply	other threads:[~2020-02-02 15:52 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-18 20:51 bug#39179: 27.0.50; [PATCH] Add filter to gdb-mi register buffer Yuan Fu
2020-01-31  9:56 ` Eli Zaretskii
2020-01-31 23:08   ` Yuan Fu
2020-02-01  2:22     ` Yuan Fu
2020-02-01  7:58     ` Eli Zaretskii
2020-02-02 14:32       ` Yuan Fu
2020-02-02 15:52         ` Eli Zaretskii [this message]
2020-08-09 11:57           ` Lars Ingebrigtsen
2020-08-10 18:20             ` Yuan Fu
2021-05-12 15:54               ` Lars Ingebrigtsen
2021-05-19  0:19                 ` Yuan Fu
2021-07-22 12:43                   ` Lars Ingebrigtsen
2021-07-24 17:04                     ` Yuan Fu
2021-07-24 17:11                       ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83h809htq8.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=39179@debbugs.gnu.org \
    --cc=casouri@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.