From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#39179: 27.0.50; [PATCH] Add filter to gdb-mi register buffer Date: Sun, 02 Feb 2020 17:52:31 +0200 Message-ID: <83h809htq8.fsf@gnu.org> References: <7ADCB299-819A-4D1F-A95A-03655C997E57@gmail.com> <83o8ukkkza.fsf@gnu.org> <30AFA53A-2A18-4E6A-A215-F0DEF4FB6B12@gmail.com> <83d0aykac0.fsf@gnu.org> <60CA7D7C-F6ED-4BEC-817A-35BCE7E120CB@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="55390"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 39179@debbugs.gnu.org To: Yuan Fu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Feb 02 16:53:10 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1iyHYc-000EGM-KY for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 02 Feb 2020 16:53:10 +0100 Original-Received: from localhost ([::1]:57276 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iyHYb-0002QW-Ab for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 02 Feb 2020 10:53:09 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48860) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iyHYV-0002QO-CI for bug-gnu-emacs@gnu.org; Sun, 02 Feb 2020 10:53:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iyHYU-0001bI-FS for bug-gnu-emacs@gnu.org; Sun, 02 Feb 2020 10:53:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:34459) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iyHYU-0001bC-CY for bug-gnu-emacs@gnu.org; Sun, 02 Feb 2020 10:53:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iyHYU-0007K0-Aw for bug-gnu-emacs@gnu.org; Sun, 02 Feb 2020 10:53:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 02 Feb 2020 15:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39179 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 39179-submit@debbugs.gnu.org id=B39179.158065877328119 (code B ref 39179); Sun, 02 Feb 2020 15:53:02 +0000 Original-Received: (at 39179) by debbugs.gnu.org; 2 Feb 2020 15:52:53 +0000 Original-Received: from localhost ([127.0.0.1]:40432 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iyHYL-0007JT-GK for submit@debbugs.gnu.org; Sun, 02 Feb 2020 10:52:53 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:39784) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iyHYJ-0007JE-Kq for 39179@debbugs.gnu.org; Sun, 02 Feb 2020 10:52:51 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:52491) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iyHYE-0001Vg-Ef; Sun, 02 Feb 2020 10:52:46 -0500 Original-Received: from [176.228.60.248] (port=4882 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iyHYD-0001Yj-Sy; Sun, 02 Feb 2020 10:52:46 -0500 In-reply-to: <60CA7D7C-F6ED-4BEC-817A-35BCE7E120CB@gmail.com> (message from Yuan Fu on Sun, 2 Feb 2020 09:32:45 -0500) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:175595 Archived-At: > From: Yuan Fu > Date: Sun, 2 Feb 2020 09:32:45 -0500 > Cc: 39179@debbugs.gnu.org > > >> I mainly use it to display only the registers I care about, say, all > >> the *dx registers (rdx, edx, dx) or all the r** registers (rdx, rsi, > >> etc). > > > > I understand, but why wouldn't a simple defcustom do this job? A list > > of registers to display is a simple thing, no? > > My main concern is that defcustom wouldn’t be as convenient as the current one. Right now I only need `f + .*dx` and I’m good to go, whereas defcustom I need to go to customize and configure there, and come back. Sure, but this convenience is only a significant consideration for a feature that is supposed to be used very frequently. I don't think this is so in this case. > > Really? In what way? I could only understand why you'd like to see > > FP registers in some programs, but not in others. But other than > > that, why would you want to see this or that register? Are you > > frequently debugging on the machine language level? > > Honestly I only used this for the bomb lab in my CS course last semester where we need to debug assembly code. So if you think in real life scenarios we don’t really need this _quick_ filtering and customize will cut it. I’m fine with that too. Good, then let's do it via a defcustom. > Is your main reason of objection the (unnecessary) complexity of the code? No, my main reason is to avoid unnecessarily cluttering the UI. > > Then perhaps we should allow reordering the registers instead of > > filtering their list, so that registers you want to see are at the > > beginning? > > That would be more complex that just filtering IMO. OK. Thanks.