From: Eli Zaretskii <eliz@gnu.org>
To: Ihor Radchenko <yantar92@posteo.net>
Cc: 59902@debbugs.gnu.org
Subject: bug#59902: 30.0.50; Image overlay is not updated until the cursor moves to the overlay
Date: Thu, 08 Dec 2022 13:37:30 +0200 [thread overview]
Message-ID: <83h6y62kjp.fsf@gnu.org> (raw)
In-Reply-To: <87zgby87rm.fsf@localhost> (message from Ihor Radchenko on Thu, 08 Dec 2022 11:17:01 +0000)
> From: Ihor Radchenko <yantar92@posteo.net>
> Date: Thu, 08 Dec 2022 11:17:01 +0000
>
> 1. emacs -Q
> 2. M-: (require 'ob-shell)
> 3. Open the following org file
> #+begin_src sh :results graphics file :file /tmp/colour.png
> convert -size 300x300 xc:#002b36 /tmp/colour.png
> #+end_src
> 4. Move point to the source block and C-c C-c yes
> 5. C-c C-x C-v
> 6. Observe the 300x300 image appearing
> 7. Edit the source code to 500x300
> 8. C-c C-c yes
> 9. Image disappears
> 10. C-c C-x C-v
> 11. Observe what appears to be the old 300x300 image
> 12. Move the cursor to the image
> 13. Observe the correct 500x300 appearing while the cursor is on it!!
Is the "convert" part in step 3 necessary to reproduce this? If so,
it's a huge turn-off for me, because I don't have, and won't have,
ImageMagick installed, or anything similar to it. So someone else
will have to investigate this in that case, sorry.
> If I step through the code inserting the image overlays, the wrong (not
> updated) overlay appears in `org-display-inline-images':
Where is this code through which you are stepping?
> (let ((ov (make-overlay
> (org-element-property :begin link)
> (progn
> (goto-char
> (org-element-property :end link))
> (skip-chars-backward " \t")
> (point)))))
> (overlay-put ov 'display image) ;; <- the updated image is correctly displayed
> (overlay-put ov 'face 'default) ;; <- un-updated image is displayed until we move cursor to the overlay
And if you switch the order of the above two lines?
Anyway, it is not reliable to try to deduce what happens when stepping
through the code if the problem is relied to cursor motion or
redisplay, because Edebug changes all of that in radical ways.
Finally, a stab in the dark: the fact that the problem disappears when
you move the cursor might mean that a call to 'redisplay' (or some
other trigger for redisplay to know stuff has changed) is missing
somewhere.
next prev parent reply other threads:[~2022-12-08 11:37 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-08 11:17 bug#59902: 30.0.50; Image overlay is not updated until the cursor moves to the overlay Ihor Radchenko
2022-12-08 11:37 ` Eli Zaretskii [this message]
2022-12-08 11:52 ` Ihor Radchenko
2022-12-08 14:03 ` Eli Zaretskii
2022-12-08 14:10 ` Ihor Radchenko
2022-12-08 18:51 ` Eli Zaretskii
2022-12-08 19:27 ` Ihor Radchenko
2022-12-08 20:24 ` Eli Zaretskii
2022-12-10 9:57 ` Ihor Radchenko
2022-12-10 11:03 ` Eli Zaretskii
2022-12-10 11:10 ` Ihor Radchenko
2022-12-10 14:18 ` Eli Zaretskii
2022-12-11 9:19 ` Ihor Radchenko
2022-12-11 10:23 ` Eli Zaretskii
2022-12-12 8:35 ` Ihor Radchenko
2022-12-12 13:15 ` Eli Zaretskii
2022-12-15 10:24 ` Ihor Radchenko
2022-12-15 10:49 ` Eli Zaretskii
2022-12-15 10:53 ` Ihor Radchenko
2022-12-15 10:58 ` Eli Zaretskii
2022-12-15 11:05 ` Ihor Radchenko
2022-12-15 11:16 ` Eli Zaretskii
2022-12-15 11:20 ` Ihor Radchenko
2022-12-15 13:16 ` Eli Zaretskii
2022-12-15 13:23 ` Ihor Radchenko
2022-12-15 14:25 ` Eli Zaretskii
2022-12-15 14:31 ` Ihor Radchenko
2022-12-08 19:18 ` William Denton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83h6y62kjp.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=59902@debbugs.gnu.org \
--cc=yantar92@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.