From: Eli Zaretskii <eliz@gnu.org>
To: Jim Porter <jporterbugs@gmail.com>
Cc: 59668@debbugs.gnu.org
Subject: bug#59668: 29.0.50; [PATCH] Make 'server-stop-automatically' into a defcustom
Date: Fri, 02 Dec 2022 16:42:21 +0200 [thread overview]
Message-ID: <83a645g94i.fsf@gnu.org> (raw)
In-Reply-To: <072e4903-4166-ce53-236b-86a8f7e05b9f@gmail.com> (message from Jim Porter on Thu, 1 Dec 2022 19:30:03 -0800)
> Date: Thu, 1 Dec 2022 19:30:03 -0800
> Cc: 59668@debbugs.gnu.org
> From: Jim Porter <jporterbugs@gmail.com>
>
> @@ -1805,7 +1814,7 @@ server-save-buffers-kill-terminal
> (t (error "Invalid client frame"))))))
>
> (defun server-stop-automatically--handle-delete-frame (frame)
> - "Handle deletion of FRAME when `server-stop-automatically' is used."
> + "Handle deletion of FRAME when `server-stop-automatically' is `delete-frame'."
> (when server-stop-automatically
> (if (if (and (processp (frame-parameter frame 'client))
> (eq this-command 'save-buffers-kill-terminal))
> @@ -1828,7 +1837,7 @@ server-stop-automatically--handle-delete-frame
> (delete-frame frame)))))
AFAIU, this delete-frame is called after save-buffers-kill-emacs, which is
strange: there will be no Emacs to perform this call after that. What am I
missing?
> + (const :tag "When empty" empty)
"When empty" doesn't explain itself well enough. Can we come up with a
better description?
Otherwise LGTM, thanks.
next prev parent reply other threads:[~2022-12-02 14:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-29 4:23 bug#59668: 29.0.50; [PATCH] Make 'server-stop-automatically' into a defcustom Jim Porter
2022-12-01 17:08 ` Eli Zaretskii
2022-12-01 18:33 ` Jim Porter
2022-12-01 18:41 ` Jim Porter
2022-12-02 3:30 ` Jim Porter
2022-12-02 14:42 ` Eli Zaretskii [this message]
2022-12-07 1:39 ` Jim Porter
2022-12-07 1:49 ` Jim Porter
2022-12-07 12:48 ` Eli Zaretskii
2022-12-08 6:02 ` Jim Porter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83a645g94i.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=59668@debbugs.gnu.org \
--cc=jporterbugs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.