From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#59668: 29.0.50; [PATCH] Make 'server-stop-automatically' into a defcustom Date: Fri, 02 Dec 2022 16:42:21 +0200 Message-ID: <83a645g94i.fsf@gnu.org> References: <155f479d-3bae-c327-47a3-7b58daf912c0@gmail.com> <83mt87gih4.fsf@gnu.org> <072e4903-4166-ce53-236b-86a8f7e05b9f@gmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7560"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 59668@debbugs.gnu.org To: Jim Porter Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Dec 02 15:43:23 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p17G7-0001pw-Jv for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 02 Dec 2022 15:43:23 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p17Fo-0002Io-Eo; Fri, 02 Dec 2022 09:43:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p17Fm-0002Es-TA for bug-gnu-emacs@gnu.org; Fri, 02 Dec 2022 09:43:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p17Fm-00080N-LG for bug-gnu-emacs@gnu.org; Fri, 02 Dec 2022 09:43:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p17Fm-0006BM-Gt for bug-gnu-emacs@gnu.org; Fri, 02 Dec 2022 09:43:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 02 Dec 2022 14:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59668 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 59668-submit@debbugs.gnu.org id=B59668.166999217223756 (code B ref 59668); Fri, 02 Dec 2022 14:43:02 +0000 Original-Received: (at 59668) by debbugs.gnu.org; 2 Dec 2022 14:42:52 +0000 Original-Received: from localhost ([127.0.0.1]:47115 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p17Fc-0006B6-Fu for submit@debbugs.gnu.org; Fri, 02 Dec 2022 09:42:52 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:44908) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p17Fb-0006Az-C4 for 59668@debbugs.gnu.org; Fri, 02 Dec 2022 09:42:51 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p17FW-0007yH-1p; Fri, 02 Dec 2022 09:42:46 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=4s9p6hIR6y2n8883xiW1OGS+5Vr3cM03kSTqv4vOt/0=; b=nWb/BIKe7jf/ 0y5/apo3CqxTmKBCRWzdklJK54xF6ZvfdilhRGPr4v3kWXt0/cv4fnq/VWQRWOb25VPp2tp7BHx7w OyApzc85F7nyAEkIA4777iWnqlTcxzHG5YG70ReWg/DMDgpkEbD3QxVpIYsbMJq0/nKq2dRVEOLVv vHUZUg1Nl5kLOazfeCIhLrPgw1VYT329GPt1ebZfbEdrY0bDXifPxyhlPfFSpT8Wc1yzLix0Cf54T gYskjR41+IOlK30qCozR7Z6pjnbKHDGeJxehmYwCfNwKWRBF51apxD5YE2GVUsLUuvF6uXExmHm3k h31BwOqoaBw8a7NqZYVg9Q==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p17FV-0006B4-8s; Fri, 02 Dec 2022 09:42:45 -0500 In-Reply-To: <072e4903-4166-ce53-236b-86a8f7e05b9f@gmail.com> (message from Jim Porter on Thu, 1 Dec 2022 19:30:03 -0800) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:249753 Archived-At: > Date: Thu, 1 Dec 2022 19:30:03 -0800 > Cc: 59668@debbugs.gnu.org > From: Jim Porter > > @@ -1805,7 +1814,7 @@ server-save-buffers-kill-terminal > (t (error "Invalid client frame")))))) > > (defun server-stop-automatically--handle-delete-frame (frame) > - "Handle deletion of FRAME when `server-stop-automatically' is used." > + "Handle deletion of FRAME when `server-stop-automatically' is `delete-frame'." > (when server-stop-automatically > (if (if (and (processp (frame-parameter frame 'client)) > (eq this-command 'save-buffers-kill-terminal)) > @@ -1828,7 +1837,7 @@ server-stop-automatically--handle-delete-frame > (delete-frame frame))))) AFAIU, this delete-frame is called after save-buffers-kill-emacs, which is strange: there will be no Emacs to perform this call after that. What am I missing? > + (const :tag "When empty" empty) "When empty" doesn't explain itself well enough. Can we come up with a better description? Otherwise LGTM, thanks.