all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Yuan Fu <casouri@gmail.com>
Cc: dmitry@gutov.dev, 62951@debbugs.gnu.org
Subject: bug#62951: 29.0.90; c-ts-mode: Incorrect fontification due to FOR_EACH_TAIL_SAFE
Date: Fri, 28 Apr 2023 08:41:53 +0300	[thread overview]
Message-ID: <838recsgv2.fsf@gnu.org> (raw)
In-Reply-To: <85A2194C-5C67-4AC2-A265-9C20F03FA5B6@gmail.com> (message from Yuan Fu on Thu, 27 Apr 2023 12:56:07 -0700)

> From: Yuan Fu <casouri@gmail.com>
> Date: Thu, 27 Apr 2023 12:56:07 -0700
> Cc: dmitry@gutov.dev,
>  62951@debbugs.gnu.org
> 
> >  c-ts-mode: Cannot load language definition: not-found, ("libtree-sitter-emacs-c" "libtree-sitter-emacs-c.dll"), "No such file or directory"
> > 
> > It looks like your "fake emacs-c language" trick somehow misfires?
> > The value of treesit-load-name-override-list is nil, which is not what
> > you intended, AFAICT?  The only way I can make this work is by
> > manually customizing treesit-load-name-override-list before loading
> > c-ts-mode.
> 
> Duh, sorry, dumb mistake. Fixed.

Thanks.

> > Otherwise, looks quite good; here are some other problems I found:
> > 
> >  . some uses of FOR_EACH_TAIL are not fontified at all; examples:
> >    comp.c, line 2079, fns.c, line 189
> 
> You mean the FOE_EACH_TAIL part isn’t fontified, or the body isn’t fontified? Because the body are always fontified here. FOR_EACH_TAIL itself shouldn’t be fontified since it’s just a macro call and a variable.

I mean the macro itself, FOR_EACH_TAIL.  If it isn't supposed to be
fontified, then why is it fontified at line 856 of comp.c?  It's
inconsistent.  (However, this is a very minor problem, so if fixing
it is difficult, we can leave this alone for now.)

> >  . FOR_EACH_LIVE_BUFFER (data.c, line 1430) is not recognized?
> >  . FOR_EACH_FRAME (keyboard.c, line 1256) is not recognized?
> 
> Didn’t know that they exited :-) Now I have FOR_EACH_TAIL, FOR_EACH_TAIL_SAFE, FOR_EACH_ALIST_VALUE, FOR_EACH_LIVE_BUFFER, FOR_EACH_FRAME.

Great, thanks.

> > This is much better than before already, so I think you should install
> > this on the emacs-29 branch, once you fix the above problems (assuming
> > they are easily fixable).
> 
> Cool, I pushed the change.

Thanks.





  reply	other threads:[~2023-04-28  5:41 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-19 16:40 bug#62951: 29.0.90; c-ts-mode: Incorrect fontification due to FOR_EACH_TAIL_SAFE Eli Zaretskii
2023-04-21 20:37 ` Yuan Fu
2023-04-22  7:17   ` Eli Zaretskii
2023-04-23  0:28     ` Yuan Fu
2023-04-23  6:25       ` Eli Zaretskii
2023-04-24  7:02         ` Yuan Fu
2023-04-23 21:04       ` Dmitry Gutov
2023-04-26 22:19         ` Yuan Fu
2023-04-27  3:14           ` Yuan Fu
2023-04-27 15:03             ` Eli Zaretskii
2023-04-27 19:56               ` Yuan Fu
2023-04-28  5:41                 ` Eli Zaretskii [this message]
2023-04-29 22:55                   ` Yuan Fu
2023-04-30  5:24                     ` Eli Zaretskii
2023-04-27  8:57           ` Dmitry Gutov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=838recsgv2.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=62951@debbugs.gnu.org \
    --cc=casouri@gmail.com \
    --cc=dmitry@gutov.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.