From: Eli Zaretskii <eliz@gnu.org>
To: Helmut Eller <eller.helmut@gmail.com>
Cc: 61151@debbugs.gnu.org
Subject: bug#61151: 30.0.50; sqlite-more-p is confusing
Date: Sun, 29 Jan 2023 20:44:19 +0200 [thread overview]
Message-ID: <834js96v0c.fsf@gnu.org> (raw)
In-Reply-To: <m2bkmhqk29.fsf@gmail.com> (message from Helmut Eller on Sun, 29 Jan 2023 19:20:30 +0100)
> From: Helmut Eller <eller.helmut@gmail.com>
> Cc: 61151@debbugs.gnu.org
> Date: Sun, 29 Jan 2023 19:20:30 +0100
>
> On Sun, Jan 29 2023, Eli Zaretskii wrote:
>
> >> However, sqlite-next seems to return nil once, but then it starts over.
> >
> > This should be easy to fix.
>
> The documentation[1] also says:
>
> SQLITE_DONE means that the statement has finished executing
> successfully. sqlite3_step() should not be called again on this
> virtual machine without first calling sqlite3_reset() to reset the
> virtual machine back to its initial state.
>
> So this would seems like prudent fix.
What is "this"? Signaling an error after sqlite-next returns nil? Or
something else?
> If we don't change the way the API works, then maybe the documentation
> should mention that the proper way to iterate over the results is a bit
> unusual. E.g.:
>
> (let* ((db (sqlite-open))
> (stmt (sqlite-select db "values ('a',0), ('b',1)" nil 'set))
> (rows '())
> row)
> (while (progn (setq row (sqlite-next stmt))
> (sqlite-more-p stmt))
> (push row rows))
> rows)
>
> And perhaps provide a function like sqlite-for-each that hides this
> peculiarity.
Let me think about this.
next prev parent reply other threads:[~2023-01-29 18:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-29 14:52 bug#61151: 30.0.50; sqlite-more-p is confusing Helmut Eller
2023-01-29 15:25 ` Eli Zaretskii
2023-01-29 16:05 ` Helmut Eller
2023-01-29 16:48 ` Eli Zaretskii
2023-01-29 18:20 ` Helmut Eller
2023-01-29 18:44 ` Eli Zaretskii [this message]
2023-01-30 6:57 ` Helmut Eller
2023-02-02 19:49 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=834js96v0c.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=61151@debbugs.gnu.org \
--cc=eller.helmut@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.