From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#61151: 30.0.50; sqlite-more-p is confusing Date: Sun, 29 Jan 2023 20:44:19 +0200 Message-ID: <834js96v0c.fsf@gnu.org> References: <83mt61747b.fsf@gnu.org> <83edrd70dc.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30093"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 61151@debbugs.gnu.org To: Helmut Eller Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jan 29 19:45:18 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pMCg1-0007f5-Vc for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 29 Jan 2023 19:45:18 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pMCfo-0006ap-KA; Sun, 29 Jan 2023 13:45:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pMCfm-0006aR-Ml for bug-gnu-emacs@gnu.org; Sun, 29 Jan 2023 13:45:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pMCfm-0000O3-30 for bug-gnu-emacs@gnu.org; Sun, 29 Jan 2023 13:45:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pMCfl-00077m-Mk for bug-gnu-emacs@gnu.org; Sun, 29 Jan 2023 13:45:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 29 Jan 2023 18:45:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61151 X-GNU-PR-Package: emacs Original-Received: via spool by 61151-submit@debbugs.gnu.org id=B61151.167501787527338 (code B ref 61151); Sun, 29 Jan 2023 18:45:01 +0000 Original-Received: (at 61151) by debbugs.gnu.org; 29 Jan 2023 18:44:35 +0000 Original-Received: from localhost ([127.0.0.1]:45381 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pMCfK-00076s-Tl for submit@debbugs.gnu.org; Sun, 29 Jan 2023 13:44:35 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:42026) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pMCfJ-00076e-7x for 61151@debbugs.gnu.org; Sun, 29 Jan 2023 13:44:33 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pMCfD-0000NL-Ma; Sun, 29 Jan 2023 13:44:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=gFJWWhOg2mw5tyajwa4HiyOa+9/ydvPwG3fQ+wihPAw=; b=kRKG+fiZNSMM lQHbhfj1NpF/FGfCswiLv2QrAf6KSvzuK4X7x9f4rDPNvhJDxhBJVCyrS/HxzcdobNCjDxiWnVMHo kb4X8nCyPoKhR670zV2plvfg2Ka1VwxP68L8UfBu0u3dTmr+LCe8O+tzkt1jjcqF1Y1g5UKb+8O4P MQay8bi5ribnEVrBEhZTfmQIzmtc2xiGr929BXN5Wm+BzzKrOqumuvyFMrgbRejAf1k2xfG+NtOLr EGuHVQOgf0wVkT+2ZU5PVcvF8TTqDd9cc+3gY/Ne6MKsKF8X50fpUOKpufN0eLY75bHurUVaEXDYU kGjCNKj9MJy5aVk5/c5Ukw==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pMCfC-0003kR-W6; Sun, 29 Jan 2023 13:44:27 -0500 In-Reply-To: (message from Helmut Eller on Sun, 29 Jan 2023 19:20:30 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:254375 Archived-At: > From: Helmut Eller > Cc: 61151@debbugs.gnu.org > Date: Sun, 29 Jan 2023 19:20:30 +0100 > > On Sun, Jan 29 2023, Eli Zaretskii wrote: > > >> However, sqlite-next seems to return nil once, but then it starts over. > > > > This should be easy to fix. > > The documentation[1] also says: > > SQLITE_DONE means that the statement has finished executing > successfully. sqlite3_step() should not be called again on this > virtual machine without first calling sqlite3_reset() to reset the > virtual machine back to its initial state. > > So this would seems like prudent fix. What is "this"? Signaling an error after sqlite-next returns nil? Or something else? > If we don't change the way the API works, then maybe the documentation > should mention that the proper way to iterate over the results is a bit > unusual. E.g.: > > (let* ((db (sqlite-open)) > (stmt (sqlite-select db "values ('a',0), ('b',1)" nil 'set)) > (rows '()) > row) > (while (progn (setq row (sqlite-next stmt)) > (sqlite-more-p stmt)) > (push row rows)) > rows) > > And perhaps provide a function like sqlite-for-each that hides this > peculiarity. Let me think about this.