From: Eli Zaretskii <eliz@gnu.org>
To: Stephen Berman <stephen.berman@gmx.net>
Cc: maurooaranda@gmail.com, monnier@iro.umontreal.ca, 64046@debbugs.gnu.org
Subject: bug#64046: 30.0.50; Quoting in customize choice tags
Date: Sat, 24 Jun 2023 09:37:34 +0300 [thread overview]
Message-ID: <83352h1i35.fsf@gnu.org> (raw)
In-Reply-To: <878rc9rfef.fsf@gmx.net> (message from Stephen Berman on Sat, 24 Jun 2023 00:18:48 +0200)
> From: Stephen Berman <stephen.berman@gmx.net>
> Cc: 64046@debbugs.gnu.org, Eli Zaretskii <eliz@gnu.org>, Stefan Monnier
> <monnier@iro.umontreal.ca>
> Date: Sat, 24 Jun 2023 00:18:48 +0200
>
> On Thu, 22 Jun 2023 19:59:26 -0300 Mauro Aranda <maurooaranda@gmail.com> wrote:
>
> > Stephen Berman <stephen.berman@gmx.net> writes:
> >
> >>> Thanks for the feedback. You're right, that patch is too superficial;
> >>> it also fails to do substitution in popup extended menus like the one
> >>> produced by clicking the "State" button, with the result that in the
> >>> item "Revert This Session's Customization" the apostrophe is not
> >>> displayed in the "curve" style. So I revised the patch, attached below,
> >>> to iterate over the elements of each item in ITEMS, and it now appears
> >>> to handle substitution with the "State" button display correctly, both
> >>> as popup menu and as text menu buffer. The latter is the result of
> >>> applying widget--simplify-menu, if I debugged correctly, so I think this
> >>> answers your concerns (though the text menu buffer already shows the
> >>> substitution independently of my patch, due to commit bd3b426ebb). Or
> >>> have I misunderstood your concerns about widget--simplify-menu? If so,
> >>> can you give an example where the new patch fails?
> >>
> >> Just pinging in case this fell under the radar. If there's no response,
> >> what's the next step forward?
> >>
> >> Steve Berman
> >
> > It did, thanks for the ping.
> >
> > Since there's no problem with widget--simplify-menu, the patch looks
> > good to me.
>
> Thanks. So Eli, should this go into master, since it's not a
> regression, or is it ok to install this to the release branch? It does
> seem pretty safe, since it's only applying substitute-command-keys in a
> few more places in widget-choose.
Pleased install on master. The problem is very minor and we have
lived with it for many years, so it can wait a bit more.
Thanks.
next prev parent reply other threads:[~2023-06-24 6:37 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-13 14:02 bug#64046: 30.0.50; Quoting in customize choice tags Stephen Berman
2023-06-13 15:56 ` Eli Zaretskii
2023-06-14 19:51 ` Mauro Aranda
2023-06-14 20:05 ` Mauro Aranda
2023-06-15 11:39 ` Stephen Berman
2023-06-22 20:07 ` Stephen Berman
2023-06-22 22:59 ` Mauro Aranda
2023-06-23 22:18 ` Stephen Berman
2023-06-24 6:37 ` Eli Zaretskii [this message]
2023-06-24 8:50 ` Stephen Berman
2023-07-15 13:20 ` Mauro Aranda
2023-07-20 15:48 ` Stephen Berman
2023-07-20 19:11 ` Mauro Aranda
2023-07-20 19:53 ` Stephen Berman
2023-08-21 12:04 ` Ola x Nilsson
2023-08-21 14:51 ` Mauro Aranda
2023-08-24 12:51 ` Stephen Berman
2023-08-24 13:19 ` Stephen Berman
2023-08-24 20:14 ` Mauro Aranda
2023-08-24 20:54 ` Stephen Berman
2023-08-24 21:58 ` Mauro Aranda
2023-08-25 8:02 ` Ola x Nilsson
2023-08-25 21:50 ` Stephen Berman
2023-08-28 9:33 ` Ola x Nilsson
2023-08-28 13:50 ` Stephen Berman
2023-08-30 15:29 ` Mauro Aranda
2023-08-30 16:29 ` Stephen Berman
2023-08-30 22:33 ` Mauro Aranda
2023-08-30 22:51 ` Stephen Berman
2023-08-30 22:58 ` Mauro Aranda
2023-08-31 5:41 ` Eli Zaretskii
2023-08-31 6:43 ` Stefan Kangas
2023-08-31 15:43 ` Drew Adams
2023-08-31 20:52 ` Stefan Kangas
2023-08-31 22:10 ` Drew Adams
2023-08-31 22:59 ` Stefan Kangas
2023-09-01 1:08 ` Drew Adams
2023-09-01 6:34 ` Eli Zaretskii
2023-09-01 16:17 ` Drew Adams
2023-09-01 23:29 ` Stephen Berman
2023-09-01 23:38 ` Stefan Kangas
2023-09-02 9:49 ` Stephen Berman
2023-09-02 18:59 ` Stefan Kangas
2023-09-02 21:25 ` Stephen Berman
2023-09-02 2:12 ` Drew Adams
2023-09-01 6:16 ` Eli Zaretskii
2023-09-01 16:32 ` Drew Adams
2023-08-24 20:53 ` Stefan Kangas
2023-08-24 21:10 ` Stephen Berman
2023-08-24 21:14 ` Stefan Kangas
2023-08-24 21:41 ` Stephen Berman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83352h1i35.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=64046@debbugs.gnu.org \
--cc=maurooaranda@gmail.com \
--cc=monnier@iro.umontreal.ca \
--cc=stephen.berman@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.