From: Mauro Aranda <maurooaranda@gmail.com>
To: Stephen Berman <stephen.berman@gmx.net>
Cc: Eli Zaretskii <eliz@gnu.org>,
Stefan Monnier <monnier@iro.umontreal.ca>,
64046@debbugs.gnu.org
Subject: bug#64046: 30.0.50; Quoting in customize choice tags
Date: Wed, 14 Jun 2023 17:05:32 -0300 [thread overview]
Message-ID: <47e13491-1654-db22-2f8b-f12195953232@gmail.com> (raw)
In-Reply-To: <837cs7we2z.fsf@gnu.org>
Stephen Berman <stephen.berman@gmx.net> writes:
> 0. emacs -Q
> 1. Evaluate the following defcustom:
> (defcustom my-test "a"
> "Test."
> :type '(choice (string :tag "Use `a'" "a")
> (string :tag "Use `b'" "b")))
> 2. M-x customize-option RET my-test RET
> 3. In the buffer *Customize Option: My Test* note that in the string
> "Use ‘a’" following the "Value Menu" button the quote marks are in
> the "curve" style (‘’).
> 4. Put point on the "Value Menu" button and type RET.
> 5. The buffer " widget-choose" contains these lines:
> 0 = Use ‘a’
> 1 = Use ‘b’
> Note that the quote marks in this buffer are also in the "curve"
> style.
> 6. With the mouse pointer over the "Value Menu" button press mouse-1,
> popping up a menu titled "Choice" containing these items:
> Use `a'
> Use `b'
> Note that the quote marks in this menu are in the "grave" style (`')
> instead of the "curve" style.
>
> The use of the "curve" style in the " widget-choose" buffer is due to
> commit bd3b426ebb7a60045839e97c9da9bfd249fab1f1, but that commit did not
> take popup menus into account. The attached patch does so. Since the
> status quo ante long predates emacs-29 and this is just a stylistic bug,
> I made the patch against master.
>
> In this patch I chose to apply substitute-command-keys just once at the
> beginning of the function `widget-choose', rather than several times
> within the function, but I restricted its application to item tags, so
> other uses of the ITEMS argument should not be affected (and my brief
> testing hasn't found any problem with the patch).
By moving the call to substitute-command-keys to the beginning, extended
menus simplified with widget--simplify-menu don't benefit anymore from
it. Perhaps that won't ever show up as a problem, but I think we should
guard against that.
To do that, maybe widget--simplify-menu can call substitute-command-keys
when it builds the simplified menu.
next prev parent reply other threads:[~2023-06-14 20:05 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-13 14:02 bug#64046: 30.0.50; Quoting in customize choice tags Stephen Berman
2023-06-13 15:56 ` Eli Zaretskii
2023-06-14 19:51 ` Mauro Aranda
2023-06-14 20:05 ` Mauro Aranda [this message]
2023-06-15 11:39 ` Stephen Berman
2023-06-22 20:07 ` Stephen Berman
2023-06-22 22:59 ` Mauro Aranda
2023-06-23 22:18 ` Stephen Berman
2023-06-24 6:37 ` Eli Zaretskii
2023-06-24 8:50 ` Stephen Berman
2023-07-15 13:20 ` Mauro Aranda
2023-07-20 15:48 ` Stephen Berman
2023-07-20 19:11 ` Mauro Aranda
2023-07-20 19:53 ` Stephen Berman
2023-08-21 12:04 ` Ola x Nilsson
2023-08-21 14:51 ` Mauro Aranda
2023-08-24 12:51 ` Stephen Berman
2023-08-24 13:19 ` Stephen Berman
2023-08-24 20:14 ` Mauro Aranda
2023-08-24 20:54 ` Stephen Berman
2023-08-24 21:58 ` Mauro Aranda
2023-08-25 8:02 ` Ola x Nilsson
2023-08-25 21:50 ` Stephen Berman
2023-08-28 9:33 ` Ola x Nilsson
2023-08-28 13:50 ` Stephen Berman
2023-08-30 15:29 ` Mauro Aranda
2023-08-30 16:29 ` Stephen Berman
2023-08-30 22:33 ` Mauro Aranda
2023-08-30 22:51 ` Stephen Berman
2023-08-30 22:58 ` Mauro Aranda
2023-08-31 5:41 ` Eli Zaretskii
2023-08-31 6:43 ` Stefan Kangas
2023-08-31 15:43 ` Drew Adams
2023-08-31 20:52 ` Stefan Kangas
2023-08-31 22:10 ` Drew Adams
2023-08-31 22:59 ` Stefan Kangas
2023-09-01 1:08 ` Drew Adams
2023-09-01 6:34 ` Eli Zaretskii
2023-09-01 16:17 ` Drew Adams
2023-09-01 23:29 ` Stephen Berman
2023-09-01 23:38 ` Stefan Kangas
2023-09-02 9:49 ` Stephen Berman
2023-09-02 18:59 ` Stefan Kangas
2023-09-02 21:25 ` Stephen Berman
2023-09-02 2:12 ` Drew Adams
2023-09-01 6:16 ` Eli Zaretskii
2023-09-01 16:32 ` Drew Adams
2023-08-24 20:53 ` Stefan Kangas
2023-08-24 21:10 ` Stephen Berman
2023-08-24 21:14 ` Stefan Kangas
2023-08-24 21:41 ` Stephen Berman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47e13491-1654-db22-2f8b-f12195953232@gmail.com \
--to=maurooaranda@gmail.com \
--cc=64046@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=stephen.berman@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.