all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* bug#66361: 30.0.50; ede-project-placeholder-cache-file :type doesn't allow nil
@ 2023-10-05 13:23 Mauro Aranda
  2023-10-05 13:28 ` Mauro Aranda
  0 siblings, 1 reply; 3+ messages in thread
From: Mauro Aranda @ 2023-10-05 13:23 UTC (permalink / raw)
  To: 66361

The docstring of ede-project-placeholder-cache-file says the value can
be nil, but :type is file.






^ permalink raw reply	[flat|nested] 3+ messages in thread

* bug#66361: 30.0.50; ede-project-placeholder-cache-file :type doesn't allow nil
  2023-10-05 13:23 bug#66361: 30.0.50; ede-project-placeholder-cache-file :type doesn't allow nil Mauro Aranda
@ 2023-10-05 13:28 ` Mauro Aranda
  2023-10-05 16:13   ` Eli Zaretskii
  0 siblings, 1 reply; 3+ messages in thread
From: Mauro Aranda @ 2023-10-05 13:28 UTC (permalink / raw)
  To: 66361

[-- Attachment #1: Type: text/plain, Size: 39 bytes --]

tags 66361 patch
quit


Patch attached.

[-- Attachment #2: 0001-Fix-a-defcustom-type.patch --]
[-- Type: text/x-patch, Size: 909 bytes --]

From 4193641fe419ef35df3417317588f9dd95508ef9 Mon Sep 17 00:00:00 2001
From: Mauro Aranda <maurooaranda@gmail.com>
Date: Thu, 5 Oct 2023 10:25:52 -0300
Subject: [PATCH] Fix a defcustom :type

* lisp/cedet/ede/base.el (ede-project-placeholder-cache-file): Expand
:type to allow nil.  (Bug#66361)
---
 lisp/cedet/ede/base.el | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lisp/cedet/ede/base.el b/lisp/cedet/ede/base.el
index 305bf599151..c32d2edd7b7 100644
--- a/lisp/cedet/ede/base.el
+++ b/lisp/cedet/ede/base.el
@@ -312,7 +312,8 @@ ede-project-placeholder-cache-file
   "File containing the list of projects EDE has viewed.
 If set to nil, then the cache is not saved."
   :group 'ede
-  :type 'file)
+  :type '(choice (const :tag "Don't save the cache" nil)
+                 file))
 
 (defvar ede-project-cache-files nil
   "List of project files EDE has seen before.")
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* bug#66361: 30.0.50; ede-project-placeholder-cache-file :type doesn't allow nil
  2023-10-05 13:28 ` Mauro Aranda
@ 2023-10-05 16:13   ` Eli Zaretskii
  0 siblings, 0 replies; 3+ messages in thread
From: Eli Zaretskii @ 2023-10-05 16:13 UTC (permalink / raw)
  To: Mauro Aranda; +Cc: 66361-done

> Date: Thu, 5 Oct 2023 10:28:21 -0300
> From: Mauro Aranda <maurooaranda@gmail.com>
> 
> tags 66361 patch
> quit
> 
> 
> Patch attached.

Thanks, installed on the emacs-29 branch, and closing the bug.





^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-10-05 16:13 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-05 13:23 bug#66361: 30.0.50; ede-project-placeholder-cache-file :type doesn't allow nil Mauro Aranda
2023-10-05 13:28 ` Mauro Aranda
2023-10-05 16:13   ` Eli Zaretskii

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.