all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Morgan Smith <Morgan.J.Smith@outlook.com>
Cc: 63913@debbugs.gnu.org
Subject: bug#63913: [PATCH] * lisp/minibuffer.el (minibuffer-completion-help): Only ding when appropriate.
Date: Tue, 06 Jun 2023 14:19:50 +0300	[thread overview]
Message-ID: <831qio4z3d.fsf@gnu.org> (raw)
In-Reply-To: <DM5PR03MB31630368E91DB73AE375F33CC54DA@DM5PR03MB3163.namprd03.prod.outlook.com> (message from Morgan Smith on Mon, 05 Jun 2023 15:09:02 -0400)

> From: Morgan Smith <Morgan.J.Smith@outlook.com>
> Cc: 63913@debbugs.gnu.org
> Date: Mon, 05 Jun 2023 15:09:02 -0400
> 
> emacs -Q
> (setopt completion-auto-help 'visible)
> (debug-on-entry 'ding) ;; just so we know when it dings
> 
> `M-x eshell` then spam TAB until the completion buffer pops up.  Now
> type in enough to select a unique completion.  I'm completing
> `eshell-command` so I'll make the minibuffer look like 'eshell-comman'.
> 
> Now press one final TAB to select the only available completion.  It
> should ding.

I cannot reproduce this, in the latest build from the emacs-29 branch
(what will soon become Emacs 29.1).  In which version of Emacs do you
see this, and on what OS?

> Also that situation doesn't respect completion-fail-discreetly if you
> where to type in a failing completion before the final TAB press.

Recipe, please.





  reply	other threads:[~2023-06-06 11:19 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-05 17:50 bug#63913: [PATCH] * lisp/minibuffer.el (minibuffer-completion-help): Only ding when appropriate Morgan Smith
2023-06-05 18:50 ` Eli Zaretskii
2023-06-05 19:09   ` Morgan Smith
2023-06-06 11:19     ` Eli Zaretskii [this message]
2023-06-06 19:08       ` Morgan Smith
2023-06-08  9:59         ` Eli Zaretskii
2023-06-08 16:54           ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-06-10  9:13             ` Eli Zaretskii
2023-06-10 17:34               ` Morgan Smith
2023-06-10 17:56                 ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=831qio4z3d.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=63913@debbugs.gnu.org \
    --cc=Morgan.J.Smith@outlook.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.