From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#63913: [PATCH] * lisp/minibuffer.el (minibuffer-completion-help): Only ding when appropriate. Date: Tue, 06 Jun 2023 14:19:50 +0300 Message-ID: <831qio4z3d.fsf@gnu.org> References: <834jnl4ub9.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37836"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 63913@debbugs.gnu.org To: Morgan Smith Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jun 06 13:20:18 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q6Uja-0009cb-44 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 06 Jun 2023 13:20:18 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q6UjN-0007Sc-G9; Tue, 06 Jun 2023 07:20:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q6UjL-0007Rs-Ak for bug-gnu-emacs@gnu.org; Tue, 06 Jun 2023 07:20:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q6UjK-0002bs-Uu for bug-gnu-emacs@gnu.org; Tue, 06 Jun 2023 07:20:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q6UjK-0004VX-FP for bug-gnu-emacs@gnu.org; Tue, 06 Jun 2023 07:20:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 06 Jun 2023 11:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63913 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 63913-submit@debbugs.gnu.org id=B63913.168605040017316 (code B ref 63913); Tue, 06 Jun 2023 11:20:02 +0000 Original-Received: (at 63913) by debbugs.gnu.org; 6 Jun 2023 11:20:00 +0000 Original-Received: from localhost ([127.0.0.1]:51056 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q6UjI-0004VD-86 for submit@debbugs.gnu.org; Tue, 06 Jun 2023 07:20:00 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:34434) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q6UjE-0004Uw-Nl for 63913@debbugs.gnu.org; Tue, 06 Jun 2023 07:19:58 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q6Uj8-0002V8-Sy; Tue, 06 Jun 2023 07:19:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=2sAzyIQfJyWR455NijY5wdzyYwVcxw88HyZ2H5uLEjw=; b=hSvOEvnHe6RD oxzfo2be57ohKs5wcUhELdBpHMzDv1J7Hs/k+l56MXHA36g47H2qaw6wYScuZcLEKPk+t5WwkJ4lM liw4xPfbdlikqLyvqILlk03KA8o6DT6QQYCHNGu+R1VurBWkQBYRMPMZ4tRBFdKMHto5o+QmbmvUp nTO9PJrf8YtcphL/tEMJXWWwhzcySckNFi9V9h0Q90N7uqKNF5EOeoEtoq4XX0Tw6JsNNmoYLRxaN RxkChCBwIOZjHQs6hQlMQNDAkNYdtM4dAtwz3D/zp4AfkOxNxuZPUP96qViiWd6RLZM6++0D19x4Q dfUoV6e0Sz1GLumnrgTGkA==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q6Uj8-0007d8-8h; Tue, 06 Jun 2023 07:19:50 -0400 In-Reply-To: (message from Morgan Smith on Mon, 05 Jun 2023 15:09:02 -0400) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:263047 Archived-At: > From: Morgan Smith > Cc: 63913@debbugs.gnu.org > Date: Mon, 05 Jun 2023 15:09:02 -0400 > > emacs -Q > (setopt completion-auto-help 'visible) > (debug-on-entry 'ding) ;; just so we know when it dings > > `M-x eshell` then spam TAB until the completion buffer pops up. Now > type in enough to select a unique completion. I'm completing > `eshell-command` so I'll make the minibuffer look like 'eshell-comman'. > > Now press one final TAB to select the only available completion. It > should ding. I cannot reproduce this, in the latest build from the emacs-29 branch (what will soon become Emacs 29.1). In which version of Emacs do you see this, and on what OS? > Also that situation doesn't respect completion-fail-discreetly if you > where to type in a failing completion before the final TAB press. Recipe, please.