From: Jim Porter <jporterbugs@gmail.com>
To: Stefan Kangas <stefankangas@gmail.com>
Cc: "Trent W. Buck" <trentbuck@gmail.com>,
Philip Kaludercic <philipk@posteo.net>,
gregory@heytings.org, Eli Zaretskii <eliz@gnu.org>,
62370-done@debbugs.gnu.org
Subject: bug#62370: 28.1; sieve-mode: faces should inherit from font-lock-X-face faces
Date: Mon, 4 Sep 2023 21:43:25 -0700 [thread overview]
Message-ID: <811fbf9b-0710-3558-d955-443df764426f@gmail.com> (raw)
In-Reply-To: <CADwFkmkSKLP5xoFkAYa40tY1yP=1n6FFoF_16fv3fQ2A0HaNRg@mail.gmail.com>
On 9/3/2023 3:30 AM, Stefan Kangas wrote:
> Jim Porter <jporterbugs@gmail.com> writes:
>
>> I agree that we shouldn't be changing defaults arbitrarily, but as I found when
>> looking at the face definitions, we could make this change in a way where it
>> just simplifies the job for theme authors but doesn't cause a noticeable change
>> in most cases.
>>
>> Does that sound ok? If not, then I think we can just close this.
>
> I think the solution that you proposed makes sense: it wouldn't break
> anything, and it would make sieve-mode look better for many users.
I tried my proposal out just to be safe and it does actually change the
appearance in a few cases with the default theme, but I think it's for
the better:
1. If you're using a color TTY, sieve-mode picks some very simple colors
("blue", "magenta", and "cyan"). Normally that's fine, since it uses
whatever your terminal's color palette uses for those basic ANSI colors.
However, if you have a terminal that can display 24-bit colors, sieve's
choices become really bad: it's no longer "the blue you've configured
for your terminal theme that looks nice", but just regular blue
(#0000ee), which on my terminal is almost unreadable.
2. The font-lock faces also feature slight tweaks to their colors when
your system supports at least 88 colors. This is only really noticeable
if you look closely though.
As such, I've pushed this to the master branch as f08684ab39d. Closing
this now. (Of course, if this *does* cause some problems, we can revisit
this.)
next prev parent reply other threads:[~2023-09-05 4:43 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-22 5:41 bug#62370: 28.1; sieve-mode: faces should inherit from font-lock-X-face faces Trent W. Buck
2023-03-22 14:49 ` Eli Zaretskii
2023-03-22 20:10 ` Gregory Heytings
2023-03-22 21:22 ` Jim Porter
2023-03-23 1:05 ` Trent W. Buck
2023-03-23 6:58 ` Eli Zaretskii
2023-03-23 7:03 ` Trent W. Buck
2023-03-23 7:25 ` Eli Zaretskii
2023-03-23 16:11 ` Jim Porter
2023-09-03 10:30 ` Stefan Kangas
2023-09-03 11:04 ` Philip Kaludercic
2023-09-05 4:43 ` Jim Porter [this message]
2023-09-05 12:01 ` Eli Zaretskii
2023-09-05 15:52 ` Jim Porter
2023-09-05 16:17 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=811fbf9b-0710-3558-d955-443df764426f@gmail.com \
--to=jporterbugs@gmail.com \
--cc=62370-done@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=gregory@heytings.org \
--cc=philipk@posteo.net \
--cc=stefankangas@gmail.com \
--cc=trentbuck@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.