From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.bugs Subject: bug#62370: 28.1; sieve-mode: faces should inherit from font-lock-X-face faces Date: Mon, 4 Sep 2023 21:43:25 -0700 Message-ID: <811fbf9b-0710-3558-d955-443df764426f@gmail.com> References: <875yatpclo.fsf@gmail.com> <83y1no6dtd.fsf@gnu.org> <13910d348d640c50ebdc@heytings.org> <83jzz854zi.fsf@gnu.org> <81a938c7-3a11-5327-9814-b55a9936f195@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22241"; mail-complaints-to="usenet@ciao.gmane.io" Cc: "Trent W. Buck" , Philip Kaludercic , gregory@heytings.org, Eli Zaretskii , 62370-done@debbugs.gnu.org To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Sep 05 06:44:23 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qdNvK-0005d6-Pb for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 05 Sep 2023 06:44:22 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qdNv1-0004WC-QI; Tue, 05 Sep 2023 00:44:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qdNv0-0004Vb-8X for bug-gnu-emacs@gnu.org; Tue, 05 Sep 2023 00:44:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qdNuz-0007s3-UW for bug-gnu-emacs@gnu.org; Tue, 05 Sep 2023 00:44:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qdNv0-0006F3-4z for bug-gnu-emacs@gnu.org; Tue, 05 Sep 2023 00:44:02 -0400 Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Tue, 05 Sep 2023 04:44:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 62370 X-GNU-PR-Package: emacs Mail-Followup-To: 62370@debbugs.gnu.org, jporterbugs@gmail.com, trentbuck@gmail.com Original-Received: via spool by 62370-done@debbugs.gnu.org id=D62370.169388901423949 (code D ref 62370); Tue, 05 Sep 2023 04:44:01 +0000 Original-Received: (at 62370-done) by debbugs.gnu.org; 5 Sep 2023 04:43:34 +0000 Original-Received: from localhost ([127.0.0.1]:53142 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qdNuY-0006ED-3j for submit@debbugs.gnu.org; Tue, 05 Sep 2023 00:43:34 -0400 Original-Received: from mail-pj1-x102e.google.com ([2607:f8b0:4864:20::102e]:51659) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qdNuV-0006Dz-U1 for 62370-done@debbugs.gnu.org; Tue, 05 Sep 2023 00:43:33 -0400 Original-Received: by mail-pj1-x102e.google.com with SMTP id 98e67ed59e1d1-26fe4997871so877943a91.3 for <62370-done@debbugs.gnu.org>; Mon, 04 Sep 2023 21:43:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693889006; x=1694493806; darn=debbugs.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=u3bXJS7bxcdfgESBxd/065C6DoaGGrrhqfPA7IFIPDM=; b=R8ZKlKE1qcetu0A4iZ3yD5cRntKjpiswpe90gnuRE/b4WWjJyfTLuKOiKqY4Vy5gz5 3M3NzvckAbnFbHzL1No687PNBuWPvfRRwEk7Wmlym4UKqUmdDXUCxR/vU0UX9Mkuntmn DdMqejzzC4YGPajBglalm/UzeZgGYCtNdl8CWUMUqlbrBkGLamS7IQi7xHm1Z8cPokFc JYdhaIXg2PMll+RHCZqzOWm1333T6GMWbTeOTBX2JNjMmCi/vpV/dkTlDSTaT92xCfiB 7MEZ8OTgiW9qkn1bZEP84gPsPT9cKsF7swfsa08822I36WO4kuEd2i6nwy6K8soAbhYH 3eVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693889006; x=1694493806; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=u3bXJS7bxcdfgESBxd/065C6DoaGGrrhqfPA7IFIPDM=; b=OeQeQmbDCvWp5hWaVAF4IgU6nKcaK1x3Pac4RO1omv9UUq3ynetmscXYnF5ptKBYVL YhqaOyivSgyHmo8M66FeCx6rrxNmGm5j/vIiQCcu1mL/8Re6VOjElTr+9uTTlpv8Dc3u YpIjCCm3y61kKU3FrfnrTJ5U4+hrKKrYnErhb2yGtl54tS3o51i0DsDLQm34moy62AN1 nWhabnx4+mmLgATBVg0tlk8zC3iAbnLxmT1vSatFpj8HillfCWddYqXVU/Qmq4maJcbg w/+xLejncEICXNSDeHzXu8IR66pL2eoDgNn8WFN2T0wYv5ZydAC/bxB+lv9Vc4Nw0z+6 vLxQ== X-Gm-Message-State: AOJu0Yys8SaoZ+6TkUzPxPUSlM0QGX6D1rsIJk7ybkk3qImIy698Q8aO F6G7rusJwLW7ybum7TJ1aM0= X-Google-Smtp-Source: AGHT+IEFfnJAzuQcAK8kLkTeAa1j1VGU5Bmdu949iCdx8MX5ixWi51aDOp3r5A5kA0f4bJscw+dEfg== X-Received: by 2002:a17:90a:b00b:b0:268:15dd:c5c7 with SMTP id x11-20020a17090ab00b00b0026815ddc5c7mr7939992pjq.40.1693889005648; Mon, 04 Sep 2023 21:43:25 -0700 (PDT) Original-Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id j16-20020a17090a061000b002676e961261sm10435192pjj.1.2023.09.04.21.43.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 04 Sep 2023 21:43:25 -0700 (PDT) Content-Language: en-US In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:269329 Archived-At: On 9/3/2023 3:30 AM, Stefan Kangas wrote: > Jim Porter writes: > >> I agree that we shouldn't be changing defaults arbitrarily, but as I found when >> looking at the face definitions, we could make this change in a way where it >> just simplifies the job for theme authors but doesn't cause a noticeable change >> in most cases. >> >> Does that sound ok? If not, then I think we can just close this. > > I think the solution that you proposed makes sense: it wouldn't break > anything, and it would make sieve-mode look better for many users. I tried my proposal out just to be safe and it does actually change the appearance in a few cases with the default theme, but I think it's for the better: 1. If you're using a color TTY, sieve-mode picks some very simple colors ("blue", "magenta", and "cyan"). Normally that's fine, since it uses whatever your terminal's color palette uses for those basic ANSI colors. However, if you have a terminal that can display 24-bit colors, sieve's choices become really bad: it's no longer "the blue you've configured for your terminal theme that looks nice", but just regular blue (#0000ee), which on my terminal is almost unreadable. 2. The font-lock faces also feature slight tweaks to their colors when your system supports at least 88 colors. This is only really noticeable if you look closely though. As such, I've pushed this to the master branch as f08684ab39d. Closing this now. (Of course, if this *does* cause some problems, we can revisit this.)