From: "Jostein Kjønigsen" <jostein@secure.kjonigsen.net>
To: 59897@debbugs.gnu.org, Yuan Fu <casouri@gmail.com>,
Theodor Thornhill <theo@thornhill.no>
Subject: bug#59897: Acknowledgement (29.0.60; csharp-ts-mode: variable-name fontified as method when invoking method with generic type-argument.)
Date: Thu, 8 Dec 2022 11:09:08 +0100 [thread overview]
Message-ID: <7498aef6-892b-48a3-2214-775232501489@secure.kjonigsen.net> (raw)
In-Reply-To: <handler.59897.B.167049179324261.ack@debbugs.gnu.org>
[-- Attachment #1.1: Type: text/plain, Size: 819 bytes --]
And here's the patch to fix it.
*Jostein Kjønigsen*
jostein.kjønigsen.no <https://jostein.kjønigsen.no>
jostein@kjonigsen.net - jostein@gmail.com
On 08.12.2022 10:30, GNU bug Tracking System wrote:
> Thank you for filing a new bug report with debbugs.gnu.org.
>
> This is an automatically generated reply to let you know your message
> has been received.
>
> Your message is being forwarded to the package maintainers and other
> interested parties for their attention; they will reply in due course.
>
> Your message has been sent to the package maintainer(s):
> bug-gnu-emacs@gnu.org
>
> If you wish to submit further information on this problem, please
> send it to59897@debbugs.gnu.org.
>
> Please do not send mail tohelp-debbugs@gnu.org unless you wish
> to report a problem with the Bug-tracking system.
>
[-- Attachment #1.2: Type: text/html, Size: 1676 bytes --]
[-- Attachment #2: 0001-lisp-progmodes-csharp-mode.el-improve-fontification-.patch --]
[-- Type: text/x-patch, Size: 1508 bytes --]
From ab73c1ea068538e79b06012b912c02b0e961b841 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jostein=20Kj=C3=B8nigsen?= <jostein@kjonigsen.net>
Date: Thu, 8 Dec 2022 11:07:15 +0100
Subject: [PATCH] lisp/progmodes/csharp-mode.el: improve fontification in
csharp-ts-mode
Fixes highlighting of generic methods like the one below:
instance.MethodWithTypeArguments<Type>(...);
InClassMethodWithTypeArguments<Type>(...);
---
lisp/progmodes/csharp-mode.el | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/lisp/progmodes/csharp-mode.el b/lisp/progmodes/csharp-mode.el
index 82e3bc0d541..12e45272551 100644
--- a/lisp/progmodes/csharp-mode.el
+++ b/lisp/progmodes/csharp-mode.el
@@ -791,7 +791,15 @@ csharp-ts-mode--font-lock-settings
(invocation_expression
(identifier) @font-lock-function-name-face)
(invocation_expression
- (member_access_expression (identifier) @font-lock-function-name-face))
+ (member_access_expression
+ expression: (identifier) @font-lock-variable-name-face))
+ (invocation_expression
+ function: [(generic_name (identifier)) @font-lock-function-name-face
+ (generic_name (type_argument_list
+ ["<"] @font-lock-bracket-face
+ (identifier) @font-lock-type-face
+ [">"] @font-lock-bracket-face)
+ )])
(catch_declaration
((identifier) @font-lock-type-face))
--
2.34.1
next prev parent reply other threads:[~2022-12-08 10:09 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-08 9:29 bug#59897: 29.0.60; csharp-ts-mode: variable-name fontified as method when invoking method with generic type-argument Jostein Kjønigsen
[not found] ` <handler.59897.B.167049179324261.ack@debbugs.gnu.org>
2022-12-08 10:09 ` Jostein Kjønigsen [this message]
2022-12-08 10:12 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-12-08 10:52 ` Jostein Kjønigsen
2022-12-08 11:12 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-12-08 11:31 ` Jostein Kjønigsen
2022-12-09 20:57 ` Jostein Kjønigsen
2022-12-09 21:12 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-12-12 7:58 ` Jostein Kjønigsen
2022-12-12 22:19 ` Yuan Fu
2022-12-14 18:49 ` Jostein Kjønigsen
2022-12-14 19:43 ` Yuan Fu
2022-12-14 21:45 ` Jostein Kjønigsen
2022-12-14 22:34 ` Yuan Fu
2022-12-09 21:05 ` Yuan Fu
2022-12-09 21:11 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-12-09 21:07 ` Yuan Fu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7498aef6-892b-48a3-2214-775232501489@secure.kjonigsen.net \
--to=jostein@secure.kjonigsen.net \
--cc=59897@debbugs.gnu.org \
--cc=casouri@gmail.com \
--cc=theo@thornhill.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.