From: Dmitry Gutov <dgutov@yandex.ru>
To: Juri Linkov <juri@linkov.net>
Cc: Zhu Zihao <cjpeople2013@gmail.com>,
Lars Ingebrigtsen <larsi@gnus.org>,
Theodor Thornhill <theo@thornhill.no>,
41572@debbugs.gnu.org
Subject: bug#41572: 28.0.50; [PATCH] Support plain project marked with file .emacs-project
Date: Mon, 11 Oct 2021 03:40:47 +0300 [thread overview]
Message-ID: <564eb0ed-21c0-f298-a7e9-30d7caf7517f@yandex.ru> (raw)
In-Reply-To: <87v925f6ee.fsf@mail.linkov.net>
On 10.10.2021 19:47, Juri Linkov wrote:
>>> Then maybe the backend could be named 'project-file'
>>> since a special file defines the project root.
>>
>> That's a little more meaningful, though too close to
>> 'project-files'. 'project-markered' or 'project-markerfile' would probably
>> be less ambiguous.
>
> In 'project-filemarker' I misread "filemarker" as "filmmaker" :-)
Right. :-)
> Another possible name would be "fileroot".
Also sounds more like a method than a project type name.
Maybe project-markered or project-marked, or project-dominated (along
the lines of 'locate-dominating-file'?). Or something noncommittal like
project-dirtee.
But all of those sounds like one could put them at any position in
project-find-functions, which project-fallback explicitly discourages.
>> Suppose somebody puts it before 'vc' to use if for a purpose we did not
>> design it for: make sure that some subproject 'foo' in their monorepo is
>> considered a separate project. 'foo/Makefile' exists, so they add
>> "Makefile" to project-fallback-markers, and it kind of seems to work.
>
> There are two contradictory needs:
>
> 1. When a marker list contains both ".dir-locals.el" and "Makefile",
> it should ignore Makefile files in vc-based project subdirs, e.g.
> emacs/lisp/Makefile, etc.
Right. That says project-try-fallback going after project-try-vc is a
good thing.
> 2. OTOH, I often type 'C-x p g' to search all gems of the same
> ruby version in e.g. ~/.rbenv/versions/2.7.4/lib/ruby/gems
> But it finds ~/.rbenv/.git and tries to search all ruby versions.
> I could manually add .dir-locals.el only to a particular version's
> subdir.
I'm using this setup, FWIW:
(defun project-try-gem (dir)
(when (string-match "/\\.rbenv/versions/.*/gems/.*/gems/[^/]+/" dir)
(cons 'rubygem
(substring dir 0 (match-end 0)))))
(cl-defmethod project-root ((project (head rubygem)))
(cdr project))
(with-eval-after-load 'project
(add-hook 'project-find-functions #'project-try-gem))
Which avoids the whole directory-walking routine, probably saving on a
number of CPU cycles.
> But how to override ~/.rbenv/.git? Maybe by changing
> the order of backends in project-find-functions?
> Then the fallback won't be the last backend anymore.
> Also the backend priorities will be changed globally
> for all other projects, and 'C-x p g' in emacs/lisp
> will find emacs/lisp/Makefile to override emacs/.git.
If we keep the same tool to ensure the priorities (order of functions in
project-try-vc), that would seem like we should use two different
backends for these two different purposes.
Say, the first one would be called project-dominating, and the other one
- still project-fallback.
project-find-functions will be
'(project-try-dominating project-try-vc project-try-fallback
Alternatively, one backend could combine these, but it would have, like,
configurable logic with two different sets of predicates -- one
universal (whether the file is inside a VCS repo or not), and another
for when the file is strictly outside of VCS repos. But that sounds
trickier, both to configure and to understand. Also, it seems like with
this approach the backend *should* ignore the .gitignore entires, which
is fine for .rbenv/versions/.*/gems, but it's bound not to work for some
other purposes some users are going to try to use it for.
So, since I don't know of any other use cases for the project-dominating
code path rather than Ruby gems inside ~/.rbenv, I figured not to try to
solve this use case yet. But we can catalogue similar use cases (maybe
other versions switchers, for Ruby and other languages?; not sure if
installed libraries for other languages also fit this approach) and add
another backend for them later. Help welcome, of course.
next prev parent reply other threads:[~2021-10-11 0:40 UTC|newest]
Thread overview: 89+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-28 3:32 bug#41572: 28.0.50; [PATCH] Support plain project marked with file .emacs-project Zhu Zihao
2020-05-28 7:42 ` Philip K.
2020-05-28 11:20 ` Zihao Zhu
2020-05-28 12:24 ` Philip K.
2020-06-03 11:04 ` Basil L. Contovounesios
2020-05-28 11:27 ` Zhu Zihao
2020-05-28 12:35 ` Dmitry Gutov
2020-05-28 15:46 ` Zihao Zhu
2020-05-28 19:58 ` Dmitry Gutov
2020-05-29 4:34 ` Zihao Zhu
2020-05-29 7:11 ` Philip K.
2020-05-29 13:58 ` Dmitry Gutov
2020-06-02 23:40 ` Juri Linkov
2020-06-05 19:02 ` Dmitry Gutov
2020-06-05 19:22 ` Theodor Thornhill
2020-06-05 23:11 ` Dmitry Gutov
2020-06-06 8:48 ` Theodor Thornhill
2020-06-06 11:15 ` Dmitry Gutov
2020-06-06 11:53 ` Theodor Thornhill
2020-06-06 12:17 ` Dmitry Gutov
2020-06-06 13:37 ` Theodor Thornhill
2020-07-20 20:55 ` Dmitry Gutov
2020-10-01 3:11 ` Lars Ingebrigtsen
2021-09-25 23:13 ` Dmitry Gutov
2021-09-26 6:38 ` Lars Ingebrigtsen
2021-10-03 18:06 ` Juri Linkov
2021-10-05 2:03 ` Dmitry Gutov
2021-10-05 2:08 ` Dmitry Gutov
2021-10-05 6:52 ` Juri Linkov
2021-10-05 12:42 ` Dmitry Gutov
2021-10-05 16:32 ` Juri Linkov
2021-10-06 7:21 ` Juri Linkov
2021-10-06 16:29 ` Juri Linkov
2021-10-06 21:16 ` Dmitry Gutov
2021-10-06 21:13 ` Dmitry Gutov
2021-10-07 7:17 ` Juri Linkov
2021-10-07 13:41 ` Dmitry Gutov
2021-10-10 16:47 ` Juri Linkov
2021-10-11 0:40 ` Dmitry Gutov [this message]
2021-10-05 14:39 ` Nikolay Kudryavtsev
2021-10-05 15:03 ` Dmitry Gutov
2021-10-05 15:21 ` Nikolay Kudryavtsev
2021-10-05 16:56 ` Dmitry Gutov
2021-10-05 18:19 ` Nikolay Kudryavtsev
2021-10-06 0:11 ` Dmitry Gutov
2021-10-06 14:09 ` Nikolay Kudryavtsev
2021-10-07 2:27 ` Dmitry Gutov
2021-10-07 13:08 ` Nikolay Kudryavtsev
2021-10-08 2:12 ` Dmitry Gutov
2021-10-08 16:24 ` Nikolay Kudryavtsev
2021-10-11 1:57 ` Dmitry Gutov
2021-10-11 18:05 ` Nikolay Kudryavtsev
2021-10-17 2:48 ` Dmitry Gutov
2021-10-17 11:52 ` Nikolay Kudryavtsev
2021-09-26 0:22 ` Dmitry Gutov
2022-11-26 1:49 ` Dmitry Gutov
2022-11-26 7:47 ` Eli Zaretskii
2022-11-26 13:22 ` Dmitry Gutov
2022-11-26 14:27 ` Eli Zaretskii
2022-11-27 1:08 ` Dmitry Gutov
2022-11-27 6:46 ` Eli Zaretskii
2022-11-27 14:10 ` Dmitry Gutov
2022-11-27 14:27 ` Eli Zaretskii
2022-11-27 15:51 ` Dmitry Gutov
2022-11-27 16:43 ` Eli Zaretskii
2022-11-27 21:41 ` Dmitry Gutov
2022-11-28 11:58 ` Eli Zaretskii
2022-11-28 12:30 ` Dmitry Gutov
2022-11-28 13:22 ` Eli Zaretskii
2022-11-28 14:29 ` Dmitry Gutov
2022-11-28 14:49 ` Eli Zaretskii
2022-11-28 15:31 ` Dmitry Gutov
2022-11-28 16:51 ` Eli Zaretskii
2022-11-30 2:26 ` Dmitry Gutov
2022-11-30 13:29 ` Eli Zaretskii
2022-11-30 18:52 ` Dmitry Gutov
2022-11-30 20:32 ` Eli Zaretskii
2022-11-30 20:43 ` Dmitry Gutov
2022-12-01 2:19 ` Dmitry Gutov
2022-12-01 6:02 ` Eli Zaretskii
2022-12-01 15:08 ` Dmitry Gutov
2022-11-26 9:52 ` João Távora
2022-11-26 12:29 ` Dmitry Gutov
2022-11-26 19:23 ` João Távora
2022-11-27 16:09 ` Dmitry Gutov
2022-11-29 9:46 ` João Távora
2022-11-29 18:51 ` Dmitry Gutov
2022-11-29 22:06 ` João Távora
2022-11-30 0:10 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=564eb0ed-21c0-f298-a7e9-30d7caf7517f@yandex.ru \
--to=dgutov@yandex.ru \
--cc=41572@debbugs.gnu.org \
--cc=cjpeople2013@gmail.com \
--cc=juri@linkov.net \
--cc=larsi@gnus.org \
--cc=theo@thornhill.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.