From: Yuan Fu <casouri@gmail.com>
To: Theodor Thornhill <theo@thornhill.no>
Cc: 59251@debbugs.gnu.org, done-59251@debbugs.gnu.org
Subject: bug#59251: Acknowledgement (29.0.50; Fix-some-inconsistencies-in-ts-modes)
Date: Mon, 14 Nov 2022 01:25:09 -0800 [thread overview]
Message-ID: <54E210C8-9CE7-49AE-811E-BF367D070031@gmail.com> (raw)
In-Reply-To: <877czy2ex4.fsf@thornhill.no>
> On Nov 13, 2022, at 11:06 PM, Theodor Thornhill <theo@thornhill.no> wrote:
>
> Yuan Fu <casouri@gmail.com> writes:
>
>>> On Nov 13, 2022, at 3:01 PM, Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors <bug-gnu-emacs@gnu.org> wrote:
>>>
>>> Theodor Thornhill <theo@thornhill.no> writes:
>>>
>>>> Added a few more finishes.
>>>
>>> Aaand another. Last one for now. I promise…
>>
>> Cool! Some comments:
>>
>> +(defcustom c-ts-mode-font-lock-feature-list
>> + '((comment preprocessor operator constant string literal keyword)
>> + (type definition expression statement)
>> + ())
>> + "Language constructs to font-lock.
>> +
>> +See `treesit-font-lock-feature-list' for description of how to
>> +use this variable. Supported features are as defined in
>> +`c-ts-mode--font-lock-settings'."
>> + :version "29.1"
>> + :type 'list
>> + :safe 'listp
>> + :group 'c)
>> +
>>
>> I think Stefan M’s opinion is to make feature-list private, and let
>> users add/remove features. Right now they can add/remove features with
>> treesit-recompute-feature-list. I guess we can keep them as defvar’s
>> for now, so people as the option to redefine this list should they
>> want to. (One argument against having them as custom options is that,
>> if a user sets it as a custom option, they will miss out on future
>> changes to this variable.)
>>
>>
>> + (setq-local comment-style c-ts-mode-comment-style)
>>
>> Why don’t we let users set comment style themselves? Does cc-mode have a similar variable?
>>
>
> You have a point. Simplified the patch.
>
> Theo
>
> <0001-Fix-some-inconsistencies-in-ts-modes.patch>
Thanks, merged and pushed.
Yuan
next prev parent reply other threads:[~2022-11-14 9:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-13 20:42 bug#59251: 29.0.50; Fix-some-inconsistencies-in-ts-modes Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
[not found] ` <handler.59251.B.16683721605982.ack@debbugs.gnu.org>
2022-11-13 22:16 ` bug#59251: Acknowledgement (29.0.50; Fix-some-inconsistencies-in-ts-modes) Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-11-13 23:01 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-11-14 0:51 ` Yuan Fu
2022-11-14 7:06 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-11-14 9:25 ` Yuan Fu [this message]
2022-11-15 12:22 ` Eli Zaretskii
2022-11-15 14:22 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-11-14 19:02 ` Eli Zaretskii
2022-11-14 18:59 ` bug#59251: 29.0.50; Fix-some-inconsistencies-in-ts-modes Eli Zaretskii
2022-11-14 19:12 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54E210C8-9CE7-49AE-811E-BF367D070031@gmail.com \
--to=casouri@gmail.com \
--cc=59251@debbugs.gnu.org \
--cc=done-59251@debbugs.gnu.org \
--cc=theo@thornhill.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.