From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.bugs Subject: bug#59251: Acknowledgement (29.0.50; Fix-some-inconsistencies-in-ts-modes) Date: Mon, 14 Nov 2022 01:25:09 -0800 Message-ID: <54E210C8-9CE7-49AE-811E-BF367D070031@gmail.com> References: <87k03ya8no.fsf@thornhill.no> <87cz9qa4ab.fsf@thornhill.no> <87a64u31d0.fsf@thornhill.no> <6C5721BF-2FA2-45A4-A970-483D662A6414@gmail.com> <877czy2ex4.fsf@thornhill.no> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21898"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 59251@debbugs.gnu.org, done-59251@debbugs.gnu.org To: Theodor Thornhill Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Nov 15 01:35:12 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oujuy-0005Tw-3n for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 15 Nov 2022 01:35:12 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ouiok-0000lE-JC; Mon, 14 Nov 2022 18:24:42 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ouifp-0004sK-RU for bug-gnu-emacs@gnu.org; Mon, 14 Nov 2022 18:15:31 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ouVj8-0005gy-8y for bug-gnu-emacs@gnu.org; Mon, 14 Nov 2022 04:26:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ouVj7-0003wH-WF for bug-gnu-emacs@gnu.org; Mon, 14 Nov 2022 04:26:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Yuan Fu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 14 Nov 2022 09:26:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59251 X-GNU-PR-Package: emacs Original-Received: via spool by 59251-submit@debbugs.gnu.org id=B59251.166841792015089 (code B ref 59251); Mon, 14 Nov 2022 09:26:01 +0000 Original-Received: (at 59251) by debbugs.gnu.org; 14 Nov 2022 09:25:20 +0000 Original-Received: from localhost ([127.0.0.1]:48925 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ouViS-0003vI-1D for submit@debbugs.gnu.org; Mon, 14 Nov 2022 04:25:20 -0500 Original-Received: from mail-pl1-f176.google.com ([209.85.214.176]:46887) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ouViP-0003v0-G8 for 59251@debbugs.gnu.org; Mon, 14 Nov 2022 04:25:18 -0500 Original-Received: by mail-pl1-f176.google.com with SMTP id l2so9500925pld.13; Mon, 14 Nov 2022 01:25:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=mD2BSXakn7+YuQluNLk79SDRApX624IcEV7aWlZMkz8=; b=Ef7JiKUa8D0fUcFgCgtoEevOt0sy429YgJ4188CyZIsBC0juSW3y/5E4sTa6DikYw+ VnSizDlkF+IcVfLLafyu2e/KClQaZkeYdYMUaf398yjSGqXUcACWdAMdayXfh7nUeolQ YqQRlbxSUqXO9ht/eg0XhlfklVWvpheSw7xXUkwB4W8C5UGEb223ji7lD8illcwBR+mF +4ivPyKHT7NsVIPllv5WeM3ck7GZU6fb+3qeA6COS9epzVfh0iDpWBkWexS88YHtrLCM oXdnzLwEHvpJ5x1MywE9JLdqrRr3SLEsSm5tRxQ4Ehgqg16NpdaXz24LwrpUpaYG0icx KLnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mD2BSXakn7+YuQluNLk79SDRApX624IcEV7aWlZMkz8=; b=xYOwMWkpT1H0B6OgaAyNBRj2FmWJamHBkPuneXA8vCQNScgr3aY8t7IsR4DzU9eJuf Yv9u7iZNY5jkApFbzEqNWawtPH7ei4bSJ3QJtMIrm1UCRdRBLDsFNyRlp372Ancb2mzC ZnhMTinw/7QE9UfA59oONjQ4kLZc6dZKWoOToPH630ycRePZwi5HMQkQk1YkfOEEQ7KJ 4nUBEm+wARQE9LXgcsu5VzcrMjMzn4qxdw8pXhdaxIKjRRss18JFvVM8lt6P3HUH1c/k p1zqEroa+M2t4YvApSNkGzIoA3eA1RyujLcG+Od8isMXUs6CLRlNf8XfDFg0hoiyNQgC Xhgw== X-Gm-Message-State: ANoB5plIJujE2gmW6CwgKmNeKW1Dq3T6wrYMDscyMhXAgT54kULy9xfl UEu5qrEtb3rNE11ZW+LVE6A= X-Google-Smtp-Source: AA0mqf5pRKV9JlJTgMlZSbNmJmlH5z6vk6IZelk3jMagd1PlUWQfQTrgTyOMvbSPmX4ht/fHfWmZZw== X-Received: by 2002:a17:902:7e01:b0:186:b38a:9c4a with SMTP id b1-20020a1709027e0100b00186b38a9c4amr12466529plm.163.1668417911712; Mon, 14 Nov 2022 01:25:11 -0800 (PST) Original-Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id k137-20020a62848f000000b00572552feef3sm136852pfd.51.2022.11.14.01.25.10 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 14 Nov 2022 01:25:11 -0800 (PST) In-Reply-To: <877czy2ex4.fsf@thornhill.no> X-Mailer: Apple Mail (2.3696.120.41.1.1) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:247866 Archived-At: > On Nov 13, 2022, at 11:06 PM, Theodor Thornhill = wrote: >=20 > Yuan Fu writes: >=20 >>> On Nov 13, 2022, at 3:01 PM, Theodor Thornhill via Bug reports for = GNU Emacs, the Swiss army knife of text editors = wrote: >>>=20 >>> Theodor Thornhill writes: >>>=20 >>>> Added a few more finishes. >>>=20 >>> Aaand another. Last one for now. I promise=E2=80=A6 >>=20 >> Cool! Some comments: >>=20 >> +(defcustom c-ts-mode-font-lock-feature-list >> + '((comment preprocessor operator constant string literal keyword) >> + (type definition expression statement) >> + ()) >> + "Language constructs to font-lock. >> + >> +See `treesit-font-lock-feature-list' for description of how to >> +use this variable. Supported features are as defined in >> +`c-ts-mode--font-lock-settings'." >> + :version "29.1" >> + :type 'list >> + :safe 'listp >> + :group 'c) >> + >>=20 >> I think Stefan M=E2=80=99s opinion is to make feature-list private, = and let >> users add/remove features. Right now they can add/remove features = with >> treesit-recompute-feature-list. I guess we can keep them as = defvar=E2=80=99s >> for now, so people as the option to redefine this list should they >> want to. (One argument against having them as custom options is that, >> if a user sets it as a custom option, they will miss out on future >> changes to this variable.) >>=20 >>=20 >> + (setq-local comment-style c-ts-mode-comment-style) >>=20 >> Why don=E2=80=99t we let users set comment style themselves? Does = cc-mode have a similar variable? >>=20 >=20 > You have a point. Simplified the patch. >=20 > Theo >=20 > <0001-Fix-some-inconsistencies-in-ts-modes.patch> Thanks, merged and pushed. Yuan